Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(41 errors, 16 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

auth/ip/auth.php
(#41) Visibility must be declared on method "__construct"
(#54) Visibility must be declared on method "user_login"
(#56) Expected 1 space before "=>"; 0 found
(#56) Expected 1 space after "=>"; 0 found
(#56) Expected 1 space before "=>"; 0 found
(#56) Expected 1 space after "=>"; 0 found
(#58) Variable "userIp" must be all lower-case
(#60) Variable "userIp" must be all lower-case
(#60) Variable "userIp" must be all lower-case
(#77) Visibility must be declared on method "is_ip_valid"
(#78) Inline comments must end in full-stops, exclamation marks, or question marks
(#79) Variable "valid_ips_or_cidrs" must not contain underscores.
(#81) Inline comments must end in full-stops, exclamation marks, or question marks
(#82) Variable "valid_ips_or_cidrs" must not contain underscores.
(#82) Variable "valid_ip_or_cidr" must not contain underscores.
(#83) Inline comments must end in full-stops, exclamation marks, or question marks
(#84) Variable "valid_ip_or_cidr" must not contain underscores.
(#85) Variable "valid_ip_or_cidr" must not contain underscores.
(#87) Variable "ip_net" must not contain underscores.
(#88) Variable "ip_mask" must not contain underscores.
(#90) Variable "ip_ip" must not contain underscores.
(#92) Variable "ip_ip_net" must not contain underscores.
(#92) Variable "ip_ip" must not contain underscores.
(#92) Variable "ip_mask" must not contain underscores.
(#94) Variable "ip_ip_net" must not contain underscores.
(#94) Variable "ip_net" must not contain underscores.
(#97) Inline comments must end in full-stops, exclamation marks, or question marks
(#97) Line indented incorrectly; expected at least 16 spaces, found 12
(#98) Usage of ELSEIF not allowed; use ELSE IF instead
(#98) Variable "valid_ip_or_cidr" must not contain underscores.
(#103) Inline comments must end in full-stops, exclamation marks, or question marks
(#113) Visibility must be declared on method "is_cidr"
(#113) Variable "ip_or_cidr" must not contain underscores.
(#114) Variable "ip_or_cidr" must not contain underscores.
(#122) Visibility must be declared on method "is_internal"
(#132) Visibility must be declared on method "process_config"
(#136) Inline comments must start with a capital letter, digit or 3-dots sequence
(#136) Inline comments must end in full-stops, exclamation marks, or question marks
(#141) Inline comments must start with a capital letter, digit or 3-dots sequence
(#141) Inline comments must end in full-stops, exclamation marks, or question marks
(#141) No space found before comment text; expected "// saving new configuration settings" but found "//saving new configuration settings"
(#144) Inline comments must start with a capital letter, digit or 3-dots sequence
(#144) No space found before comment text; expected "// notify administrator for the settings changed for security." but found "//notify administrator for the settings changed for security."
auth/ip/classes/privacy/provider.php
(#19) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
auth/ip/tests/ip_test.php
(#22) PHPUnit testcase name "auth_ip_testcase" does not match file name "ip_test"
(#22) PHPUnit class "auth_ip_testcase" does not have any namespace. It is recommended to add it to the "auth_ip" namespace, using more levels if needed, in order to match the code being tested
(#38) Variable "valid_ips" must not contain underscores.
(#38) Variable "is_valid" must not contain underscores.
(#39) Variable "valid_ips" must not contain underscores.
(#42) Variable "is_valid" must not contain underscores.
(#59) Inline comments must end in full-stops, exclamation marks, or question marks
(#71) Variable "ip_or_cidr" must not contain underscores.
(#71) Variable "is_cidr" must not contain underscores.
(#73) Variable "ip_or_cidr" must not contain underscores.
(#74) Variable "is_cidr" must not contain underscores.
auth/ip/version.php
(#30) Inline comments must end in full-stops, exclamation marks, or question marks
(#32) Inline comments must end in full-stops, exclamation marks, or question marks

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(16 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

auth/ip/auth.php
(#22) Package auth is not valid
(#41) Function auth_plugin_ip::__construct is not documented
(#74) Phpdocs for function auth_plugin_ip::is_ip_valid has incomplete parameters list
auth/ip/classes/privacy/provider.php
(#21) Package is not specified for class provider. It is also not specified in file-level phpdocs
(#21) Class provider is not documented
auth/ip/lang/ca/auth_ip.php
(#20) Package auth is not valid
auth/ip/lang/en/auth_ip.php
(#20) Package auth is not valid
auth/ip/lang/es/auth_ip.php
(#20) Package auth is not valid
auth/ip/settings.php
(#16) No one-line description found in phpdocs for file
(#16) File-level phpdocs block does not have @license tag
auth/ip/tests/ip_test.php
(#22) Package is not specified for class auth_ip_testcase. It is also not specified in file-level phpdocs
(#22) Class auth_ip_testcase is not documented
(#23) Variable auth_ip_testcase::$authplugin is not documented
(#47) There is no description in phpdocs for function is_ip_valid_data_provider
(#78) There is no description in phpdocs for function is_cidr_data_provider
auth/ip/version.php
(#20) Package auth is not valid

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Missing changes in external functions or backup support for new detected tables or columns

(0 errors, 0 warnings)

This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]