Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(11 errors, 13 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

auth/classlink/auth.php
(#43) Variable "STATEADDITIONALDATA" must be all lower-case
(#46) Variable "STATEADDITIONALDATA" must be all lower-case
(#46) Variable "STATEADDITIONALDATA" must be all lower-case
(#47) Variable "STATEADDITIONALDATA" must be all lower-case
auth/classlink/classes/loginflow/authcode.php
(#173) Variable "STATEADDITIONALDATA" must be all lower-case
(#219) Variable "STATEADDITIONALDATA" must be all lower-case
auth/classlink/classes/loginflow/base.php
(#100) This comment is 88% valid code; is this commented out code?
(#191) Line exceeds 132 characters; contains 139 characters
(#206) Line exceeds 132 characters; contains 148 characters
(#223) Line exceeds 132 characters; contains 133 characters
(#430) Line exceeds 132 characters; contains 135 characters
auth/classlink/classes/loginflow/rocreds.php
(#118) The use of function error_log() is forbidden; use debugging() instead
auth/classlink/classes/privacy/provider.php
(#36) Duplicate interface name "auth_classlink\privacy\auth_classlink_userlist" found; first defined in /var/lib/jenkins/git_repositories/prechecker/auth/classlink/classes/privacy/provider.php on line 32
auth/classlink/classes/tests/mockazureb2cclient.php
(#39) Possible useless method overriding detected
auth/classlink/classes/utils.php
(#104) The use of function print_r() is forbidden
(#106) The use of function print_r() is forbidden
auth/classlink/index.php
(#23) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
auth/classlink/settings.php
(#57) Line exceeds 132 characters; contains 134 characters
(#76) Line exceeds 132 characters; contains 133 characters
(#81) Line exceeds 132 characters; contains 137 characters
(#97) Line exceeds 132 characters; contains 137 characters
auth/classlink/tests/privacy_provider_test.php
(#265) The static declaration must come after the visibility declaration
(#290) The static declaration must come after the visibility declaration
auth/classlink/version.php
(#27) Inline comments must end in full-stops, exclamation marks, or question marks

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(20 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

auth/classlink/styles.css
(#3) Expected newline before "}" (block-closing-brace-newline-before)
(#6) Expected newline before "}" (block-closing-brace-newline-before)
(#8) Expected newline before "}" (block-closing-brace-newline-before)
(#2) Expected indentation of 4 spaces (indentation)
(#3) Expected indentation of 4 spaces (indentation)
(#5) Expected indentation of 4 spaces (indentation)
(#6) Expected indentation of 4 spaces (indentation)
auth/classlink/sass/styles.scss
(#2) Expected indentation of 4 spaces (indentation)
(#5) Expected indentation of 4 spaces (indentation)
(#3) Expected indentation of 8 spaces (indentation)
(#4) Expected indentation of 8 spaces (indentation)
(#6) Expected indentation of 4 spaces (indentation)
(#12) Expected indentation of 4 spaces (indentation)
(#7) Expected indentation of 8 spaces (indentation)
(#8) Expected indentation of 8 spaces (indentation)
(#9) Expected indentation of 8 spaces (indentation)
(#11) Expected indentation of 8 spaces (indentation)
(#10) Expected indentation of 12 spaces (indentation)
auth/classlink/classes/form/adminsetting/iconselect.css
(#2) Unexpected !important (declaration-no-important)
(#3) Unexpected !important (declaration-no-important)

PHPDocs style problems

(60 errors, 2 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

auth/classlink/auth.php
(#17) No one-line description found in phpdocs for file
(#39) Phpdocs for function auth_plugin_classlink::__construct has incomplete parameters list
(#80) Phpdocs for function auth_plugin_classlink::set_httpclient has incomplete parameters list
(#111) Phpdocs for function auth_plugin_classlink::disconnect has incomplete parameters list
(#90) Not recommended phpdocs tag @global used
(#90) Not recommended phpdocs tag @global used
auth/classlink/classes/classlinkclient.php
(#118) Function classlinkclient::get_endpoint is not documented
(#17) No one-line description found in phpdocs for file
(#57) Phpdocs for function classlinkclient::setcreds has incomplete parameters list
(#160) Phpdocs for function classlinkclient::getnewstate has incomplete parameters list
(#235) Phpdocs for function classlinkclient::tokenrequest has incomplete parameters list
auth/classlink/classes/event/action_failed.php
(#17) No one-line description found in phpdocs for file
auth/classlink/classes/event/user_authed.php
(#17) No one-line description found in phpdocs for file
auth/classlink/classes/event/user_connected.php
(#17) No one-line description found in phpdocs for file
auth/classlink/classes/event/user_created.php
(#17) No one-line description found in phpdocs for file
auth/classlink/classes/event/user_disconnected.php
(#17) No one-line description found in phpdocs for file
auth/classlink/classes/event/user_loggedin.php
(#17) No one-line description found in phpdocs for file
auth/classlink/classes/form/adminsetting/iconselect.php
(#17) No one-line description found in phpdocs for file
auth/classlink/classes/form/adminsetting/loginflow.php
(#17) No one-line description found in phpdocs for file
auth/classlink/classes/form/adminsetting/redirecturi.php
(#17) No one-line description found in phpdocs for file
(#34) Phpdocs for function redirecturi::__construct has incomplete parameters list
(#63) Phpdocs for function redirecturi::write_setting has incomplete parameters list
(#72) Phpdocs for function redirecturi::output_html has incomplete parameters list
auth/classlink/classes/form/disconnect.php
(#17) No one-line description found in phpdocs for file
auth/classlink/classes/httpclient.php
(#17) No one-line description found in phpdocs for file
auth/classlink/classes/httpclientinterface.php
(#17) No one-line description found in phpdocs for file
auth/classlink/classes/jwt.php
(#17) No one-line description found in phpdocs for file
auth/classlink/classes/loginflow/authcode.php
(#17) No one-line description found in phpdocs for file
(#384) Phpdocs for function authcode::check_for_matched has incomplete parameters list
auth/classlink/classes/loginflow/base.php
(#26) Class base is not documented
(#33) Function base::__construct is not documented
(#17) No one-line description found in phpdocs for file
(#78) Phpdocs for function base::loginpage_hook has incomplete parameters list
(#135) Phpdocs for function base::set_httpclient has incomplete parameters list
(#144) Phpdocs for function base::disconnect has incomplete parameters list
(#423) Phpdocs for function base::createtoken has incomplete parameters list
auth/classlink/classes/loginflow/rocreds.php
(#17) No one-line description found in phpdocs for file
(#32) Phpdocs for function rocreds::check_objects has incomplete parameters list
(#55) Phpdocs for function rocreds::loginpage_hook has incomplete parameters list
auth/classlink/classes/observers.php
(#17) No one-line description found in phpdocs for file
auth/classlink/classes/privacy/provider.php
(#41) Class provider is not documented
(#17) No one-line description found in phpdocs for file
auth/classlink/classes/tests/mockazureb2cclient.php
(#17) No one-line description found in phpdocs for file
(#36) Phpdocs for function mockclasslinkclient::getnewstate has incomplete parameters list
auth/classlink/classes/tests/mockhttpclient.php
(#17) No one-line description found in phpdocs for file
auth/classlink/classes/utils.php
(#17) No one-line description found in phpdocs for file
(#34) Phpdocs for function utils::process_json_response has incomplete parameters list
(#113) Phpdocs for function utils::debug has incomplete parameters list
auth/classlink/db/access.php
(#17) No one-line description found in phpdocs for file
auth/classlink/db/events.php
(#17) No one-line description found in phpdocs for file
auth/classlink/db/upgrade.php
(#17) No one-line description found in phpdocs for file
auth/classlink/index.php
(#17) No one-line description found in phpdocs for file
auth/classlink/lang/en/auth_classlink.php
(#17) No one-line description found in phpdocs for file
auth/classlink/lib.php
(#24) Function auth_classlink_initialize_customicon is not documented
(#17) No one-line description found in phpdocs for file
auth/classlink/settings.php
(#17) No one-line description found in phpdocs for file
auth/classlink/tests/classlinkclient_test.php
(#17) No one-line description found in phpdocs for file
(#102) Phpdocs for function auth_classlink_classlinkclient_testcase::test_endpoints_getters_and_setters has incomplete parameters list
auth/classlink/tests/jwt_test.php
(#17) No one-line description found in phpdocs for file
(#109) Phpdocs for function auth_classlink_jwt_testcase::test_decode has incomplete parameters list
auth/classlink/ucp.php
(#17) No one-line description found in phpdocs for file
auth/classlink/version.php
(#17) No one-line description found in phpdocs for file

Update savepoints problems

(1 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

auth/classlink/db/upgrade.php
'return true;' not found

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]