Prechecker results: error

PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]

PHP coding style problems

(42 errors, 24 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

auth/azureb2c/auth.php: (#43) Variable "STATEADDITIONALDATA" must be all lower-case; (#46) Variable "STATEADDITIONALDATA" must be all lower-case; (#46) Variable "STATEADDITIONALDATA" must be all lower-case; (#47) Variable "STATEADDITIONALDATA" must be all lower-case; (#94) Inline comments must start with a capital letter, digit or 3-dots sequence; (#94) Inline comments must end in full-stops, exclamation marks, or question marks; (#95) Inline comments must start with a capital letter, digit or 3-dots sequence; (#95) Inline comments must end in full-stops, exclamation marks, or question marks
auth/azureb2c/classes/azureb2cclient.php: (#131) Whitespace found at end of line; (#134) Commas (,) must be followed by white space.; (#134) Inline comments must end in full-stops, exclamation marks, or question marks; (#136) Expected 1 space after "=>"; 2 found; (#152) Whitespace found at end of line; (#243) Functions must not contain multiple empty lines in a row; found 2 empty lines; (#244) Whitespace found at end of line
auth/azureb2c/classes/form/adminsetting/iconselect.php: (#90) Line exceeds 132 characters; contains 154 characters
auth/azureb2c/classes/httpclient.php: (#26) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
auth/azureb2c/classes/loginflow/authcode.php: (#173) Variable "STATEADDITIONALDATA" must be all lower-case; (#176) Inline comments must end in full-stops, exclamation marks, or question marks; (#179) Inline comments must start with a capital letter, digit or 3-dots sequence; (#179) This comment is 72% valid code; is this commented out code?; (#179) No space found before comment text; expected "// return;" but found "//return;"; (#180) Inline comments must end in full-stops, exclamation marks, or question marks; (#180) No space found before comment text; expected "// echo "Text found";" but found "//echo "Text found";"; (#181) Expected "} else if (...) {\n"; found "} else if (...){\n"; (#181) Expected "if (...) {\n"; found "if (...){\n"; (#182) No space found before comment text; expected "// AADB2C90118: The user has forgotten their password." but found "//AADB2C90118: The user has forgotten their password."; (#184) Line exceeds maximum limit of 180 characters; contains 258 characters; (#186) Whitespace found at end of line; (#216) Variable "STATEADDITIONALDATA" must be all lower-case; (#320) Inline comments must start with a capital letter, digit or 3-dots sequence; (#453) Expected 1 space before comment text but found 5; use block comment if you need indentation; (#454) Expected 1 space before comment text but found 5; use block comment if you need indentation
auth/azureb2c/classes/loginflow/base.php: (#122) Inline comments must start with a capital letter, digit or 3-dots sequence; (#122) This comment is 78% valid code; is this commented out code?; (#122) No space found before comment text; expected "// $userinfo['email'] = $email;" but found "//$userinfo['email'] = $email;"; (#134) Whitespace found at end of line; (#138) Expected 1 space after "as"; 2 found; (#141) Inline control structures are not allowed; (#144) Line indented incorrectly; expected 8 spaces, found 4; (#144) Closing brace indented incorrectly; expected 8 spaces, found 4; (#218) Line exceeds 132 characters; contains 139 characters; (#233) Line exceeds 132 characters; contains 144 characters; (#250) Line exceeds 132 characters; contains 133 characters; (#457) Line exceeds 132 characters; contains 133 characters
auth/azureb2c/classes/loginflow/rocreds.php: (#118) The use of function error_log() is forbidden; use debugging() instead
auth/azureb2c/classes/observers.php: (#26) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
auth/azureb2c/classes/privacy/provider.php: (#31) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.; (#32) Closing brace must be on a line by itself; (#34) Duplicate interface name "auth_azureb2c\privacy\auth_azureb2c_userlist" found; first defined in /var/lib/jenkins/git_repositories/prechecker/auth/azureb2c/classes/privacy/provider.php on line 32; (#34) Closing brace must be on a line by itself
auth/azureb2c/classes/tests/mockazureb2cclient.php: (#39) Possible useless method overriding detected
auth/azureb2c/classes/utils.php: (#104) The use of function print_r() is forbidden; (#106) The use of function print_r() is forbidden; (#136) File must end with a newline character
auth/azureb2c/db/events.php: (#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.; (#31) File must end with a newline character
auth/azureb2c/index.php: (#24) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
auth/azureb2c/lang/id/auth_azureb2c.php: (#169) File must end with a newline character
auth/azureb2c/settings.php: (#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.; (#52) Line exceeds 132 characters; contains 133 characters; (#57) Line exceeds 132 characters; contains 135 characters; (#91) Line exceeds 132 characters; contains 136 characters; (#177) Line exceeds 132 characters; contains 135 characters
auth/azureb2c/tests/privacy_provider_test.php: (#265) The static declaration must come after the visibility declaration; (#290) The static declaration must come after the visibility declaration

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

CSS problems

(20 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

auth/azureb2c/styles.css: (#3) Expected newline before "}" (block-closing-brace-newline-before); (#6) Expected newline before "}" (block-closing-brace-newline-before); (#8) Expected newline before "}" (block-closing-brace-newline-before); (#2) Expected indentation of 4 spaces (indentation); (#3) Expected indentation of 4 spaces (indentation); (#5) Expected indentation of 4 spaces (indentation); (#6) Expected indentation of 4 spaces (indentation)
auth/azureb2c/sass/styles.scss: (#2) Expected indentation of 4 spaces (indentation); (#5) Expected indentation of 4 spaces (indentation); (#3) Expected indentation of 8 spaces (indentation); (#4) Expected indentation of 8 spaces (indentation); (#6) Expected indentation of 4 spaces (indentation); (#12) Expected indentation of 4 spaces (indentation); (#7) Expected indentation of 8 spaces (indentation); (#8) Expected indentation of 8 spaces (indentation); (#9) Expected indentation of 8 spaces (indentation); (#11) Expected indentation of 8 spaces (indentation); (#10) Expected indentation of 12 spaces (indentation)
auth/azureb2c/classes/form/adminsetting/iconselect.css: (#2) Unexpected !important (declaration-no-important); (#3) Unexpected !important (declaration-no-important)

PHPDocs style problems

(61 errors, 2 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

auth/azureb2c/auth.php: (#17) No one-line description found in phpdocs for file; (#39) Phpdocs for function auth_plugin_azureb2c::__construct has incomplete parameters list; (#80) Phpdocs for function auth_plugin_azureb2c::set_httpclient has incomplete parameters list; (#111) Phpdocs for function auth_plugin_azureb2c::disconnect has incomplete parameters list; (#90) Not recommended phpdocs tag @global used; (#90) Not recommended phpdocs tag @global used
auth/azureb2c/classes/azureb2cclient.php: (#118) Function azureb2cclient::get_endpoint is not documented; (#17) No one-line description found in phpdocs for file; (#57) Phpdocs for function azureb2cclient::setcreds has incomplete parameters list; (#160) Phpdocs for function azureb2cclient::getnewstate has incomplete parameters list; (#235) Phpdocs for function azureb2cclient::tokenrequest has incomplete parameters list
auth/azureb2c/classes/event/action_failed.php: (#17) No one-line description found in phpdocs for file
auth/azureb2c/classes/event/user_authed.php: (#17) No one-line description found in phpdocs for file
auth/azureb2c/classes/event/user_connected.php: (#17) No one-line description found in phpdocs for file
auth/azureb2c/classes/event/user_created.php: (#17) No one-line description found in phpdocs for file
auth/azureb2c/classes/event/user_disconnected.php: (#17) No one-line description found in phpdocs for file
auth/azureb2c/classes/event/user_loggedin.php: (#17) No one-line description found in phpdocs for file
auth/azureb2c/classes/form/adminsetting/iconselect.php: (#17) No one-line description found in phpdocs for file
auth/azureb2c/classes/form/adminsetting/loginflow.php: (#17) No one-line description found in phpdocs for file
auth/azureb2c/classes/form/adminsetting/redirecturi.php: (#17) No one-line description found in phpdocs for file; (#34) Phpdocs for function redirecturi::__construct has incomplete parameters list; (#63) Phpdocs for function redirecturi::write_setting has incomplete parameters list; (#72) Phpdocs for function redirecturi::output_html has incomplete parameters list
auth/azureb2c/classes/form/disconnect.php: (#17) No one-line description found in phpdocs for file
auth/azureb2c/classes/httpclient.php: (#17) No one-line description found in phpdocs for file
auth/azureb2c/classes/httpclientinterface.php: (#17) No one-line description found in phpdocs for file
auth/azureb2c/classes/jwt.php: (#17) No one-line description found in phpdocs for file
auth/azureb2c/classes/loginflow/authcode.php: (#17) No one-line description found in phpdocs for file; (#381) Phpdocs for function authcode::check_for_matched has incomplete parameters list
auth/azureb2c/classes/loginflow/base.php: (#26) Class base is not documented; (#33) Function base::__construct is not documented; (#17) No one-line description found in phpdocs for file; (#78) Phpdocs for function base::loginpage_hook has incomplete parameters list; (#162) Phpdocs for function base::set_httpclient has incomplete parameters list; (#171) Phpdocs for function base::disconnect has incomplete parameters list; (#450) Phpdocs for function base::createtoken has incomplete parameters list
auth/azureb2c/classes/loginflow/rocreds.php: (#17) No one-line description found in phpdocs for file; (#32) Phpdocs for function rocreds::check_objects has incomplete parameters list; (#55) Phpdocs for function rocreds::loginpage_hook has incomplete parameters list
auth/azureb2c/classes/observers.php: (#17) No one-line description found in phpdocs for file
auth/azureb2c/classes/privacy/provider.php: (#37) Class provider is not documented; (#17) No one-line description found in phpdocs for file
auth/azureb2c/classes/tests/mockazureb2cclient.php: (#17) No one-line description found in phpdocs for file; (#36) Phpdocs for function mockazureb2cclient::getnewstate has incomplete parameters list
auth/azureb2c/classes/tests/mockhttpclient.php: (#17) No one-line description found in phpdocs for file
auth/azureb2c/classes/utils.php: (#17) No one-line description found in phpdocs for file; (#34) Phpdocs for function utils::process_json_response has incomplete parameters list; (#113) Phpdocs for function utils::debug has incomplete parameters list
auth/azureb2c/db/access.php: (#17) No one-line description found in phpdocs for file
auth/azureb2c/db/events.php: (#17) No one-line description found in phpdocs for file
auth/azureb2c/db/upgrade.php: (#17) No one-line description found in phpdocs for file
auth/azureb2c/index.php: (#17) No one-line description found in phpdocs for file
auth/azureb2c/lang/en/auth_azureb2c.php: (#17) No one-line description found in phpdocs for file
auth/azureb2c/lang/id/auth_azureb2c.php: (#17) No one-line description found in phpdocs for file
auth/azureb2c/lib.php: (#24) Function auth_azureb2c_initialize_customicon is not documented; (#17) No one-line description found in phpdocs for file
auth/azureb2c/settings.php: (#17) No one-line description found in phpdocs for file
auth/azureb2c/tests/azureb2cclient_test.php: (#17) No one-line description found in phpdocs for file; (#102) Phpdocs for function auth_azureb2c_azureb2cclient_testcase::test_endpoints_getters_and_setters has incomplete parameters list
auth/azureb2c/tests/jwt_test.php: (#17) No one-line description found in phpdocs for file; (#109) Phpdocs for function auth_azureb2c_jwt_testcase::test_decode has incomplete parameters list
auth/azureb2c/ucp.php: (#17) No one-line description found in phpdocs for file
auth/azureb2c/version.php: (#17) No one-line description found in phpdocs for file

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]

grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

: Problems running grunt; Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]

Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]