PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]

PHP coding style problems

(286 errors, 71 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

auth/a2fa/GoogleAuthenticator.php: (#2) The opening <?php tag must be followed by exactly one newline.; (#12) Expected MOODLE_INTERNAL check or config.php inclusion; (#14) Member variable "_codeLength" must be all lower-case; (#23) Public method name "PHPGangsta_GoogleAuthenticator::createSecret" must be in lower-case letters only; (#23) Variable "secretLength" must be all lower-case; (#24) Opening brace should be on the same line as the declaration; (#25) Variable "validChars" must be all lower-case; (#26) Variable "validChars" must be all lower-case; (#29) Variable "secretLength" must be all lower-case; (#30) Variable "validChars" must be all lower-case; (#30) Variable "validChars" must be all lower-case; (#42) Public method name "PHPGangsta_GoogleAuthenticator::getCode" must be in lower-case letters only; (#42) Variable "timeSlice" must be all lower-case; (#43) Opening brace should be on the same line as the declaration; (#44) Variable "timeSlice" must be all lower-case; (#45) Variable "timeSlice" must be all lower-case; (#50) Inline comments must end in full-stops, exclamation marks, or question marks; (#51) Variable "timeSlice" must be all lower-case; (#52) Inline comments must end in full-stops, exclamation marks, or question marks; (#54) Inline comments must end in full-stops, exclamation marks, or question marks; (#56) Inline comments must start with a capital letter, digit or 3-dots sequence; (#56) Inline comments must end in full-stops, exclamation marks, or question marks; (#59) Inline comments must end in full-stops, exclamation marks, or question marks; (#62) Inline comments must end in full-stops, exclamation marks, or question marks; (#76) Public method name "PHPGangsta_GoogleAuthenticator::getQRCodeGoogleUrl" must be in lower-case letters only; (#89) Public method name "PHPGangsta_GoogleAuthenticator::verifyCode" must be in lower-case letters only; (#90) Opening brace should be on the same line as the declaration; (#91) Variable "currentTimeSlice" must be all lower-case; (#94) Variable "calculatedCode" must be all lower-case; (#94) Variable "currentTimeSlice" must be all lower-case; (#95) Variable "calculatedCode" must be all lower-case; (#109) Public method name "PHPGangsta_GoogleAuthenticator::setCodeLength" must be in lower-case letters only; (#110) Opening brace should be on the same line as the declaration; (#121) Protected method name "PHPGangsta_GoogleAuthenticator::_base32Decode" must be in lower-case letters only; (#122) Opening brace should be on the same line as the declaration; (#123) Inline control structures are not allowed; (#126) Variable "base32charsFlipped" must be all lower-case; (#128) Variable "paddingCharCount" must be all lower-case; (#129) Variable "allowedValues" must be all lower-case; (#130) Inline control structures are not allowed; (#130) Variable "paddingCharCount" must be all lower-case; (#130) Variable "allowedValues" must be all lower-case; (#131) Expected "for (...) {\n"; found "for (...){\n"; (#132) Inline control structures are not allowed; (#132) Variable "paddingCharCount" must be all lower-case; (#132) Variable "allowedValues" must be all lower-case; (#133) Variable "allowedValues" must be all lower-case; (#133) Variable "allowedValues" must be all lower-case; (#135) Commas (,) must be followed by white space.; (#137) Variable "binaryString" must be all lower-case; (#138) Expected 1 space before "+"; 0 found; (#138) Expected 1 space after "+"; 0 found; (#140) Inline control structures are not allowed; (#142) Variable "base32charsFlipped" must be all lower-case; (#144) Variable "eightBits" must be all lower-case; (#145) Variable "eightBits" must be all lower-case; (#146) Variable "binaryString" must be all lower-case; (#146) Variable "eightBits" must be all lower-case; (#146) Expected 1 space before ":"; 0 found; (#146) Expected 1 space after ":"; 0 found; (#149) Variable "binaryString" must be all lower-case; (#159) Protected method name "PHPGangsta_GoogleAuthenticator::_base32Encode" must be in lower-case letters only; (#160) Opening brace should be on the same line as the declaration; (#161) Inline control structures are not allowed; (#166) Variable "binaryString" must be all lower-case; (#168) Variable "binaryString" must be all lower-case; (#170) Variable "fiveBitBinaryArray" must be all lower-case; (#170) Variable "binaryString" must be all lower-case; (#173) Variable "fiveBitBinaryArray" must be all lower-case; (#174) Variable "fiveBitBinaryArray" must be all lower-case; (#177) Variable "binaryString" must be all lower-case; (#178) Inline control structures are not allowed; (#179) Inline control structures are not allowed; (#179) Usage of ELSEIF not allowed; use ELSE IF instead; (#180) Inline control structures are not allowed; (#180) Usage of ELSEIF not allowed; use ELSE IF instead; (#181) Inline control structures are not allowed; (#181) Usage of ELSEIF not allowed; use ELSE IF instead; (#191) Protected method name "PHPGangsta_GoogleAuthenticator::_getBase32LookupTable" must be in lower-case letters only; (#192) Opening brace should be on the same line as the declaration; (#194) This comment is 50% valid code; is this commented out code?; (#194) Expected 1 space before comment text but found 2; use block comment if you need indentation; (#195) This comment is 50% valid code; is this commented out code?; (#196) This comment is 50% valid code; is this commented out code?; (#197) This comment is 50% valid code; is this commented out code?; (#198) Inline comments must end in full-stops, exclamation marks, or question marks
auth/a2fa/auth.php: (#38) PHP4 style constructors are not allowed; use "__construct()" instead; (#38) Visibility must be declared on method "auth_plugin_a2fa"; (#50) Visibility must be declared on method "user_login"; (#52) Spaces must be used to indent lines; tabs are not allowed; (#52) Tab found within whitespace; (#52) Line indented incorrectly; expected at least 8 spaces, found 1; (#53) Spaces must be used to indent lines; tabs are not allowed; (#53) Tab found within whitespace; (#53) Whitespace found at end of line; (#54) Spaces must be used to indent lines; tabs are not allowed; (#54) Tab found within whitespace; (#54) Line indented incorrectly; expected 8 spaces, found 1; (#54) Expected 1 space before "=>"; 0 found; (#54) Expected 1 space after "=>"; 0 found; (#54) Expected 1 space before "=>"; 0 found; (#54) Expected 1 space after "=>"; 0 found; (#55) Spaces must be used to indent lines; tabs are not allowed; (#55) Tab found within whitespace; (#55) Line indented incorrectly; expected at least 12 spaces, found 2; (#55) Variable "valid_login" must not contain underscores.; (#56) Spaces must be used to indent lines; tabs are not allowed; (#56) Tab found within whitespace; (#56) Line indented incorrectly; expected 12 spaces, found 2; (#56) Expected "if (...) {\n"; found "if(...){\n"; (#56) Variable "valid_login" must not contain underscores.; (#57) Spaces must be used to indent lines; tabs are not allowed; (#57) Tab found within whitespace; (#57) Line indented incorrectly; expected at least 16 spaces, found 3; (#57) Expected 1 space before "=>"; 0 found; (#57) Expected 1 space after "=>"; 0 found; (#58) Spaces must be used to indent lines; tabs are not allowed; (#58) Tab found within whitespace; (#58) Line indented incorrectly; expected at least 16 spaces, found 3; (#59) Spaces must be used to indent lines; tabs are not allowed; (#59) Tab found within whitespace; (#59) Line indented incorrectly; expected at least 16 spaces, found 3; (#60) Spaces must be used to indent lines; tabs are not allowed; (#60) Tab found within whitespace; (#60) Whitespace found at end of line; (#61) Spaces must be used to indent lines; tabs are not allowed; (#61) Tab found within whitespace; (#61) Line indented incorrectly; expected at least 16 spaces, found 3; (#62) Spaces must be used to indent lines; tabs are not allowed; (#62) Tab found within whitespace; (#62) Line indented incorrectly; expected at least 16 spaces, found 3; (#62) Expected 1 space before "=>"; 0 found; (#62) Expected 1 space after "=>"; 0 found; (#62) Expected 1 space before "=>"; 0 found; (#62) Expected 1 space after "=>"; 0 found; (#63) Spaces must be used to indent lines; tabs are not allowed; (#63) Tab found within whitespace; (#63) Line indented incorrectly; expected 16 spaces, found 3; (#63) Expected "if (...) {\n"; found "if(...){\n"; (#64) Spaces must be used to indent lines; tabs are not allowed; (#64) Tab found within whitespace; (#64) Line indented incorrectly; expected at least 20 spaces, found 4; (#65) Spaces must be used to indent lines; tabs are not allowed; (#65) Tab found within whitespace; (#65) Line indented incorrectly; expected at least 20 spaces, found 4; (#66) Spaces must be used to indent lines; tabs are not allowed; (#66) Tab found within whitespace; (#66) Line indented incorrectly; expected 16 spaces, found 3; (#67) Spaces must be used to indent lines; tabs are not allowed; (#67) Tab found within whitespace; (#67) Line indented incorrectly; expected 16 spaces, found 3; (#67) Expected "} else {\n"; found "}\n\t\t\telse{\n"; (#68) Spaces must be used to indent lines; tabs are not allowed; (#68) Tab found within whitespace; (#68) Line indented incorrectly; expected at least 20 spaces, found 4; (#68) Variable "checkResult" must be all lower-case; (#69) Spaces must be used to indent lines; tabs are not allowed; (#69) Tab found within whitespace; (#69) Line indented incorrectly; expected 20 spaces, found 4; (#69) Expected "if (...) {\n"; found "if(...){\n"; (#69) Variable "checkResult" must be all lower-case; (#70) Spaces must be used to indent lines; tabs are not allowed; (#70) Tab found within whitespace; (#70) Line indented incorrectly; expected at least 24 spaces, found 5; (#71) Spaces must be used to indent lines; tabs are not allowed; (#71) Tab found within whitespace; (#71) Line indented incorrectly; expected 20 spaces, found 4; (#72) Spaces must be used to indent lines; tabs are not allowed; (#72) Tab found within whitespace; (#72) Line indented incorrectly; expected 20 spaces, found 4; (#72) Expected "} else {\n"; found "}\n\t\t\t\telse{\n"; (#73) Spaces must be used to indent lines; tabs are not allowed; (#73) Tab found within whitespace; (#73) Line indented incorrectly; expected at least 24 spaces, found 5; (#74) Spaces must be used to indent lines; tabs are not allowed; (#74) Tab found within whitespace; (#74) Line indented incorrectly; expected 20 spaces, found 4; (#75) Spaces must be used to indent lines; tabs are not allowed; (#75) Tab found within whitespace; (#75) Line indented incorrectly; expected 16 spaces, found 3; (#76) Spaces must be used to indent lines; tabs are not allowed; (#76) Tab found within whitespace; (#76) Line indented incorrectly; expected 12 spaces, found 2; (#77) Spaces must be used to indent lines; tabs are not allowed; (#77) Tab found within whitespace; (#77) Line indented incorrectly; expected 12 spaces, found 2; (#77) Expected "} else {\n"; found "}\n\t\telse{\n"; (#78) Spaces must be used to indent lines; tabs are not allowed; (#78) Tab found within whitespace; (#78) Line indented incorrectly; expected at least 16 spaces, found 3; (#79) Spaces must be used to indent lines; tabs are not allowed; (#79) Tab found within whitespace; (#79) Line indented incorrectly; expected 12 spaces, found 2; (#80) Spaces must be used to indent lines; tabs are not allowed; (#80) Tab found within whitespace; (#80) Line indented incorrectly; expected 8 spaces, found 1; (#81) Spaces must be used to indent lines; tabs are not allowed; (#81) Tab found within whitespace; (#81) Line indented incorrectly; expected 8 spaces, found 1; (#81) Expected "} else {\n"; found "}\n\telse{\n"; (#82) Spaces must be used to indent lines; tabs are not allowed; (#82) Tab found within whitespace; (#82) Line indented incorrectly; expected at least 12 spaces, found 2; (#83) Spaces must be used to indent lines; tabs are not allowed; (#83) Tab found within whitespace; (#83) Line indented incorrectly; expected 8 spaces, found 1; (#86) Visibility must be declared on method "loginpage_hook"; (#87) Spaces must be used to indent lines; tabs are not allowed; (#87) Tab found within whitespace; (#87) Whitespace found at end of line; (#100) Visibility must be declared on method "user_update_password"; (#108) Visibility must be declared on method "prevent_local_passwords"; (#117) Visibility must be declared on method "is_internal"; (#127) Visibility must be declared on method "can_change_password"; (#137) Visibility must be declared on method "change_password_url"; (#146) Visibility must be declared on method "can_reset_password"; (#155) Visibility must be declared on method "can_be_manually_set"; (#167) Visibility must be declared on method "config_form"; (#167) Variable "user_fields" must not contain underscores.; (#168) "include" must be immediately followed by an open parenthesis; (#174) Visibility must be declared on method "process_config"
auth/a2fa/error.php: (#2) The opening <?php tag must be followed by exactly one newline.; (#26) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
auth/a2fa/generate.php: (#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".; (#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <http://www.gnu.org/licenses/>.".; (#17) Expected 1 space(s) before asterisk; 0 found; (#18) Expected 1 space(s) before asterisk; 0 found; (#19) Expected 1 space(s) before asterisk; 0 found; (#20) Expected 1 space(s) before asterisk; 0 found; (#21) Expected 1 space(s) before asterisk; 0 found; (#22) Expected 1 space(s) before asterisk; 0 found; (#23) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.; (#28) Expected "if (...) {\n"; found "if(...){\n"; (#29) Spaces must be used to indent lines; tabs are not allowed; (#29) Tab found within whitespace; (#29) Line indented incorrectly; expected at least 4 spaces, found 1; (#30) Spaces must be used to indent lines; tabs are not allowed; (#30) Tab found within whitespace; (#30) Line indented incorrectly; expected at least 4 spaces, found 1; (#30) Expected 1 space before "=>"; 0 found; (#30) Expected 1 space after "=>"; 0 found; (#33) Spaces must be used to indent lines; tabs are not allowed; (#33) Tab found within whitespace; (#33) Line indented incorrectly; expected 4 spaces, found 1; (#33) Expected "do {\n...} while (...);\n"; found "do{\n...} while(...);\n"; (#34) Spaces must be used to indent lines; tabs are not allowed; (#34) Tab found within whitespace; (#34) Line indented incorrectly; expected at least 8 spaces, found 2; (#35) Spaces must be used to indent lines; tabs are not allowed; (#35) Tab found within whitespace; (#35) Line indented incorrectly; expected at least 8 spaces, found 2; (#36) Spaces must be used to indent lines; tabs are not allowed; (#36) Tab found within whitespace; (#36) Line indented incorrectly; expected 4 spaces, found 1; (#38) Spaces must be used to indent lines; tabs are not allowed; (#38) Tab found within whitespace; (#38) Line indented incorrectly; expected at least 4 spaces, found 1
auth/a2fa/login.php: (#2) The opening <?php tag must be followed by exactly one newline.; (#27) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.; (#38) Inline comments must start with a capital letter, digit or 3-dots sequence; (#39) Inline comments must end in full-stops, exclamation marks, or question marks; (#45) Inline comments must end in full-stops, exclamation marks, or question marks; (#45) No space found before comment text; expected "// HTTPS is required in this page when $CFG->loginhttps enabled" but found "//HTTPS is required in this page when $CFG->loginhttps enabled"; (#53) Inline comments must end in full-stops, exclamation marks, or question marks; (#53) 3 slashes comments are not allowed; use "// Comment." instead; (#57) Inline comments must start with a capital letter, digit or 3-dots sequence; (#57) Inline comments must end in full-stops, exclamation marks, or question marks; (#68) Inline comments must end in full-stops, exclamation marks, or question marks; (#74) Inline comments must end in full-stops, exclamation marks, or question marks; (#74) 3 slashes comments are not allowed; use "// Comment." instead; (#76) Variable "session_has_timed_out" must not contain underscores.; (#79) Variable "session_has_timed_out" must not contain underscores.; (#82) Inline comments must start with a capital letter, digit or 3-dots sequence; (#82) 3 slashes comments are not allowed; use "// Comment." instead; (#86) Inline comments must start with a capital letter, digit or 3-dots sequence; (#86) Inline comments must end in full-stops, exclamation marks, or question marks; (#87) Expected "foreach (...) {\n"; found "foreach(...) {\n"; (#93) Inline comments must end in full-stops, exclamation marks, or question marks; (#93) 3 slashes comments are not allowed; use "// Comment." instead; (#99) Empty IF statement detected; (#100) Inline comments must start with a capital letter, digit or 3-dots sequence; (#100) Inline comments must end in full-stops, exclamation marks, or question marks; (#104) Inline comments must end in full-stops, exclamation marks, or question marks; (#104) No space found before comment text; expected "// TODO: move weblink into own auth plugin" but found "//TODO: move weblink into own auth plugin"; (#119) Inline comments must end in full-stops, exclamation marks, or question marks; (#119) 3 slashes comments are not allowed; use "// Comment." instead; (#121) Inline comments must end in full-stops, exclamation marks, or question marks; (#133) Empty IF statement detected; (#134) Inline comments must start with a capital letter, digit or 3-dots sequence; (#134) Inline comments must end in full-stops, exclamation marks, or question marks; (#134) No space found before comment text; expected "// user already supplied by aut plugin prelogin hook" but found "//user already supplied by aut plugin prelogin hook"; (#136) Inline comments must end in full-stops, exclamation marks, or question marks; (#136) 3 slashes comments are not allowed; use "// Comment." instead; (#144) Inline comments must end in full-stops, exclamation marks, or question marks; (#151) Inline comments must end in full-stops, exclamation marks, or question marks; (#160) Inline comments must start with a capital letter, digit or 3-dots sequence; (#160) Inline comments must end in full-stops, exclamation marks, or question marks; (#162) Inline comments must start with a capital letter, digit or 3-dots sequence; (#162) Inline comments must end in full-stops, exclamation marks, or question marks; (#166) Inline comments must start with a capital letter, digit or 3-dots sequence; (#166) Inline comments must end in full-stops, exclamation marks, or question marks; (#170) Inline comments must end in full-stops, exclamation marks, or question marks; (#180) Line indented incorrectly; expected at least 8 spaces, found 4; (#180) 3 slashes comments are not allowed; use "// Comment." instead; (#183) Inline comments must start with a capital letter, digit or 3-dots sequence; (#183) Inline comments must end in full-stops, exclamation marks, or question marks; (#184) Empty IF statement detected; (#185) Inline comments must start with a capital letter, digit or 3-dots sequence; (#190) Inline comments must start with a capital letter, digit or 3-dots sequence; (#190) Inline comments must end in full-stops, exclamation marks, or question marks; (#199) Inline comments must start with a capital letter, digit or 3-dots sequence; (#199) Line indented incorrectly; expected at least 8 spaces, found 4; (#199) 3 slashes comments are not allowed; use "// Comment." instead; (#200) Inline comments must end in full-stops, exclamation marks, or question marks; (#200) Line indented incorrectly; expected at least 8 spaces, found 4; (#200) 3 slashes comments are not allowed; use "// Comment." instead; (#219) Usage of ELSEIF not allowed; use ELSE IF instead; (#230) Inline comments must start with a capital letter, digit or 3-dots sequence; (#230) Inline comments must end in full-stops, exclamation marks, or question marks; (#232) Expected 1 space before "=>"; 0 found; (#232) Expected 1 space after "=>"; 0 found; (#242) Inline comments must end in full-stops, exclamation marks, or question marks; (#242) 3 slashes comments are not allowed; use "// Comment." instead; (#243) Variable "session_has_timed_out" must not contain underscores.; (#248) Inline comments must end in full-stops, exclamation marks, or question marks; (#248) 3 slashes comments are not allowed; use "// Comment." instead; (#251) Commas (,) must be followed by white space.; (#256) Line exceeds 132 characters; contains 160 characters; (#257) Expected 1 space before "?"; newline found; (#257) TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"; (#260) This comment is 43% valid code; is this commented out code?; (#261) 3 slashes comments are not allowed; use "// Comment." instead; (#283) Inline comments must start with a capital letter, digit or 3-dots sequence; (#283) Inline comments must end in full-stops, exclamation marks, or question marks; (#286) Inline comments must end in full-stops, exclamation marks, or question marks; (#286) 3 slashes comments are not allowed; use "// Comment." instead; (#292) Inline comments must end in full-stops, exclamation marks, or question marks; (#294) Inline comments must start with a capital letter, digit or 3-dots sequence; (#294) Inline comments must end in full-stops, exclamation marks, or question marks; (#309) Variable "show_instructions" must not contain underscores.; (#311) Variable "show_instructions" must not contain underscores.; (#315) Expected "foreach (...) {\n"; found "foreach(...) {\n"; (#343) Inline comments must start with a capital letter, digit or 3-dots sequence; (#343) Inline comments must end in full-stops, exclamation marks, or question marks; (#345) Expected 1 space before "=>"; 0 found; (#345) Expected 1 space after "=>"; 0 found; (#345) Commas (,) must be followed by white space.; (#345) Expected 1 space before "=>"; 0 found; (#345) Expected 1 space after "=>"; 0 found; (#345) Line exceeds 132 characters; contains 162 characters; (#346) Expected 1 space before "=>"; 0 found; (#346) Expected 1 space after "=>"; 0 found; (#346) Line exceeds 132 characters; contains 142 characters; (#354) Inline comments must start with a capital letter, digit or 3-dots sequence; (#354) Inline comments must end in full-stops, exclamation marks, or question marks; (#354) No space found before comment text; expected "// focus username or password" but found "//focus username or password"
auth/a2fa/version.php: (#29) Inline comments must end in full-stops, exclamation marks, or question marks

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by jshint [More info]

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by csslint [More info]

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]

Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]

Prechecker results: error

PHP lint problems

PHP coding style problems

Javascript coding style problems

CSS problems

PHPDocs style problems

Update savepoints problems

Third party library modification problems

Mustache template problems