Moodle plugins directory: Sketch

Comments

• 

  Thomas LE MONS

  Fri, Sep 1, 2017, 5:55 PM

  Hello Matthew,
  I would like to use Sketch for a maths test. Nevertheless, the image created with sktech in a "comment question" (Test Plugin") appears in the preview BUT NOT in the final answer that has to be noted by the teacher.
  Do you have a solution? Is it an editor problem?
• 

  Matthew Davidson

  Fri, Sep 1, 2017, 8:11 PM

  @Thomas Le MONS @Enrique Castro Ok, so I now understand what is going on. Moodle uses a code cleaner called HTMLPurify in places where students can also enter data. (glossary, forums, quiz questions, etc). Part of the code cleanup is removing the data:image/png:base64 string that this plugin uses. The fix is very easy, but requires a core change. See https://tracker.moodle.org/browse/MDL-59997 In the workaround section it will have 2 ways around this issue. Hint, don't use the first workaround. I am working on getting this fixed in Moodle as soon as possible.
• 

  Enrique Castro

  Fri, Sep 1, 2017, 11:51 PM

  Hi Matthew, I'n sorry I was NOT clearer in my first message. Yes, the problem is the cleaning by the function format_text().
  But that cleaning is there for a reason. Input from students, even form teachers, MUST be cleaned. People tend to copy-paste any type of things. We have had some incidents with teachers inadvertently pasting hidden malicious scripts, or just inconvenient advertisements.
  A much better way to deal with the issue would be to store the image file in the editor draft filearea. But it's a significant more work, I understand.
  
  
• 

  Matthew Davidson

  Fri, Sep 1, 2017, 11:55 PM

  @Enrique Castro Thanks again for the feedback. I have been looking into ways to do what you are requesting. However with the change I've submitted in MDL-59997, it would be strictly allowing only 3 mime types. I've search all over about security issues with Data URI and the only issues I've seen are with text mime types. So I've submitted it to Moodle with "possible" security questions, to see what they think.
• 

  Rob Johnson

  Tue, Sep 5, 2017, 4:55 AM

  Hi Matthew,
  I have not altered the setup in any way. I was using Firefox as my browser.
• 

  Matthew Davidson

  Wed, Sep 6, 2017, 3:52 AM

  @Rob Johnson I am running Moodle 3.3 with Adaptable 1.5, running Firefox. Still unable to recreate the issue. Please install the latest version of the plugin and let me know if it is still not working for you.
• 

  Matthew Davidson

  Tue, Sep 12, 2017, 9:28 PM

  @Enrique Castro Both the tinymce and atto version of sketch now support uploading into the Moodle repo as normal Moodle images. Please test it out and see if it does what you hope. Latest version just released today. Version 2017090800
• 

  Irith Herman

  Mon, Feb 12, 2018, 7:21 PM

  Is there any way to add more features to the sketch like magic wand?
  
• 

  Matthew Davidson

  Mon, Feb 12, 2018, 9:21 PM

  @Irith Herman Yes, there is a way to add additional features. http://literallycanvas.com/api/tools.html However I'm not sure how difficult a magic wand would be. I will look into it and see what would be involved. Thanks for the comment.
• 

  Irith Herman

  Tue, Feb 13, 2018, 3:43 PM

  Thank you Mattew . I"m waiting for youranswer.
• 

  Florian Krause

  Mon, Mar 5, 2018, 10:52 PM

  super! für smartphones und tabletts einfach der hit! hat kurz gedauert, bis ich kapiert hatte, dass man das icon bei den einstellungen vom editor noch hinzufügen muss (-: und im css vom template habe ich die höhe auf 95% gesetzt, sonst war auf dem ipad der button zum bestätigen außerhalb der anzeige ... jetzt hab ich viel spaß mit dem touchpen. eine nutzerin hat mir sogar gesagt, dass sie jetzt moodle nutzt, um ihre zeichnungen als bild zu speichern ...
• 

  Michal Wazana

  Tue, Mar 13, 2018, 6:05 PM

  nice,
  it would be even better if you will be able to edit shapes and text (fixing, moving, resizing..) after placing them..
  
• 

  j s

  Thu, Jul 5, 2018, 12:30 AM

  Hi not sure if it's here that i should ask or comment. Is it possible for to shift the "Insert Image" button that is currently at the bottom of the page to the top or to the side bar? Was using it on the phone and on a another small screen and everything works, but could not insert the image because the button was inaccessible. Possible? Any help?
• 

  Marc Mathys

  Wed, Oct 31, 2018, 11:46 PM

  
  I cannot see the controls once the frame opens and seem to be getting these errors and I am not sure how to fix. Thanks
  
  [Error] Refused to display 'https://set.online.uni-marburg.de/elearning/lib/editor/atto/plugins/sketch/sketch.html' in a frame because it set 'X-Frame-Options' to 'DENY'.
  [Error] Sandbox access violation: Blocked a frame at "https://set.online.uni-marburg.de" from accessing a frame at "null". The frame being accessed is sandboxed and lacks the "allow-same-origin" flag.
  (anonymous function) (yui_combo.php:9:4291)
  [Error] TypeError: null is not an object (evaluating 'document.getElementById(o).contentDocument.getElementsByClassName')
  (anonymous function) (yui_combo.php:9:4307)
  
• 

  sanaz karimkhani

  Tue, Oct 22, 2019, 7:07 PM

  Hi,
  
  i have instaled Plugins but unfortunatly it doesn't appear Icon of skatch. I Set cursor in the editor but there is not the sketch icon.
  can you please help me