Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(43 errors, 62 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

lib/editor/atto/plugins/poodll/dialog/poodll.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#48) Inline comments must start with a capital letter, digit or 3-dots sequence
(#48) Inline comments must end in full-stops, exclamation marks, or question marks
(#48) This comment is 64% valid code; is this commented out code?
(#48) No space found before comment text; expected "// $plugin = $editor->get_plugin('poodll');" but found "//$plugin = $editor->get_plugin('poodll');"
(#57) Inline comments must start with a capital letter, digit or 3-dots sequence
(#57) Inline comments must end in full-stops, exclamation marks, or question marks
(#57) No space found before comment text; expected "// contextid" but found "//contextid"
(#59) Inline comments must start with a capital letter, digit or 3-dots sequence
(#59) Inline comments must end in full-stops, exclamation marks, or question marks
(#59) This comment is 100% valid code; is this commented out code?
(#59) No space found before comment text; expected "// 'atto_poodll_button.updatefilename';" but found "//'atto_poodll_button.updatefilename';"
(#105) This comment is 48% valid code; is this commented out code?
(#105) Inline comments must start with a capital letter, digit or 3-dots sequence
(#105) No space found before comment text; expected "// load our resize script" but found "//load our resize script"
(#106) No space found before comment text; expected "// lets disable this ...JUSTIN 20170826" but found "//lets disable this ...JUSTIN 20170826"
(#107) Inline comments must end in full-stops, exclamation marks, or question marks
(#107) No space found before comment text; expected "// $PAGE->requires->js_call_amd("filter_poodll/responsiveiframe", 'init', array(array('iframeid' => $iframeid)));" but found "//$PAGE->requires->js_call_amd("filter_poodll/responsiveiframe", 'init', array(array('iframeid' => $iframeid)));"
lib/editor/atto/plugins/poodll/lib.php
(#57) Inline comments must start with a capital letter, digit or 3-dots sequence
(#57) Inline comments must end in full-stops, exclamation marks, or question marks
(#57) No space found before comment text; expected "// the context" but found "//the context"
(#60) Inline comments must start with a capital letter, digit or 3-dots sequence
(#60) Inline comments must end in full-stops, exclamation marks, or question marks
(#60) No space found before comment text; expected "// coursecontext" but found "//coursecontext"
(#63) Inline comments must start with a capital letter, digit or 3-dots sequence
(#63) Inline comments must end in full-stops, exclamation marks, or question marks
(#63) No space found before comment text; expected "// usercontextid" but found "//usercontextid"
(#71) Inline comments must start with a capital letter, digit or 3-dots sequence
(#71) Inline comments must end in full-stops, exclamation marks, or question marks
(#71) No space found before comment text; expected "// config our array of data" but found "//config our array of data"
(#76) Inline comments must end in full-stops, exclamation marks, or question marks
(#76) No space found before comment text; expected "// If they don't have permission don't show it" but found "//If they don't have permission don't show it"
(#81) Inline comments must start with a capital letter, digit or 3-dots sequence
(#81) Inline comments must end in full-stops, exclamation marks, or question marks
(#81) No space found before comment text; expected "// if this textarea allows no files, we also bail" but found "//if this textarea allows no files, we also bail"
(#86) Inline comments must start with a capital letter, digit or 3-dots sequence
(#86) Inline comments must end in full-stops, exclamation marks, or question marks
(#86) No space found before comment text; expected "// add our disabled param" but found "//add our disabled param"
(#89) Inline comments must start with a capital letter, digit or 3-dots sequence
(#89) Inline comments must end in full-stops, exclamation marks, or question marks
(#89) No space found before comment text; expected "// add our use whiteboard option" but found "//add our use whiteboard option"
(#92) Inline comments must start with a capital letter, digit or 3-dots sequence
(#92) Inline comments must end in full-stops, exclamation marks, or question marks
(#92) No space found before comment text; expected "// add icons to editor if the permissions are all ok" but found "//add icons to editor if the permissions are all ok"
(#97) Inline comments must start with a capital letter, digit or 3-dots sequence
(#97) Inline comments must end in full-stops, exclamation marks, or question marks
(#97) No space found before comment text; expected "// we deleted the red5 option, just in case, we map it here to mp3" but found "//we deleted the red5 option, just in case, we map it here to mp3"
(#128) Inline comments must start with a capital letter, digit or 3-dots sequence
(#128) Inline comments must end in full-stops, exclamation marks, or question marks
(#128) No space found before comment text; expected "// generico specific" but found "//generico specific"
(#138) Inline comments must start with a capital letter, digit or 3-dots sequence
(#138) Inline comments must end in full-stops, exclamation marks, or question marks
(#138) No space found before comment text; expected "// get the no. of templates" but found "//get the no. of templates"
(#144) Inline comments must start with a capital letter, digit or 3-dots sequence
(#144) Inline comments must end in full-stops, exclamation marks, or question marks
(#144) No space found before comment text; expected "// put our template into a form thats easy to process in JS" but found "//put our template into a form thats easy to process in JS"
(#153) Inline comments must start with a capital letter, digit or 3-dots sequence
(#153) Inline comments must end in full-stops, exclamation marks, or question marks
(#153) No space found before comment text; expected "// make sure its to be shown in atto" but found "//make sure its to be shown in atto"
(#158) Inline comments must start with a capital letter, digit or 3-dots sequence
(#158) Inline comments must end in full-stops, exclamation marks, or question marks
(#158) No space found before comment text; expected "// stash the key and name for this template" but found "//stash the key and name for this template"
(#167) Inline comments must start with a capital letter, digit or 3-dots sequence
(#167) No space found before comment text; expected "// instructions" but found "//instructions"
(#168) Inline comments must end in full-stops, exclamation marks, or question marks
(#168) No space found before comment text; expected "// stash the instructions for this template" but found "//stash the instructions for this template"
(#171) No space found before comment text; expected "// NB each of the $allvariables contains an array of variables (not a string)" but found "//NB each of the $allvariables contains an array of variables (not a string)"
(#172) No space found before comment text; expected "// there might be duplicates where the variable is used multiple times in a template" but found "//there might be duplicates where the variable is used multiple times in a template"
(#173) Inline comments must end in full-stops, exclamation marks, or question marks
(#173) No space found before comment text; expected "// se we uniqu'ify it. That makes it look complicated. But we are just removing doubles" but found "//se we uniqu'ify it. That makes it look complicated. But we are just removing doubles"
(#179) Inline comments must start with a capital letter, digit or 3-dots sequence
(#179) No space found before comment text; expected "// we need to reallocate array keys if the array size was changed in unique'ifying it" but found "//we need to reallocate array keys if the array size was changed in unique'ifying it"
(#180) No space found before comment text; expected "// we also take the opportunity to remove user variables, since they aren't needed here." but found "//we also take the opportunity to remove user variables, since they aren't needed here."
(#181) Inline comments must end in full-stops, exclamation marks, or question marks
(#181) No space found before comment text; expected "// NB DATASET can be referred to without the :" but found "//NB DATASET can be referred to without the :"
(#197) Inline comments must start with a capital letter, digit or 3-dots sequence
(#197) No space found before comment text; expected "// stash the defaults for this template" but found "//stash the defaults for this template"
(#198) Inline comments must end in full-stops, exclamation marks, or question marks
(#198) This comment is 60% valid code; is this commented out code?
(#198) No space found before comment text; expected "// $defaults[] = $templates['templatedefaults_' . $tempindex];" but found "//$defaults[] = $templates['templatedefaults_' . $tempindex];"
(#204) Inline comments must start with a capital letter, digit or 3-dots sequence
(#204) Inline comments must end in full-stops, exclamation marks, or question marks
(#204) No space found before comment text; expected "// config our array of data" but found "//config our array of data"
(#233) No space found before comment text; expected "// Now we just have our properties string" but found "//Now we just have our properties string"
(#234) No space found before comment text; expected "// Lets run our regular expression over them" but found "//Lets run our regular expression over them"
(#235) No space found before comment text; expected "// string should be property=value,property=value" but found "//string should be property=value,property=value"
(#236) Inline comments must end in full-stops, exclamation marks, or question marks
(#236) No space found before comment text; expected "// got this regexp from http://stackoverflow.com/questions/168171/regular-expression-for-parsing-name-value-pairs" but found "//got this regexp from http://stackoverflow.com/questions/168171/regular-expression-for-parsing-name-value-pairs"
(#240) Inline comments must start with a capital letter, digit or 3-dots sequence
(#240) No space found before comment text; expected "// here we match the filter string and split into name array (matches[1]) and value array (matches[2])" but found "//here we match the filter string and split into name array (matches[1]) and value array (matches[2])"
(#241) No space found before comment text; expected "// we then add those to a name value array." but found "//we then add those to a name value array."
(#246) Inline comments must start with a capital letter, digit or 3-dots sequence
(#246) Inline comments must end in full-stops, exclamation marks, or question marks
(#246) This comment is 63% valid code; is this commented out code?
(#248) Inline comments must start with a capital letter, digit or 3-dots sequence
(#248) No space found before comment text; expected "// this could be done better, I am sure. WE are removing the quotes from start and end" but found "//this could be done better, I am sure. WE are removing the quotes from start and end"
(#249) Inline comments must end in full-stops, exclamation marks, or question marks
(#249) No space found before comment text; expected "// this wil however remove multiple quotes id they exist at start and end. NG really" but found "//this wil however remove multiple quotes id they exist at start and end. NG really"
lib/editor/atto/plugins/poodll/settings.php
(#33) Inline comments must end in full-stops, exclamation marks, or question marks
(#46) Inline comments must end in full-stops, exclamation marks, or question marks
(#46) No space found before comment text; expected "// PoodLL Whiteboard" but found "//PoodLL Whiteboard"
lib/editor/atto/plugins/poodll/version.php
(#28) This comment is 50% valid code; is this commented out code?
(#28) Inline comments must start with a capital letter, digit or 3-dots sequence
(#28) No space found before comment text; expected "// moodle 3.1.0" but found "//moodle 3.1.0"
(#31) Inline comments must end in full-stops, exclamation marks, or question marks

Javascript coding style problems

(2 errors, 144 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

lib/editor/atto/plugins/poodll/yui/src/button/js/button.js
(#76) Line 76 exceeds the maximum line length of 132. (max-len)
(#122) Unexpected space before function parentheses. (space-before-function-paren)
(#140) Expected space or tab after '//' in comment. (spaced-comment)
(#140) Comments should not begin with a lowercase character (capitalized-comments)
(#164) Missing JSDoc for parameter 'therecorder'. (valid-jsdoc)
(#164) Missing JSDoc for parameter 'e'. (valid-jsdoc)
(#170) Unexpected space before function parentheses. (space-before-function-paren)
(#197) Expected space or tab after '//' in comment. (spaced-comment)
(#197) Comments should not begin with a lowercase character (capitalized-comments)
(#208) Comments should not begin with a lowercase character (capitalized-comments)
(#208) Expected space or tab after '//' in comment. (spaced-comment)
(#217) Comments should not begin with a lowercase character (capitalized-comments)
(#217) Expected space or tab after '//' in comment. (spaced-comment)
(#221) Comments should not begin with a lowercase character (capitalized-comments)
(#221) Expected space or tab after '//' in comment. (spaced-comment)
(#227) Comments should not begin with a lowercase character (capitalized-comments)
(#227) Expected space or tab after '//' in comment. (spaced-comment)
(#233) Expected JSDoc for 'therecorder' but found '_getIframeURL'. (valid-jsdoc)
(#233) Missing JSDoc parameter type for '_getIframeURL'. (valid-jsdoc)
(#233) Missing JSDoc for parameter 'iframeid'. (valid-jsdoc)
(#240) Unexpected space before function parentheses. (space-before-function-paren)
(#255) Unexpected space before function parentheses. (space-before-function-paren)
(#277) Unexpected space before function parentheses. (space-before-function-paren)
(#282) Missing JSDoc for parameter 'e'. (valid-jsdoc)
(#287) Unexpected space before function parentheses. (space-before-function-paren)
(#294) Expected space or tab after '//' in comment. (spaced-comment)
(#294) Comments should not begin with a lowercase character (capitalized-comments)
(#300) 'thefilename' is already defined. (no-redeclare)
(#307) Expected space or tab after '//' in comment. (spaced-comment)
(#307) Comments should not begin with a lowercase character (capitalized-comments)
(#314) Expected space or tab after '//' in comment. (spaced-comment)
(#314) Comments should not begin with a lowercase character (capitalized-comments)
(#325) Missing JSDoc for parameter 'args'. (valid-jsdoc)
(#330) Unexpected space before function parentheses. (space-before-function-paren)
(#331) Comments should not begin with a lowercase character (capitalized-comments)
(#331) Expected space or tab after '//' in comment. (spaced-comment)
(#332) Expected space or tab after '//' in comment. (spaced-comment)
(#339) Comments should not begin with a lowercase character (capitalized-comments)
(#339) Expected space or tab after '//' in comment. (spaced-comment)
(#341) Expected space or tab after '//' in comment. (spaced-comment)
(#341) Comments should not begin with a lowercase character (capitalized-comments)
(#344) Comments should not begin with a lowercase character (capitalized-comments)
(#344) Expected space or tab after '//' in comment. (spaced-comment)
(#348) Missing JSDoc for parameter 'e'. (valid-jsdoc)
(#348) Missing JSDoc for parameter 'clickedicon'. (valid-jsdoc)
(#354) Unexpected space before function parentheses. (space-before-function-paren)
(#364) Expected space or tab after '//' in comment. (spaced-comment)
(#364) Comments should not begin with a lowercase character (capitalized-comments)
(#365) Expected space or tab after '//' in comment. (spaced-comment)
(#370) Expected space or tab after '//' in comment. (spaced-comment)
(#370) Comments should not begin with a lowercase character (capitalized-comments)
(#373) Expected space or tab after '//' in comment. (spaced-comment)
(#373) Comments should not begin with a lowercase character (capitalized-comments)
(#380) Expected space or tab after '//' in comment. (spaced-comment)
(#380) Comments should not begin with a lowercase character (capitalized-comments)
(#384) Unexpected space before function parentheses. (space-before-function-paren)
(#385) Comments should not begin with a lowercase character (capitalized-comments)
(#385) Expected space or tab after '//' in comment. (spaced-comment)
(#387) Expected space or tab after '//' in comment. (spaced-comment)
(#387) Comments should not begin with a lowercase character (capitalized-comments)
(#391) Comments should not begin with a lowercase character (capitalized-comments)
(#391) Expected space or tab after '//' in comment. (spaced-comment)
(#397) Missing JSDoc for parameter 'e'. (valid-jsdoc)
(#397) Missing JSDoc for parameter 'templateindex'. (valid-jsdoc)
(#403) Unexpected space before function parentheses. (space-before-function-paren)
(#412) Comments should not begin with a lowercase character (capitalized-comments)
(#412) Expected space or tab after '//' in comment. (spaced-comment)
(#413) Expected space or tab after '//' in comment. (spaced-comment)
(#418) Expected space or tab after '//' in comment. (spaced-comment)
(#418) Comments should not begin with a lowercase character (capitalized-comments)
(#423) Expected space or tab after '//' in comment. (spaced-comment)
(#423) Comments should not begin with a lowercase character (capitalized-comments)
(#425) 'useheadertext' used outside of binding context. (block-scoped-var)
(#427) 'useheadertext' used outside of binding context. (block-scoped-var)
(#427) 'useheadertext' is already defined. (no-redeclare)
(#432) 'useheadertext' used outside of binding context. (block-scoped-var)
(#432) 'useheadertext' used outside of binding context. (block-scoped-var)
(#437) Expected space or tab after '//' in comment. (spaced-comment)
(#437) Comments should not begin with a lowercase character (capitalized-comments)
(#440) Expected space or tab after '//' in comment. (spaced-comment)
(#440) Comments should not begin with a lowercase character (capitalized-comments)
(#443) Comments should not begin with a lowercase character (capitalized-comments)
(#443) Expected space or tab after '//' in comment. (spaced-comment)
(#444) Unexpected space before function parentheses. (space-before-function-paren)
(#445) Expected space or tab after '//' in comment. (spaced-comment)
(#445) Comments should not begin with a lowercase character (capitalized-comments)
(#447) Comments should not begin with a lowercase character (capitalized-comments)
(#447) Expected space or tab after '//' in comment. (spaced-comment)
(#450) Comments should not begin with a lowercase character (capitalized-comments)
(#450) Expected space or tab after '//' in comment. (spaced-comment)
(#452) Missing semicolon. (semi)
(#454) Expected space or tab after '//' in comment. (spaced-comment)
(#454) Comments should not begin with a lowercase character (capitalized-comments)
(#460) Missing JSDoc for parameter 'templateindex'. (valid-jsdoc)
(#468) Unexpected space before function parentheses. (space-before-function-paren)
(#482) Missing JSDoc for parameter 'templateindex'. (valid-jsdoc)
(#489) Unexpected space before function parentheses. (space-before-function-paren)
(#496) Comments should not begin with a lowercase character (capitalized-comments)
(#496) Expected space or tab after '//' in comment. (spaced-comment)
(#497) Expected space or tab after '//' in comment. (spaced-comment)
(#500) Unexpected space before function parentheses. (space-before-function-paren)
(#501) Expected space or tab after '//' in comment. (spaced-comment)
(#501) Comments should not begin with a lowercase character (capitalized-comments)
(#505) 'content' used outside of binding context. (block-scoped-var)
(#522) Unexpected space before function parentheses. (space-before-function-paren)
(#528) 'content' used outside of binding context. (block-scoped-var)
(#533) 'content' is already defined. (no-redeclare)
(#533) 'content' used outside of binding context. (block-scoped-var)
(#542) 'content' used outside of binding context. (block-scoped-var)
(#542) 'content' used outside of binding context. (block-scoped-var)
(#543) Expected space or tab after '//' in comment. (spaced-comment)
(#543) Comments should not begin with a lowercase character (capitalized-comments)
(#551) Missing JSDoc for parameter 'clickedicon'. (valid-jsdoc)
(#559) Unexpected space before function parentheses. (space-before-function-paren)
(#562) Unexpected space before function parentheses. (space-before-function-paren)
(#563) Expected space or tab after '//' in comment. (spaced-comment)
(#563) Comments should not begin with a lowercase character (capitalized-comments)
(#573) Comments should not begin with a lowercase character (capitalized-comments)
(#573) Expected space or tab after '//' in comment. (spaced-comment)
(#579) Unexpected space before function parentheses. (space-before-function-paren)
(#580) Expected space or tab after '//' in comment. (spaced-comment)
(#580) Comments should not begin with a lowercase character (capitalized-comments)
(#582) Expected space or tab after '//' in comment. (spaced-comment)
(#582) Comments should not begin with a lowercase character (capitalized-comments)
(#583) Unexpected space before function parentheses. (space-before-function-paren)
(#584) Comments should not begin with a lowercase character (capitalized-comments)
(#584) Expected space or tab after '//' in comment. (spaced-comment)
(#589) Comments should not begin with a lowercase character (capitalized-comments)
(#589) Expected space or tab after '//' in comment. (spaced-comment)
(#595) Missing JSDoc for parameter 'e'. (valid-jsdoc)
(#595) Missing JSDoc for parameter 'templateindex'. (valid-jsdoc)
(#600) Unexpected space before function parentheses. (space-before-function-paren)
(#613) Comments should not begin with a lowercase character (capitalized-comments)
(#613) Expected space or tab after '//' in comment. (spaced-comment)
(#616) Comments should not begin with a lowercase character (capitalized-comments)
(#616) Expected space or tab after '//' in comment. (spaced-comment)
(#617) Unexpected space before function parentheses. (space-before-function-paren)
(#618) Expected space or tab after '//' in comment. (spaced-comment)
(#618) Comments should not begin with a lowercase character (capitalized-comments)
(#624) Expected space or tab after '//' in comment. (spaced-comment)
(#624) Comments should not begin with a lowercase character (capitalized-comments)
(#627) Expected space or tab after '//' in comment. (spaced-comment)
(#627) Comments should not begin with a lowercase character (capitalized-comments)
(#630) Expected space or tab after '//' in comment. (spaced-comment)
(#630) Comments should not begin with a lowercase character (capitalized-comments)
(#658) Bad line breaking before and after ','. (comma-style)

CSS problems

(21 errors, 8 warnings)

This section shows CSS problems detected by stylelint [More info]

lib/editor/atto/plugins/poodll/dialog/poodll.css
(#58) Invalid value for `padding` (csstree/validator)
(#36) Unexpected unit (length-zero-no-unit)
(#40) Unexpected unit (length-zero-no-unit)
(#41) Unexpected unit (length-zero-no-unit)
(#45) Unexpected unit (length-zero-no-unit)
(#46) Unexpected unit (length-zero-no-unit)
(#47) Unexpected unit (length-zero-no-unit)
(#52) Unexpected unit (length-zero-no-unit)
(#53) Unexpected unit (length-zero-no-unit)
(#1) Expected newline after "," (selector-list-comma-newline-after)
(#1) Expected newline after "," (selector-list-comma-newline-after)
(#13) Expected newline after "," (selector-list-comma-newline-after)
(#13) Expected newline after "," (selector-list-comma-newline-after)
(#17) Expected newline after "," (selector-list-comma-newline-after)
(#21) Expected newline after "," (selector-list-comma-newline-after)
(#21) Expected newline after "," (selector-list-comma-newline-after)
(#21) Expected newline after "," (selector-list-comma-newline-after)
(#27) Expected newline after "," (selector-list-comma-newline-after)
(#27) Expected newline after "," (selector-list-comma-newline-after)
(#27) Expected newline after "," (selector-list-comma-newline-after)
(#27) Expected newline after "," (selector-list-comma-newline-after)
(#27) Expected newline after "," (selector-list-comma-newline-after)
(#27) Expected newline after "," (selector-list-comma-newline-after)
(#27) Expected newline after "," (selector-list-comma-newline-after)
(#27) Expected newline after "," (selector-list-comma-newline-after)
(#27) Expected newline after "," (selector-list-comma-newline-after)
(#27) Expected newline after "," (selector-list-comma-newline-after)
(#27) Expected newline after "," (selector-list-comma-newline-after)
(#27) Expected newline after "," (selector-list-comma-newline-after)

PHPDocs style problems

(6 errors, 1 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

lib/editor/atto/plugins/poodll/dialog/poodll.php
(#2) Empty line found after PHP open tag
(#34) File-level phpdocs block is not found
(#26) Package poodll is not valid
lib/editor/atto/plugins/poodll/lib.php
(#232) Function atto_poodll_widgets_fetch_filter_properties is not documented
(#30) Phpdocs for function atto_poodll_strings_for_js has incomplete parameters list
(#49) Phpdocs for function atto_poodll_params_for_js has incomplete parameters list
(#219) Phpdocs for function atto_poodll_widgets_fetch_variables has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]