Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(21 errors, 26 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

lib/editor/atto/plugins/edusharing/classes/privacy/provider.php
(#43) There must not be a space before the colon in a return type declaration
lib/editor/atto/plugins/edusharing/delete.php
(#27) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
lib/editor/atto/plugins/edusharing/fetch.php
(#25) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
lib/editor/atto/plugins/edusharing/lang/de/atto_edusharing.php
(#27) The string key "dialogtitle" is not in the correct order, it should be before "pluginname"
(#29) The string key "customHint" is not in the correct order, it should be before "hint1"
(#31) Variable "$exception" is not expected in a lang file
(#32) The string key "pluginname" is duplicated
(#33) The string key "dialogtitle" is duplicated
(#34) The string key "hint1" is duplicated
(#35) The string key "customHint" is duplicated
(#36) The string key "privacy:metadata" is duplicated
(#37) Variable "$exception" is not expected in a lang file
(#41) The string key "insert" is not in the correct order, it should be before "settings"
(#43) The string key "cancel" is not in the correct order, it should be before "update"
(#45) The string key "subtitle" is not in the correct order, it should be before "title"
(#46) The string key "alwaysShowLatestVersion" is not in the correct order, it should be before "subtitle"
(#47) The string key "alignment" is not in the correct order, it should be before "alwaysShowLatestVersion"
(#50) The string key "alignmentNone" is not in the correct order, it should be before "alignmentRight"
(#55) The string key "hint2" is not in the correct order, it should be before "openRepo"
(#57) The string key "directoryHint" is not in the correct order, it should be before "skipHint"
(#60) The string key "error_resource_not_found" is not in the correct order, it should be before "nonVersionableHint"
(#61) The string key "error_deleting_instance" is not in the correct order, it should be before "error_resource_not_found"
(#62) The string key "error_deleting_capability" is not in the correct order, it should be before "error_deleting_instance"
lib/editor/atto/plugins/edusharing/lang/en/atto_edusharing.php
(#27) The string key "dialogtitle" is not in the correct order, it should be before "pluginname"
(#29) The string key "customHint" is not in the correct order, it should be before "hint1"
(#31) Variable "$exception" is not expected in a lang file
(#32) The string key "pluginname" is duplicated
(#33) The string key "dialogtitle" is duplicated
(#34) The string key "hint1" is duplicated
(#35) The string key "customHint" is duplicated
(#36) The string key "privacy:metadata" is duplicated
(#37) Variable "$exception" is not expected in a lang file
(#41) The string key "insert" is not in the correct order, it should be before "settings"
(#43) The string key "cancel" is not in the correct order, it should be before "update"
(#45) The string key "subtitle" is not in the correct order, it should be before "title"
(#46) The string key "alwaysShowLatestVersion" is not in the correct order, it should be before "subtitle"
(#47) The string key "alignment" is not in the correct order, it should be before "alwaysShowLatestVersion"
(#50) The string key "alignmentNone" is not in the correct order, it should be before "alignmentRight"
(#55) The string key "hint2" is not in the correct order, it should be before "openRepo"
(#57) The string key "directoryHint" is not in the correct order, it should be before "skipHint"
(#60) The string key "error_resource_not_found" is not in the correct order, it should be before "nonVersionableHint"
(#61) The string key "error_deleting_instance" is not in the correct order, it should be before "error_resource_not_found"
(#62) The string key "error_deleting_capability" is not in the correct order, it should be before "error_deleting_instance"
lib/editor/atto/plugins/edusharing/preview.php
(#25) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#46) Variable "curlResult" must be all lower-case
(#52) Variable "curlResult" must be all lower-case
(#53) Variable "curlResult" must be all lower-case

Javascript coding style problems

(2 errors, 122 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

lib/editor/atto/plugins/edusharing/yui/src/button/js/button.js
(#87) This line has a length of 136. Maximum allowed is 132. (max-len)
(#188) A constructor name should not start with a lowercase letter. (new-cap)
(#192) Unexpected alert. (no-alert)
(#309) Identifier 'resource_id' is not in camel case. (camelcase)
(#309) 'resource_id' declared on line 342 column 18 is used outside of binding context. (block-scoped-var)
(#310) Identifier 'resource_id' is not in camel case. (camelcase)
(#310) 'resource_id' declared on line 342 column 18 is used outside of binding context. (block-scoped-var)
(#310) Identifier 'resource_id' is not in camel case. (camelcase)
(#310) 'resource_id' declared on line 342 column 18 is used outside of binding context. (block-scoped-var)
(#311) Identifier 'resource_id' is not in camel case. (camelcase)
(#311) 'resource_id' declared on line 342 column 18 is used outside of binding context. (block-scoped-var)
(#313) A constructor name should not start with a lowercase letter. (new-cap)
(#314) Blocks are nested too deeply (5). Maximum allowed is 4. (max-depth)
(#315) Unexpected alert. (no-alert)
(#317) Blocks are nested too deeply (5). Maximum allowed is 4. (max-depth)
(#318) Unexpected alert. (no-alert)
(#322) Blocks are nested too deeply (5). Maximum allowed is 4. (max-depth)
(#342) 'resource_id' is already defined. (no-redeclare)
(#342) 'resource_id' declared on line 309 column 25 is used outside of binding context. (block-scoped-var)
(#343) 'resource_id' declared on line 309 column 25 is used outside of binding context. (block-scoped-var)
(#343) Identifier 'resource_id' is not in camel case. (camelcase)
(#344) 'node' declared on line 293 column 17 is used outside of binding context. (block-scoped-var)
(#345) Unexpected alert. (no-alert)
(#392) 'query' declared on line 394 column 21 is used outside of binding context. (block-scoped-var)
(#394) 'query' is already defined. (no-redeclare)
(#394) 'query' declared on line 392 column 21 is used outside of binding context. (block-scoped-var)
(#397) 'query' declared on line 392 column 21 is used outside of binding context. (block-scoped-var)
(#397) 'query' declared on line 394 column 21 is used outside of binding context. (block-scoped-var)
(#477) A function with a name starting with an uppercase letter should only be used as a constructor. (new-cap)
(#481) A function with a name starting with an uppercase letter should only be used as a constructor. (new-cap)
(#485) A function with a name starting with an uppercase letter should only be used as a constructor. (new-cap)
(#540) Identifier 'open_repo' is not in camel case. (camelcase)
(#565) Expected catch,fail,always() or return (promise/catch-or-return)
(#583) Each then() should return a value or throw (promise/always-return)
(#601) Identifier 'edusharing_hint_check_change' is not in camel case. (camelcase)
(#602) A function with a name starting with an uppercase letter should only be used as a constructor. (new-cap)
(#630) 'style' declared on line 658 column 17 is used outside of binding context. (block-scoped-var)
(#632) 'style' declared on line 658 column 17 is used outside of binding context. (block-scoped-var)
(#635) 'style' declared on line 658 column 17 is used outside of binding context. (block-scoped-var)
(#637) 'style' declared on line 658 column 17 is used outside of binding context. (block-scoped-var)
(#639) 'url' declared on line 645 column 21 is used outside of binding context. (block-scoped-var)
(#639) 'url' declared on line 674 column 17 is used outside of binding context. (block-scoped-var)
(#639) 'url' declared on line 682 column 17 is used outside of binding context. (block-scoped-var)
(#641) 'url' declared on line 645 column 21 is used outside of binding context. (block-scoped-var)
(#641) 'url' declared on line 674 column 17 is used outside of binding context. (block-scoped-var)
(#641) 'url' declared on line 682 column 17 is used outside of binding context. (block-scoped-var)
(#642) 'url' declared on line 645 column 21 is used outside of binding context. (block-scoped-var)
(#642) 'url' declared on line 674 column 17 is used outside of binding context. (block-scoped-var)
(#642) 'url' declared on line 682 column 17 is used outside of binding context. (block-scoped-var)
(#643) 'url' declared on line 645 column 21 is used outside of binding context. (block-scoped-var)
(#643) 'url' declared on line 674 column 17 is used outside of binding context. (block-scoped-var)
(#643) 'url' declared on line 682 column 17 is used outside of binding context. (block-scoped-var)
(#645) 'url' is already defined. (no-redeclare)
(#645) 'url' declared on line 639 column 21 is used outside of binding context. (block-scoped-var)
(#645) 'url' declared on line 674 column 17 is used outside of binding context. (block-scoped-var)
(#645) 'url' declared on line 682 column 17 is used outside of binding context. (block-scoped-var)
(#646) 'url' declared on line 639 column 21 is used outside of binding context. (block-scoped-var)
(#646) 'url' declared on line 674 column 17 is used outside of binding context. (block-scoped-var)
(#646) 'url' declared on line 682 column 17 is used outside of binding context. (block-scoped-var)
(#647) 'url' declared on line 639 column 21 is used outside of binding context. (block-scoped-var)
(#647) 'url' declared on line 674 column 17 is used outside of binding context. (block-scoped-var)
(#647) 'url' declared on line 682 column 17 is used outside of binding context. (block-scoped-var)
(#648) 'url' declared on line 639 column 21 is used outside of binding context. (block-scoped-var)
(#648) 'url' declared on line 674 column 17 is used outside of binding context. (block-scoped-var)
(#648) 'url' declared on line 682 column 17 is used outside of binding context. (block-scoped-var)
(#649) 'url' declared on line 639 column 21 is used outside of binding context. (block-scoped-var)
(#649) 'url' declared on line 674 column 17 is used outside of binding context. (block-scoped-var)
(#649) 'url' declared on line 682 column 17 is used outside of binding context. (block-scoped-var)
(#653) 'url' declared on line 639 column 21 is used outside of binding context. (block-scoped-var)
(#653) 'url' declared on line 674 column 17 is used outside of binding context. (block-scoped-var)
(#653) 'url' declared on line 682 column 17 is used outside of binding context. (block-scoped-var)
(#658) 'style' is already defined. (no-redeclare)
(#658) 'style' declared on line 630 column 17 is used outside of binding context. (block-scoped-var)
(#660) 'style' declared on line 630 column 17 is used outside of binding context. (block-scoped-var)
(#663) 'style' declared on line 630 column 17 is used outside of binding context. (block-scoped-var)
(#670) 'style' declared on line 630 column 17 is used outside of binding context. (block-scoped-var)
(#674) 'url' is already defined. (no-redeclare)
(#674) 'url' declared on line 639 column 21 is used outside of binding context. (block-scoped-var)
(#674) 'url' declared on line 645 column 21 is used outside of binding context. (block-scoped-var)
(#682) 'url' is already defined. (no-redeclare)
(#682) 'url' declared on line 639 column 21 is used outside of binding context. (block-scoped-var)
(#682) 'url' declared on line 645 column 21 is used outside of binding context. (block-scoped-var)
(#683) 'url' declared on line 639 column 21 is used outside of binding context. (block-scoped-var)
(#683) 'url' declared on line 645 column 21 is used outside of binding context. (block-scoped-var)
(#684) 'url' declared on line 639 column 21 is used outside of binding context. (block-scoped-var)
(#684) 'url' declared on line 645 column 21 is used outside of binding context. (block-scoped-var)
(#685) 'url' declared on line 639 column 21 is used outside of binding context. (block-scoped-var)
(#685) 'url' declared on line 645 column 21 is used outside of binding context. (block-scoped-var)
(#686) 'url' declared on line 639 column 21 is used outside of binding context. (block-scoped-var)
(#686) 'url' declared on line 645 column 21 is used outside of binding context. (block-scoped-var)
(#687) 'url' declared on line 639 column 21 is used outside of binding context. (block-scoped-var)
(#687) 'url' declared on line 645 column 21 is used outside of binding context. (block-scoped-var)
(#688) 'url' declared on line 639 column 21 is used outside of binding context. (block-scoped-var)
(#688) 'url' declared on line 645 column 21 is used outside of binding context. (block-scoped-var)
(#691) 'url' declared on line 639 column 21 is used outside of binding context. (block-scoped-var)
(#691) 'url' declared on line 645 column 21 is used outside of binding context. (block-scoped-var)
(#693) 'url' declared on line 639 column 21 is used outside of binding context. (block-scoped-var)
(#693) 'url' declared on line 645 column 21 is used outside of binding context. (block-scoped-var)
(#716) Expected a 'break' statement before 'case'. (no-fallthrough)
(#784) Identifier 'course_id' is not in camel case. (camelcase)
(#786) Identifier 'object_url' is not in camel case. (camelcase)
(#787) Identifier 'course_id' is not in camel case. (camelcase)
(#789) Identifier 'object_version' is not in camel case. (camelcase)
(#808) Identifier 'object_url' is not in camel case. (camelcase)
(#809) Identifier 'object_url' is not in camel case. (camelcase)
(#812) Identifier 'object_url' is not in camel case. (camelcase)
(#812) Identifier 'object_url' is not in camel case. (camelcase)
(#814) Identifier 'resource_id' is not in camel case. (camelcase)
(#815) Identifier 'resource_id' is not in camel case. (camelcase)
(#816) Identifier 'resource_id' is not in camel case. (camelcase)
(#819) Identifier 'object_version' is not in camel case. (camelcase)
(#820) Identifier 'object_version' is not in camel case. (camelcase)
(#821) Identifier 'object_version' is not in camel case. (camelcase)
(#821) Identifier 'object_version' is not in camel case. (camelcase)
(#837) Identifier 'helper_url' is not in camel case. (camelcase)
(#844) A function with a name starting with an uppercase letter should only be used as a constructor. (new-cap)
(#869) Unexpected alert. (no-alert)
(#874) 'data' declared on line 867 column 25 is used outside of binding context. (block-scoped-var)
(#875) Unexpected alert. (no-alert)
(#879) 'data' declared on line 867 column 25 is used outside of binding context. (block-scoped-var)
(#886) Unexpected alert. (no-alert)
(#904) Identifier 'helper_url' is not in camel case. (camelcase)
(#910) A function with a name starting with an uppercase letter should only be used as a constructor. (new-cap)
(#930) Unexpected alert. (no-alert)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]


Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "eslint:yui" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]