Prechecker results: error


PHP lint problems

(1 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]

mod/assign/submission/submarker/tests/locallib_test.php
(#86) PHP Parse error: syntax error, unexpected '$result' (T_VARIABLE) in /mod/assign/submission/submarker/tests/locallib_test.php on line 86

PHP coding style problems

(101 errors, 10 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/assign/submission/submarker/classes/event/assessable_uploaded.php
(#69) Whitespace found at end of line
mod/assign/submission/submarker/classes/event/submission_created.php
(#52) Line exceeds 132 characters; contains 133 characters
mod/assign/submission/submarker/classes/event/submission_updated.php
(#53) Line exceeds 132 characters; contains 135 characters
mod/assign/submission/submarker/db/upgrade.php
(#44) Inline comments must end in full-stops, exclamation marks, or question marks
mod/assign/submission/submarker/lang/sv_fi/assignsubmission_submarker.php
(#28) Inline comments must end in full-stops, exclamation marks, or question marks
(#28) No space found before comment text; expected "// Samma på svenska" but found "//Samma på svenska"
mod/assign/submission/submarker/lib.php
(#54) Expected 1 space before "=>"; 0 found
(#54) Expected 1 space after "=>"; 0 found
mod/assign/submission/submarker/locallib.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#115) Inline comments must start with a capital letter, digit or 3-dots sequence
(#115) Inline comments must end in full-stops, exclamation marks, or question marks
(#115) No space found before comment text; expected "// exercises should be something like "10011"" but found "//exercises should be something like "10011""
(#119) Whitespace found at end of line
(#125) Expected 1 space before "="; 0 found
(#125) Expected 1 space after "="; 0 found
(#129) Line exceeds maximum limit of 180 characters; contains 200 characters
(#135) Whitespace found at end of line
(#137) Whitespace found at end of line
(#140) Expected 1 space before "-"; 0 found
(#140) Expected 1 space after "-"; 0 found
(#144) Variable "student_form" must not contain underscores.
(#145) Variable "student_form" must not contain underscores.
(#172) This comment is 59% valid code; is this commented out code?
(#210) Whitespace found at end of line
(#213) Line exceeds 132 characters; contains 172 characters
(#225) Line indented incorrectly; expected at least 12 spaces, found 10
(#234) Line indented incorrectly; expected at least 12 spaces, found 10
(#235) Line indented incorrectly; expected at least 12 spaces, found 10
(#237) Line indented incorrectly; expected at least 12 spaces, found 10
(#254) Inline comments must end in full-stops, exclamation marks, or question marks
(#254) Line indented incorrectly; expected at least 12 spaces, found 10
(#254) No space found before comment text; expected "// Update" but found "//Update"
(#255) Line indented incorrectly; expected at least 12 spaces, found 10
(#256) Line indented incorrectly; expected at least 12 spaces, found 10
(#257) Line indented incorrectly; expected at least 12 spaces, found 10
(#258) Line indented incorrectly; expected at least 12 spaces, found 10
(#260) Inline comments must end in full-stops, exclamation marks, or question marks
(#260) Line indented incorrectly; expected at least 12 spaces, found 10
(#260) No space found before comment text; expected "// Create" but found "//Create"
(#261) Line indented incorrectly; expected at least 12 spaces, found 10
(#262) Line indented incorrectly; expected at least 12 spaces, found 10
(#263) Line indented incorrectly; expected at least 12 spaces, found 10
(#265) Line indented incorrectly; expected at least 12 spaces, found 10
(#266) Line indented incorrectly; expected at least 12 spaces, found 10
(#267) Line indented incorrectly; expected at least 12 spaces, found 10
(#268) Line indented incorrectly; expected at least 12 spaces, found 10
(#269) Line indented incorrectly; expected at least 12 spaces, found 10
(#274) No space found before comment text; expected "// Giving grade has to be after submission to get the submission and attemptnumber to match it from DB." but found "//Giving grade has to be after submission to get the submission and attemptnumber to match it from DB."
(#280) Whitespace found at end of line
(#282) Whitespace found at end of line
(#288) Whitespace found at end of line
(#292) Visibility must be declared on method "exercises_to_text"
(#294) Expected "foreach (...) {\n"; found "foreach(...) {\n"
(#294) Expected 1 space before "=>"; 0 found
(#294) Expected 1 space after "=>"; 0 found
(#294) Expected 1 space before "=>"; 0 found
(#294) Expected 1 space after "=>"; 0 found
(#304) Whitespace found at end of line
(#309) Line indented incorrectly; expected at least 8 spaces, found 6
(#310) Line indented incorrectly; expected 8 spaces, found 6
(#310) Expected "for (...) {\n"; found "for (...){\n"
(#311) Line indented incorrectly; expected 12 spaces, found 8
(#312) Line indented incorrectly; expected at least 16 spaces, found 12
(#313) Line indented incorrectly; expected 12 spaces, found 8
(#314) Line indented incorrectly; expected 8 spaces, found 6
(#315) Line indented incorrectly; expected 8 spaces, found 6
(#315) Expected "if (...) {\n"; found "if(...) {\n"
(#316) Line indented incorrectly; expected at least 12 spaces, found 8
(#317) Line indented incorrectly; expected 8 spaces, found 6
(#318) Line indented incorrectly; expected at least 12 spaces, found 8
(#319) Line indented incorrectly; expected 8 spaces, found 6
(#320) Line indented incorrectly; expected at least 8 spaces, found 6
(#325) Whitespace found at end of line
(#329) Visibility must be declared on method "get_completed_exercise_count"
(#331) Expected "for (...) {\n"; found "for (...){\n"
(#347) Line indented incorrectly; expected at least 8 spaces, found 6
(#348) Line indented incorrectly; expected at least 8 spaces, found 6
(#349) Line indented incorrectly; expected at least 8 spaces, found 6
(#392) Expected "foreach (...) {\n"; found "foreach(...) {\n"
(#392) Expected 1 space before "=>"; 0 found
(#392) Expected 1 space after "=>"; 0 found
(#392) Expected 1 space before "=>"; 0 found
(#392) Expected 1 space after "=>"; 0 found
mod/assign/submission/submarker/settings.php
(#25) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/assign/submission/submarker/student_form.php
(#1) Line 1 of the opening comment must start "// This file is part of".
(#1) Whitespace found at end of line
(#2) Line 2 of the opening comment must start "//".
(#3) Line 3 of the opening comment must start "// Moodle is free software: you can redistribute it and/or modify".
(#3) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#3) Line 4 of the opening comment must start "// it under the terms of the GNU General Public License as published by".
(#3) Line 5 of the opening comment must start "// the Free Software Foundation, either version 3 of the License, or".
(#3) Line 6 of the opening comment must start "// (at your option) any later version.".
(#3) Line 7 of the opening comment must start "//".
(#3) Line 8 of the opening comment must start "// Moodle is distributed in the hope that it will be useful,".
(#3) Line 9 of the opening comment must start "// but WITHOUT ANY WARRANTY; without even the implied warranty of".
(#3) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#3) Line 11 of the opening comment must start "// GNU General Public License for more details.".
(#3) Line 12 of the opening comment must start "//".
(#4) Line 13 of the opening comment must start "// You should have received a copy of the GNU General Public License".
(#5) Line 14 of the opening comment must start "// along with Moodle. If not, see <http://www.gnu.org/licenses/>.".
(#7) Visibility must be declared on method "definition"
mod/assign/submission/submarker/tests/locallib_test.php
(#78) Variable "submissionBoxes" must be all lower-case
(#84) Variable "submissionBoxes" must be all lower-case
(#97) Variable "submissionBoxes" must be all lower-case
(#100) Variable "submissionBoxes" must be all lower-case
(#101) Variable "submissionBoxes" must be all lower-case
(#102) Variable "submissionBoxes" must be all lower-case
(#114) Line indented incorrectly; expected at least 8 spaces, found 6
(#116) Commas (,) must be followed by white space.
(#116) Commas (,) must be followed by white space.
(#117) Line indented incorrectly; expected at least 8 spaces, found 6

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(17 errors, 2 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/assign/submission/submarker/classes/event/assessable_uploaded.php
(#120) Function assessable_uploaded::get_objectid_mapping is not documented
mod/assign/submission/submarker/classes/event/submission_created.php
(#63) Function submission_created::get_objectid_mapping is not documented
mod/assign/submission/submarker/classes/event/submission_updated.php
(#64) Function submission_updated::get_objectid_mapping is not documented
mod/assign/submission/submarker/locallib.php
(#2) Empty line found after PHP open tag
(#70) Function assign_submission_submarker::get_edit_options is not documented
(#149) Function assign_submission_submarker::get_settings is not documented
(#391) Function assign_submission_submarker::submission_is_empty is not documented
(#107) Phpdocs for function assign_submission_submarker::get_form_elements has incomplete parameters list
(#23) Package submissions_submarker is not valid
mod/assign/submission/submarker/student_form.php
(#2) Empty line found after PHP open tag
(#3) File-level phpdocs block is not found
(#5) Class student_form is not documented
(#7) Function student_form::definition is not documented
(#12) Function student_form::draw_checkbox_controller is not documented
(#10) Variable student_form::$_form is not documented
(#5) Package is not specified for class student_form. It is also not specified in file-level phpdocs
mod/assign/submission/submarker/tests/events_test.php
(#30) Class assignsubmission_submarker_events_testcase is not documented
mod/assign/submission/submarker/tests/locallib_test.php
(#75) Phpdocs for function assignsubmission_submarker_locallib_testcase::test_submission_is_empty has incomplete parameters list
(#94) Phpdocs for function assignsubmission_submarker_locallib_testcase::test_new_submission_empty has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]