Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(45 errors, 50 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/assign/submission/helixassign/backup/moodle2/backup_assignsubmission_helixassign_subplugin.class.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#48) Short array syntax must be used to define arrays
(#55) Short array syntax must be used to define arrays
mod/assign/submission/helixassign/backup/moodle2/restore_assignsubmission_helixassign_subplugin.class.php
(#41) Short array syntax must be used to define arrays
mod/assign/submission/helixassign/classes/event/assessable_compat_uploaded.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/assign/submission/helixassign/classes/event/assessable_uploaded.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#70) Short array syntax must be used to define arrays
(#83) Missing docblock for function get_objectid_mapping
(#84) Short array syntax must be used to define arrays
mod/assign/submission/helixassign/classes/event/submission_created.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#72) Short array syntax must be used to define arrays
mod/assign/submission/helixassign/classes/event/submission_updated.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#72) Short array syntax must be used to define arrays
mod/assign/submission/helixassign/classes/output/mobile.php
(#17) Missing @copyright tag
(#20) Incorrect @package tag for file mobile.php. Expected assignsubmission_helixassign, found mod.
(#32) Whitespace found at end of line
(#36) Missing docblock for class mobile
(#37) Whitespace found at end of line
(#51) Line exceeds 132 characters; contains 146 characters
(#51) There should be a comma after the last array item in a multi-line array.
(#52) There should be a comma after the last array item in a multi-line array.
(#54) There should be a comma after the last array item in a multi-line array.
(#58) Missing docblock for function random_code
(#59) Opening brace should be on the same line as the declaration
(#61) Expected 1 space before "-"; 0 found
(#61) Expected 1 space after "-"; 0 found
mod/assign/submission/helixassign/classes/privacy/provider.php
(#19) Missing @copyright tag
(#19) Missing @license tag
(#19) Missing docblock for class provider
(#29) There must not be a space before the colon in a return type declaration
mod/assign/submission/helixassign/db/access.php
(#1) Missing @copyright tag
(#1) Missing @license tag
(#1) Missing docblock for file access.php
(#21) Short array syntax must be used to define arrays
(#22) Short array syntax must be used to define arrays
(#27) Short array syntax must be used to define arrays
(#29) There should be a comma after the last array item in a multi-line array.
(#30) There should be a comma after the last array item in a multi-line array.
(#31) There should be a comma after the last array item in a multi-line array.
mod/assign/submission/helixassign/db/install.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/assign/submission/helixassign/db/mobile.php
(#1) Whitespace found at end of line
(#1) Moodle boilerplate not found at first line
(#17) Missing @copyright tag
(#20) Incorrect @package tag for file mobile.php. Expected assignsubmission_helixassign, found mod.
(#30) Whitespace found at end of line
(#31) Whitespace found at end of line
(#37) Whitespace found at end of line
(#38) Whitespace found at end of line
(#39) Whitespace found at end of line
(#42) There should be a comma after the last array item in a multi-line array.
(#43) There should be a comma after the last array item in a multi-line array.
(#49) There should be a comma after the last array item in a multi-line array.
(#50) There should be a comma after the last array item in a multi-line array.
mod/assign/submission/helixassign/db/upgrade.php
(#39) Short array syntax must be used to define arrays
mod/assign/submission/helixassign/lang/en/assignsubmission_helixassign.php
(#27) The string key "default" is not in the correct order, it should be before "helixassign:can_use"
(#34) The string key "nopermission" is not in the correct order, it should be before "nosubmissionshort"
(#35) The string key "helixassign" is not in the correct order, it should be before "nopermission"
(#44) The string key "no_permission" is not in the correct order, it should be before "view_submission"
(#45) The string key "mobilesub" is not in the correct order, it should be before "no_permission"
(#46) The string key "mobilelink" is not in the correct order, it should be before "mobilesub"
mod/assign/submission/helixassign/lib.php
(#24) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/assign/submission/helixassign/locallib.php
(#42) Inline comments must end in full-stops, exclamation marks, or question marks
(#43) You must use "/**" style comments for a member variable comment
(#64) Short array syntax must be used to define arrays
(#87) Short array syntax must be used to define arrays
(#118) Short array syntax must be used to define arrays
(#125) Short array syntax must be used to define arrays
(#126) Short array syntax must be used to define arrays
(#140) TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
(#156) Short array syntax must be used to define arrays
(#156) Line exceeds 132 characters; contains 139 characters
(#178) Short array syntax must be used to define arrays
(#182) Short array syntax must be used to define arrays
(#183) Short array syntax must be used to define arrays
(#185) There should be a comma after the last array item in a multi-line array.
(#186) There should be a comma after the last array item in a multi-line array.
(#205) Short array syntax must be used to define arrays
(#213) Short array syntax must be used to define arrays
(#218) There should be a comma after the last array item in a multi-line array.
(#230) Short array syntax must be used to define arrays
(#260) Short array syntax must be used to define arrays
(#260) Expected 1 space after "=>"; 0 found
(#276) Short array syntax must be used to define arrays
(#300) Short array syntax must be used to define arrays
(#300) Expected 1 space after "=>"; 0 found
(#301) Short array syntax must be used to define arrays
(#301) Expected 1 space after "=>"; 0 found
(#369) Short array syntax must be used to define arrays
(#402) Line exceeds 132 characters; contains 154 characters
(#402) Inline comments must end in full-stops, exclamation marks, or question marks
(#404) Line exceeds 132 characters; contains 138 characters
(#427) Short array syntax must be used to define arrays
mod/assign/submission/helixassign/settings.php
(#35) Short array syntax must be used to define arrays
mod/assign/submission/helixassign/version.php
(#32) Short array syntax must be used to define arrays
(#33) There should be a comma after the last array item in a multi-line array.

Javascript coding style problems

(12 errors, 12 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

mod/assign/submission/helixassign/amd/src/cancel.js
(#17) @package should be empty. (jsdoc/empty-tags)
(#26) Operator '=' must be spaced. (space-infix-ops)
(#27) There should be no space before this paren. (space-in-parens)
(#28) 'ActiveXObject' is not defined. (no-undef)
(#31) Operator '=' must be spaced. (space-infix-ops)
(#31) Operator '+' must be spaced. (space-infix-ops)
(#31) Operator '+' must be spaced. (space-infix-ops)
(#31) Operator '+' must be spaced. (space-infix-ops)
(#32) There should be no space before ','. (comma-spacing)
(#33) A space is required after ','. (comma-spacing)
(#36) Missing semicolon. (@babel/semi)
(#39) Operator '=' must be spaced. (space-infix-ops)
(#40) Use '===' to compare with null. (no-eq-null)
(#40) Operator '!=' must be spaced. (space-infix-ops)
(#43) Missing semicolon. (@babel/semi)
(#44) Trailing spaces not allowed. (no-trailing-spaces)
(#50) Missing semicolon. (@babel/semi)
mod/assign/submission/helixassign/mobile/mobile.js
(#1) Trailing spaces not allowed. (no-trailing-spaces)
(#2) 'that' is assigned a value but never used. (no-unused-vars)
(#5) Unexpected console statement. (no-console)
(#9) Operator '+' must be spaced. (space-infix-ops)
(#9) Operator '+' must be spaced. (space-infix-ops)
(#14) Trailing spaces not allowed. (no-trailing-spaces)
(#15) Expected an assignment or function call and instead saw an expression. (no-unused-expressions)

CSS problems

(28 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

mod/assign/submission/helixassign/mobile/styles_app.css
(#8) Can't parse value "var(0 1px 4px rgba(0,0,0,.6))" (csstree/validator)
(#9) Can't parse value "var(border-color .4s ease 0s,background-color .4s ease 0s)" (csstree/validator)
(#2) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#3) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#4) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#8) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#9) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#10) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#14) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#16) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#17) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#25) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#29) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#34) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#35) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#36) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#7) Unexpected !important (declaration-no-important)
(#29) Unexpected !important (declaration-no-important)
(#6) Expected single space after "," in a single-line function (function-comma-space-after)
(#6) Expected single space after "," in a single-line function (function-comma-space-after)
(#6) Expected single space after "," in a single-line function (function-comma-space-after)
(#8) Expected single space after "," in a single-line function (function-comma-space-after)
(#8) Expected single space after "," in a single-line function (function-comma-space-after)
(#8) Expected single space after "," in a single-line function (function-comma-space-after)
(#9) Expected single space after "," in a single-line function (function-comma-space-after)
(#28) Expected newline after "," (selector-list-comma-newline-after)
(#14) Expected single space after "," in a single-line list (value-list-comma-space-after)
(#14) Expected single space after "," in a single-line list (value-list-comma-space-after)

PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]


Update savepoints problems

(3 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

mod/assign/submission/helixassign/db/upgrade.php
Detected more 'if' blocks (2) than 'savepoint' calls (0)
version 2014050601 is missing corresponding savepoint call
version 2014111710 is missing corresponding savepoint call

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "eslint:amd" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]