Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(4 errors, 18 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/assign/submission/gradereviews/classes/event/gradereview_created.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/assign/submission/gradereviews/classes/event/gradereview_deleted.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/assign/submission/gradereviews/classes/privacy/provider.php
(#58) Method name "_get_metadata" should not be prefixed with an underscore to indicate visibility
(#69) Method name "_get_context_for_userid_within_submission" should not be prefixed with an underscore to indicate visibility
(#92) Method name "_get_student_user_ids" should not be prefixed with an underscore to indicate visibility
(#115) Method name "_export_submission_user_data" should not be prefixed with an underscore to indicate visibility
(#141) Method name "_delete_submission_for_context" should not be prefixed with an underscore to indicate visibility
(#154) Method name "_delete_submission_for_userid" should not be prefixed with an underscore to indicate visibility
mod/assign/submission/gradereviews/db/access.php
(#25) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/assign/submission/gradereviews/db/install.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/assign/submission/gradereviews/db/upgrade.php
(#68) Functions must not contain multiple empty lines in a row; found 2 empty lines
mod/assign/submission/gradereviews/lang/en/assignsubmission_gradereviews.php
(#34) File must end with a newline character
mod/assign/submission/gradereviews/lib.php
(#24) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#155) Whitespace found at end of line
(#160) Inline comments must end in full-stops, exclamation marks, or question marks
mod/assign/submission/gradereviews/tests/events_test.php
(#41) PHPUnit testcase name "assignsubmission_gradereviews_events_testcase" does not match file name "events_test"
(#41) PHPUnit class "assignsubmission_gradereviews_events_testcase" does not have any namespace. It is recommended to add it to the "assignsubmission_gradereviews" namespace, using more levels if needed, in order to match the code being tested
mod/assign/submission/gradereviews/tests/privacy_test.php
(#36) Inline comments must start with a capital letter, digit or 3-dots sequence
(#36) This comment is 46% valid code; is this commented out code?
(#37) Inline comments must end in full-stops, exclamation marks, or question marks
(#52) PHPUnit testcase name "assignsubmission_gradereviews_privacy_testcase" does not match file name "privacy_test"
(#52) PHPUnit class "assignsubmission_gradereviews_privacy_testcase" does not have any namespace. It is recommended to add it to the "assignsubmission_gradereviews" namespace, using more levels if needed, in order to match the code being tested

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(2 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/assign/submission/gradereviews/tests/privacy_test.php
(#67) Phpdocs for function assignsubmission_gradereviews_privacy_testcase::create_submission has incomplete parameters list
(#456) Phpdocs for function assignsubmission_gradereviews_privacy_testcase::assert_export_comments has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Missing changes in external functions or backup support for new detected tables or columns

(0 errors, 0 warnings)

This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]