Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(27 errors, 93 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/assign/submission/collabora/backup/moodle2/backup_assignsubmission_collabora_subplugin.class.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/assign/submission/collabora/backup/moodle2/restore_assignsubmission_collabora_subplugin.class.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/assign/submission/collabora/callback.php
(#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
mod/assign/submission/collabora/classes/callbacklib.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#45) The static declaration must come after the visibility declaration
(#150) File must end with a newline character
mod/assign/submission/collabora/classes/event/assessable_uploaded.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#74) Space found before square bracket; expected "data[" but found "data ["
mod/assign/submission/collabora/classes/event/submission_created.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#49) Space found before square bracket; expected "other[" but found "other ["
mod/assign/submission/collabora/classes/event/submission_updated.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#50) Space found before square bracket; expected "other[" but found "other ["
mod/assign/submission/collabora/classes/output/content.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/assign/submission/collabora/classes/test_setup_trait.php
(#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#83) Inline comments must end in full-stops, exclamation marks, or question marks
mod/assign/submission/collabora/db/caches.php
(#31) File must end with a newline character
mod/assign/submission/collabora/index.php
(#29) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
mod/assign/submission/collabora/locallib.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#184) Space found before square bracket; expected "$action[" but found "$action ["
(#184) Space found before square bracket; expected "$action[" but found "$action ["
(#332) Space found before square bracket; expected "$thisplugincfg[" but found "$thisplugincfg ["
(#613) Space found before square bracket; expected "$params[" but found "$params ["
(#615) Space found before square bracket; expected "$params[" but found "$params ["
(#633) Space found before square bracket; expected "$params[" but found "$params ["
(#634) Space found before square bracket; expected "$params[" but found "$params ["
(#635) Space found before square bracket; expected "$params[" but found "$params ["
(#681) Space found before square bracket; expected "$result[" but found "$result ["
(#683) Space found before square bracket; expected "$result[" but found "$result ["
mod/assign/submission/collabora/settings.php
(#24) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/assign/submission/collabora/tests/behat/behat_assignsubmission_collabora.php
(#46) Inline comments must end in full-stops, exclamation marks, or question marks
(#51) Inline comments must end in full-stops, exclamation marks, or question marks
mod/assign/submission/collabora/tests/callbacklib_test.php
(#41) PHPUnit testcase name "assignsubmission_collabora_callback_testcase" does not match file name "callbacklib_test"
(#41) PHPUnit class "assignsubmission_collabora_callback_testcase" does not have any namespace. It is recommended to add it to the "assignsubmission_collabora" namespace, using more levels if needed, in order to match the code being tested
(#68) Inline comments must start with a capital letter, digit or 3-dots sequence
(#68) Inline comments must end in full-stops, exclamation marks, or question marks
(#86) Inline comments must start with a capital letter, digit or 3-dots sequence
(#89) Inline comments must end in full-stops, exclamation marks, or question marks
mod/assign/submission/collabora/tests/events_test.php
(#37) PHPUnit testcase name "assignsubmission_collabora_events_testcase" does not match file name "events_test"
(#37) PHPUnit class "assignsubmission_collabora_events_testcase" does not have any namespace. It is recommended to add it to the "assignsubmission_collabora" namespace, using more levels if needed, in order to match the code being tested
(#87) Inline comments must end in full-stops, exclamation marks, or question marks
mod/assign/submission/collabora/tests/locallib_test.php
(#39) PHPUnit testcase name "assignsubmission_collabora_locallib_testcase" does not match file name "locallib_test"
(#39) PHPUnit class "assignsubmission_collabora_locallib_testcase" does not have any namespace. It is recommended to add it to the "assignsubmission_collabora" namespace, using more levels if needed, in order to match the code being tested
(#61) Inline comments must start with a capital letter, digit or 3-dots sequence
(#61) Inline comments must end in full-stops, exclamation marks, or question marks
(#102) Line exceeds 132 characters; contains 150 characters
(#106) This comment is 59% valid code; is this commented out code?
(#122) Inline comments must start with a capital letter, digit or 3-dots sequence
(#122) Inline comments must end in full-stops, exclamation marks, or question marks
(#148) Inline comments must start with a capital letter, digit or 3-dots sequence
(#162) Inline comments must start with a capital letter, digit or 3-dots sequence
(#168) Inline comments must start with a capital letter, digit or 3-dots sequence
(#209) Inline comments must end in full-stops, exclamation marks, or question marks
(#353) Inline comments must start with a capital letter, digit or 3-dots sequence
(#418) Inline comments must end in full-stops, exclamation marks, or question marks
(#442) Inline comments must end in full-stops, exclamation marks, or question marks
mod/assign/submission/collabora/tests/privacy_test.php
(#38) PHPUnit testcase name "assignsubmission_collabora_privacy_testcase" does not match file name "privacy_test"
(#38) PHPUnit class "assignsubmission_collabora_privacy_testcase" does not have any namespace. It is recommended to add it to the "assignsubmission_collabora" namespace, using more levels if needed, in order to match the code being tested
(#115) Inline comments must start with a capital letter, digit or 3-dots sequence
(#115) Inline comments must end in full-stops, exclamation marks, or question marks
(#115) This comment is 80% valid code; is this commented out code?
mod/assign/submission/collabora/tests/test-collabora.php
(#24) Inline comments must end in full-stops, exclamation marks, or question marks
(#79) Inline comments must start with a capital letter, digit or 3-dots sequence
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Inline comments must end in full-stops, exclamation marks, or question marks
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#80) Line exceeds 132 characters; contains 141 characters
(#81) Inline comments must end in full-stops, exclamation marks, or question marks
(#135) Inline comments must start with a capital letter, digit or 3-dots sequence
(#135) Inline comments must end in full-stops, exclamation marks, or question marks
(#137) The use of function error_log() is forbidden; use debugging() instead
(#141) The use of function error_log() is forbidden; use debugging() instead
(#169) The use of function error_log() is forbidden; use debugging() instead
(#173) Inline comments must start with a capital letter, digit or 3-dots sequence
(#173) Inline comments must end in full-stops, exclamation marks, or question marks
(#184) The use of function error_log() is forbidden; use debugging() instead
(#184) The use of function print_r() is forbidden
(#191) The use of function error_log() is forbidden; use debugging() instead
(#199) The use of function error_log() is forbidden; use debugging() instead
(#201) The use of function error_log() is forbidden; use debugging() instead
(#205) Inline comments must start with a capital letter, digit or 3-dots sequence
(#206) The use of function error_log() is forbidden; use debugging() instead
(#208) The use of function error_log() is forbidden; use debugging() instead
(#253) The use of function print_r() is forbidden

Javascript coding style problems

(2 errors, 5 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

mod/assign/submission/collabora/amd/src/modal_iframe.js
(#17) @package should be empty. (jsdoc/empty-tags)
(#28) Unexpected space before function parentheses. (space-before-function-paren)
(#37) Unexpected space before function parentheses. (space-before-function-paren)
(#42) Unexpected space before function parentheses. (space-before-function-paren)
(#48) Unexpected space before function parentheses. (space-before-function-paren)
mod/assign/submission/collabora/amd/src/resizeiframe.js
(#2) Missing JSDoc comment. (jsdoc/require-jsdoc)
(#2) Missing JSDoc comment. (require-jsdoc)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(4 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/assign/submission/collabora/classes/output/content.php
(#29) Class content is not documented
(#33) Function content::__construct is not documented
(#51) Function content::export_for_template is not documented
(#17) No one-line description found in phpdocs for file

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Missing changes in external functions or backup support for new detected tables or columns

(0 errors, 0 warnings)

This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "eslint:amd" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]