I am having an issue with the advanced preferences in Gradebook plus. When I click show advanced features they appear, but when I click on hide advanced preferences I get a blank page and it does not actually save the change in setting.
has anyone else seen this?
I should specify that this is gradebook plus version 2. Also, I recently re-downloaded the 1.7 version and it is still having the same problem.
Any insight that folks might have would be greatly appreciated.
Any insight that folks might have would be greatly appreciated.
This is a known bug. See http://tracker.moodle.org/browse/CONTRIB-83
Here's a fix for this bug. Also attached to the bug report (CONTRIB-83).
-Ann
Index: lib.php
===================================================================
RCS file: /cvsroot/moodle/contrib/patches/gradebookplus_v2_1.7/lib.php,v
retrieving revision 1.4
diff -u -r1.4 lib.php
--- lib.php 15 Jun 2007 12:54:05 -0000 1.4
+++ lib.php 12 Nov 2007 11:11:45 -0000
@@ -1129,7 +1129,7 @@
/// We don't need advanced features, and we need to unset all extra features
/// So they don't affect grades (This approach should be revisited because it resets everything!!)
- $prefs = get_records('grade_preferences', 'courseid', $course);
+ $prefs = get_records('grade_preferences', 'courseid', $course->id);
$prefs = urlencode(md5(serialize($prefs)));
if ($reset) {
if ($reset == $prefs) {
-Ann
Index: lib.php
===================================================================
RCS file: /cvsroot/moodle/contrib/patches/gradebookplus_v2_1.7/lib.php,v
retrieving revision 1.4
diff -u -r1.4 lib.php
--- lib.php 15 Jun 2007 12:54:05 -0000 1.4
+++ lib.php 12 Nov 2007 11:11:45 -0000
@@ -1129,7 +1129,7 @@
/// We don't need advanced features, and we need to unset all extra features
/// So they don't affect grades (This approach should be revisited because it resets everything!!)
- $prefs = get_records('grade_preferences', 'courseid', $course);
+ $prefs = get_records('grade_preferences', 'courseid', $course->id);
$prefs = urlencode(md5(serialize($prefs)));
if ($reset) {
if ($reset == $prefs) {
Ann - Thanks for the patch. I have added another patch file in the tracker for this issue that would fix this and bring the code up to date with the latest changes in Moodle core. Could you and others test them and let me know if it works. Unfortunately with my current studies (working on a graduate degree in theology) I do not have time for testing and would be more comfortable making the commit if I knew that it was not going to cause more problems than it fixes. Thanks - Anthony