I needed a block to show our teachers what assignment work needed marking without having to navigate to each assignment in turn. I found a 'marking' block but it had not been updated, so I wrote a simple block (attached) that works in 1.8 (not tested it in 1.7).
It can only be added to the frontpage and if the user does not have any outstanding assignments to mark it is hidden (ie students won't see it at all).
I would love to get some feedback on it so feel free to download and install. It is far simpler than the old marking block but does everything we need.
I have also added it to the blocks database:
This is just too funny; I post a request for this, thinking it's a long shot as long as they get, and three hours later your block shows up!
I've just downloaded it and look forward to trying it out. Thanks a million!
The block correctly displays all unmarked assignments for the logged-in teacher (and very nicely, I might add!), but the links don't work.
I'm not sure, but it seems it does not write the course ID correctly. The error message Moodle gives is "Course module is incorrect", and upon closer inspection I see that all the links are the same no matter what course the assignment belongs to:
I'm no programmer, but I'm guessing an id number should have been written after the "id=" bit?
I have tried out the block and agree to Tore, its great piece of fuction. But as I click on the link to the un-assesed assignment work it shows me message "Course module is incorect"
Is it the same as Tore's issue? I will try to look through your block and find the mistake, let u know later...
$module = get_record_select('course_modules', $select,'id')
it refers to a variable called $select which is not defined... or rather it is defined much earlier for a different context and so does not work
the solution is to add this line just before the above line:
$select = "course=$val->id and module=1 and instance=$val2->id";
Thank you very much.
Thanks for the fix. Does it work OK now?
Attached is the block with Bruno's additional line of code. I have not had a chance to test it thoroughly yet...
I attempted to maintain marking block for 1.6 but gave up because the code was too time-consumming for me to figure out the bugs
I am very happy to restart fresh with your minimalist approach (which i like)
I extended your code to include 3 other mod types besides assignment, namely: journal, FAQ and forums
Now there are two marking blocks listed on moodle.org plugin database (the old buggy one from 1.6, and this one). Could you rename it "marking block for 1.8" or add it in (or let me add it in) to the old one as version 1.8 since there will not be any further development from the old code base as far as i can tell.
I have included my extended version of your block_marking.php code here for your pleasure, but really code should be pointed to in the plugins database to avoid the staleness problem when we post code to the forums
It would be great if we could tie this in with ajax code like in the MyCourses block so that teachers can open and close courses to see the unmarked work within. Potentialy as it stands, this could become quite a large list.
essay questions in quizzes
no ajax at this time. I am aiming for immediate production (teachers need this now), and when I have more time I (or someone else) can improve this block with ajax
I want to make sure no markable items ever go un-noticed (i.e. un-assessed).
I am currently testing the new marking block as I have decided that I wasnt going to upgrade beyond 1.6 until this had been been given the 1.8 / 1.9 treatment.
I am having a problem with the links that it is generating. They are all pointing in the wrong place. It seems to think that eveything is inside the course folder. When I manually remove the course section it works fine.
I downloaded this from the Modules and Plugins page. Not here.
Also I dont suppose any of the other Marking Block features are planned for a reappearance?
- Group Support
- Overdue Students
- Marking Page
- Full Report - Inc a way of setting the target.
I just fixed that and the link in modules and plugins is now uptodate
Miroslav: so since admins have marking rights on all activities, they see everything. But understanding how permissions work, you can simply switch roles when you want to mark: switch to teacher role and you will have access only to the stuff you are allowed to mark
Would it be sensible to remove my marking block from the plugins database? Would be happy to do this as long as I can access and work on the code base for your block.
Would Martin be able to set up a CVS for this?
Administrators see all the work for marking because they have permission to mark assignments at the site context. This could be sorted by checking for admin rights at the site context and then not displaying the block at all, however this would be a problem for admins who are also teachers.
Hubris tells me there is a solution out there somewhere but it may take a bit of thinking to find it
I have now modified the code so that administrators only see marking for the courses they teach on (either as a teacher or non-editing teacher).
This was achieved using the get_role_users() function.
I have also fixed a few bugs such as the code using non-existent capabilities:
the capability mod/journal:grade was replaced with mod/assignment:grade (I could not find any capabilities for journals in 1.8 ????)
the capability mod/forum:grade was replaced with mod/forum:rate
I have not tested the other marking types.
One additional bug is that the links from all marking apart from the assignment ones do not work!
Attached is the revised version of block_marking.php
it is now in cvs and i agree: we should merge the two entries in the plugins database.
Maybe we should add a config page to allow users to change between shortname and fullname. Possibly also give the option of changing the name displayed in the block header.
Could you give me write access to the CVS repository? I already have a SourceForge account (username: marktyers). As soon as I can edit the code I will pull the duplicate entry in the Modules database. Might be worth updating the screenshot and the block name (just call it the marking block).
If you need to get in touch my email is firstname.lastname@example.org
for the cvs access, i think you need to email Martin Dougiamas directly:
Once you have a working Sourceforge account, contact Martin Dougiamas so he can set up your account with write access to particular Moodle directories
Please don't do that. Use the same directory as before:
If you want to have different versions, then use the branches, they are the same as the ones for the core Moodle (MOODLE_18_STABLE, MOODLE_17_STABLE) etc.
These get packaged up automatically for download like this:
and so on.
I've deleted the new directory and moved the new files to the old directory on HEAD and MOODLE_18_STABLE for you.
I've been using the older marking block and the ungraded block . We couldn't enable ajax because it conflicted with activity locking, but we've since given up on keeping AL running (and will wait impatiently for moodle 2.0). So we're using the ajax_marking block now and love it!
Unlike allot of users, however, we would like admin to be able to see all ungraded work across all courses. Since we're a smaller, self-paced K-12 school, we don't have 100s (1000s!) of items to grade at a time (at least not yet! *lol*)
Is there a snippet of code I can add or change that would enable this? (like anything's that simple.) I tried looking at the differences between before and after admin view changed, and even tried a few things, but didn't get anywhere, likely because the ajax is considerably different (or more likely because I don't know php *lol*).
Thanks for any suggestions!
yes there is a reasonably simple way of doing this, but it will requires changes in a few places.
- get_my_courses() has an adminseesall check which needs altering
- the SQL statements check to see if the user is a teacher in any of the courses
- the permissions check has an adminseesall check of some sort
I need a help..How can i get the marked assessment...?? I mean in which table?
I need to create a view of marked assessment for the day or within the dates like..so need to know in which table is saving...
this is great! I'd been so missing the old marking block that I started writing a new one myself, not realising you were doing the same!
I've taken a more long winded approach and have a working AJAX implementation for assignments, but its a bit messy at the moment. I'll tidy up the code and post in a day or so. Its all java with no PHP fallback, so I think it would integrate nicely.
Has anyone resolved the oproblems with this block?
I am keen to use it... with Moodle 1.8
Firstly - thanks for developing what is an important block!
However, we have experienced some issues which I would like to share.
1. This year we have used the 'restore' function to 'wipe clean' our courses. However, I wasn't aware that restoring the course doesn't remove all the files submitted that year. Therefore, any pieces of work not marked from the previous year now show up in that block.
2. Quizzes. It seems to show a huge list of quiz attempts which seems unnecessary and clutters the front page. Any way around this?
3. The marking block displays short course name, whereas we would rather have the course title.
I was hoping to see some settings in the blocks>marking section but can't seem to see any.
Hopefully these are resolvable and any help would be greatly appreciated!
i've now turned AJAX on but there is still a huge list of assignments (quizzes).
Does the block need to be reinstalled? Is it a different download to the marking.zip block?
EDIT: I figured doing a search for 'ajax marking block' would help - and it did!
I have a role (cloned and modified on the Non-editing Teacher Role) that allows teachers in our system view but not grade all other courses on our system. This is so they can assist students using our realtime video-conferencing solution, Marratech.
In Moodle 1.8, all I needed to do was to Prevent ... Grade Assignments and the marking block did not display courses (with unmarked assignments) other than their own.
This changed in Moodle 1.9 beta and I prevented the following, in addition to Grade Assignments:
- Rate Posts
- Manage graded items
- Edit Grades
- Manage Quizzes
- Grade quizzes manually
It appears to work ok. Does this sound like the right combination of permissions to modify for this role? (I'm thinking I might get by with only
- Grade Assignments
- Rate Posts
- Edit Grades
- Grade quizzes manually
The capabilities it checks for are:
Attached is a snapshot of the menu items for the admin fir both moodle 1.8.3 and 1.9b2 (both latest CVS builds). The 1.8.3 dataset was cloned and updated to work with the 1.9b2 install.
The admin does have the "can do anything" capability and all courses show up in both versions. but the marking block only shows up in 1.9b2. It might have something to do with the new capabilities as mentioned above.
Have a good weekend.
I also noticed that when the admin logs in as a student, the marking block appears with the horray message.
I'm using this with 1.8.2, hosted with siteground.
Any ideas or help welcome!
I'm running Moodle 1.8.2+, with Marking Block version 31/07/07.
The block appears to run correctly, showing all assignments that are ungraded. However, when I click on an assignment to grade it, I receive the following error message: "A required parameter (d) was missing".
Any clue what may be causing this? Any help is appreciated!
Any ideas what I should try to fix this problem? Any help or suggestions would be greatly appreciated.
$url = $CFG->wwwroot.'/mod/forum/discuss.php?d=' . $discussion->id; // fixed
That should fix the forums segment of the marking
I've installed the block on a 1.9.1 version and a 1.9.2 clean version and I cannot get the block to work. It shows me the endless spinning wheel (the data in brackets seems correct though).
Is there anything I need to do?
A few things have changed this my last post so I feel that I need to rephrase: for some completely unexplained reason, the block started working a couple of days after I installed it. I suppose there was a massive issue of caching/proxy or something in the like.
In short, I have managed to get the block to successfully work but there is still one issue as in it won't display the "essay" type questions (spinning wheel issue). I have notified the creator of the block and he is looking into the issue.
I think this block works very well (apart from this glitch) and I have tested it in Safari for Mac, Firefox 2 and 3, IE6 and 7 and it works fine in all these. I also tested it on Linux and Mac versions of Firefox. I have not tested it on Opera, Chrome or any other browser, but it covers the bulk of things.
When the essay question type works, this block will be a must have in all installations IMHO
Hope this helps.
The block seems to work OK in FF and Chrome. It does not display the teachers courses at all in IE.
It also does very strange things when you click the configure button...which kind of dissappear if you refresh the page.
Even in FF and Chrome it does not seem to pick up all the teachers courses.
Oh, and we get the "This block has not been implemented correctly and thus cannot provide a configuration interface" error...
Any ideas please?
Do you mean posts that the teacher viewing the block has made themselves, or the posts of other teachers in the same course?
Also, are your teachers in the 'teacher' role, or have you got a custom role for them?
sorry for the delay - I didn't see this post. The block works for me in IE, including the configure link, so I need some more information in order to reproduce the issue. Could you tell me:
- What version of IE you're using
- what version (exact number e.g. 2007100101) from the admin->notifications screen
- What version of the block you're using (admin->modules->manage blocks)
- A screenshot of what goes wrong
Feel free to message me directly if you have any questions.
I am after a report which will tell me the progress or the total of each teachers marking habbits.
I want to know how much marking teacher a has done in a specific time period?
Is there a report out there for this?
But now i found an error in the marking block not in ajax marking, like if i have added a assignment as student and logged in as admin and i can see the assignment came in marking and showing in marking block as Submit Assessment (1).
But after that i have logged in as student and i have deleted the submitted assignment.
And i have logged as admin. I thought like the marking block will not show the deleted assignment count in marking block. But its still there.
I have checked the database and found that while deleting the submitted assignment the entry from the assignment_submission table is not deleting instead its updating the row of the table. its updating the modified time in table. So its again showing in marking block.
I'm having a problem that I can't seem to remedy with the Marking block. I gave several quizzes that had random questions that required manual grading. I graded all the responses for each question but the quiz questions are still showing on the Marking Block as open and needing grading. I don't know what I'm doing wrong. Any suggestions?