Feedback

Andreas,

With the patches I sent you, we began giving course evaluations. One problem that came up was teachers could not view which students submitted even though the data was in the mdl_log table. This was because the cmid (course module id) was not being added. To correct this I changed line 118 of the /mod/feedback/complete.php file from:

add_to_log($course->id, "feedback", "submit", "view.php?id=$cm->id", "$feedback->name");

to:

add_to_log($course->id, "feedback", "submit", "view.php?id=$cm->id", "$feedback->name",$cm->id,$userid);

This explicitly passes the course module and userid. I was able to use SQL to fill in the cmid since it was being stored in the URL with an

UPDATE mdl_log
SET cmid=replace(url,'view.php?id=','')
WHERE module='feedback' AND action='submit' AND cmid=0;

For similar reasons, I would recommend updating line 41 in /mod/feedback/delete_completed.php to:

add_to_log($course->id, "feedback", "delete", "view.php?id=$cm->id", "$feedback->name",$cm->id);

and line 39 of /mod/feedback/view.php to:

add_to_log($course->id, "feedback", "view", "view.php?id=$cm->id", "$feedback->name",$cm->id);

I hope this helps. I think it will make it more functional.

Peace - Anthony