Moodle in English: Assigning an issue to self and adding branch on the tracker

Assigning an issue to self and adding branch on the tracker

by Abhijeet Viswa - Friday, February 5, 2021, 8:05 PM

Hi there!

I though I'd give fixing MDL-64255 a try. I made pushed my changes to a branch on my fork on GitHub. However, I have no clue how to add the branch to the issue or how to even assign the issue to myself. I do not see a obvious "Assign to myself" button or a button to edit the issue.

I believe this might be due to invalid permissions. But I'm not sure what I must do to get required permissions. Any help would be appreciated.

Thanks.

PS: I would also love to have my branch reviewed as well.

Re: Assigning an issue to self and adding branch on the tracker

by Davo Smith - Friday, February 5, 2021, 10:49 PM

You can't assign a ticket to yourself until you are a member of the "Developers" group in tracker: https://docs.moodle.org/dev/Tracker_guide#Tracker_groups_and_permissions

You will need to comment on tickets you've worked on and include a link to the branch in github where you've made the changes. Once you've had a commit integrated, you should be automatically added to "Developers"

Average of ratings:Useful (1)

Re: Assigning an issue to self and adding branch on the tracker

by Ilya Tregubov - Friday, February 5, 2021, 10:53 PM

Hello,

Just copying here infor from the tracker in case other will search for the same question.

The information about submitting a patch or developing a new feature is available at https://docs.moodle.org/dev/Process#New_feature_development and https://docs.moodle.org/dev/Process#Fixing_a_bug

Request peer review button and Edit button become available only when your first issue has been integrated (you will be added to developers group - https://docs.moodle.org/dev/Tracker_guide#Tracker_groups_and_permissions). So for your first issue you will need to ask someone with relevant access to fill necessary fields for you and submit your patch as well (can be either HQ member or anyone who has submitted patch before)

Thanks,

Ilya

Average of ratings:Useful (2)

Re: Assigning an issue to self and adding branch on the tracker

by Abhijeet Viswa - Saturday, February 6, 2021, 12:23 AM

Once again, thank you for your reply and editing the issue for me.

Being a first time contributor, I find this to be extremely convoluted and daunting to make anew patch. New developers will not know existing developers or HQ members. Further more, the Process page does not mention anything about this system. And I doubt first time contributors will read through pages upon pages of the documentation to figure out how to make a patch.

I think a good in-between is to make all new members of the tracker a "contributor" by default and letting them edit an issue while allowing only developers to request a code review from HQ or leads. This should also help cut down on any code review spam (if that was ever an issue to begin with).

Average of ratings: -

General developer forum

Assigning an issue to self and adding branch on the tracker