Adaptable 3.0.3 Logo and header issue?

Adaptable 3.0.3 Logo and header issue?

by Alessio Ceccherelli -
Number of replies: 15

Hi all.

First of all thank you for your great theme. I write here because with the last update to versione 3.0.3 (on a Moodle 3.9.3 installation) I noticed two possible issues:

  • the logo is no more aligned on left but it is quite in the middle (fig 1);
  • I cannot see the background image in the header (If I put transparent as color in headerbkcolor, I get a white header): it seems like the system cannot get the image where it has been uploaded (fig 2);

Before this upgrade everything worked fine, and I don't know if I have to change some settings somewhere or if it could be a possible bug.

Thanks for you eventual support.

Best,

A.




Average of ratings: -
In reply to Alessio Ceccherelli

Re: Adaptable 3.0.3 Logo and header issue?

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers
Bug.
Average of ratings: -
In reply to Gareth J Barnard

Ri: Re: Adaptable 3.0.3 Logo and header issue?

by Alessio Ceccherelli -

Thank you for your quick answer and for your work, Gareth.

Now I know that I have to intervene on the css or to wait for an update.

Best,

A.


Average of ratings: -
In reply to Alessio Ceccherelli

Re: Ri: Re: Adaptable 3.0.3 Logo and header issue?

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers
Patch: https://gitlab.com/jezhops/moodle-theme_adaptable/-/commit/548cd700ce7c0100a15168bc5f9884c23334ccee
Average of ratings: -
In reply to Gareth J Barnard

Re: Ri: Re: Adaptable 3.0.3 Logo and header issue?

by Humano 360 -

thanks but not work for me when I disable the site title

Average of ratings: -
In reply to Humano 360

Re: Ri: Re: Adaptable 3.0.3 Logo and header issue?

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers
Dear Humano 360,

Can't reproduce.

Gareth
Average of ratings: -
In reply to Gareth J Barnard

Re: Ri: Re: Adaptable 3.0.3 Logo and header issue?

by Humano 360 -
Can you attach your Json default theme settings? I would like to compare both, thanks you very much
Average of ratings: -
In reply to Humano 360

Re: Ri: Re: Adaptable 3.0.3 Logo and header issue?

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers
Dear Humano 360,

No, but if you supply your JSON export then I'll look at it, if it replicates the issue for me then I'll be in a position to fix it. If you compare them, you'll only end up having to tell me what the changes are, I'll then have to manually change them (all) and attempt to replicate so I can fix the problem = longer process.

Gareth
Average of ratings: -
In reply to Gareth J Barnard

Ri: Re: Ri: Re: Adaptable 3.0.3 Logo and header issue?

by Alessio Ceccherelli -

Thank you so much, Gareth!

All the best

A.

Average of ratings: -
In reply to Alessio Ceccherelli

Re: Ri: Re: Ri: Re: Adaptable 3.0.3 Logo and header issue?

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers
Dear Alessio,

No problem, was my code fault which is why I rectified it so quickly.

Gareth
Average of ratings: -
In reply to Gareth J Barnard

Re: Ri: Re: Ri: Re: Adaptable 3.0.3 Logo and header issue?

by Andrew Molteno -

Hi

Adaptable theme 3.0.3 on Moodle 3.9.3, with above patch applied to left align site logo.

Issues being experienced after updating to 3.0.3:

  1. The site title is still right aligned
  2. When site title changes to course title the font color changes to #fff
  3. Within a course, when clicking the Topic (using onetopic), the site header disappears (page scrolls down automatically so the nav bar is at the top of the page).

Are there settings I may have missed?

Many thanks

Andrew


Average of ratings: -
In reply to Andrew Molteno

Re: Ri: Re: Ri: Re: Adaptable 3.0.3 Logo and header issue?

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers
Dear Andrew,

  1. Intentional as looks well strange otherwise with the logo on the left and the title somewhere in the middle of the header.
  2. This is due to '49. Fix 'fonttitlecolorcourse setting not used' - #154.' - so functionality that was there but not actually working, but is now.
  3. This is to do with the OneTopic course format and not the theme.
Gareth
Average of ratings: -
In reply to Gareth J Barnard

Re: Ri: Re: Adaptable 3.0.3 Logo and header issue?

by Alexei Gurianov -
if i use header style with 2 row don't display logo,
I found error in headerstyletwo.mustache
41 {{#sitetitle}}
42 {{#sitelogo}}{{{sitelogo}}}{{/sitelogo}}{{{sitetitle}}}
43 {{/sitetitle}}

i fixed this
41 {{#sitelogo}}
42 {{#sitelogo}}{{{sitelogo}}}{{/sitelogo}}{{{sitetitle}}}
43 {{/sitelogo}}
Average of ratings: -
In reply to Alessio Ceccherelli

Re: Adaptable 3.0.3 Logo and header issue?

by Eugene Yascov -

The same thing with 2.4.2 on moodle 3.8.4+. Planing to rolling back to 2.4.1


Attachment scr_065.png
Average of ratings: -
In reply to Eugene Yascov

Re: Adaptable 3.0.3 Logo and header issue?

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers
Adaptable 3.0.3 and 2.4.2 are functionally the same, thus any fixes that I make in the M3.9 version will go in the M3.8 version. So versions 3.0.4 and 2.4.3 will have them.
Average of ratings: -