Adaptable 3.0.0 (release candidate) for Moodle 3.9 released

Adaptable 3.0.0 (release candidate) for Moodle 3.9 released

by Gareth J Barnard -
Number of replies: 18
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Hello,

I've released Adaptable 3.0.0 for Moodle 3.9: https://moodle.org/plugins/pluginversion.php?id=22437.

Please be aware that this is a 'release candidate' version and may still contain unexpected bugs.  There are a 'lot' of fixes!  All being well, there will be a 2.2.3 version for Moodle 3.6 to 3.8 with them released soon too.  This version is not designed to work on M3.8 or less.  The changes are:

  1. Fix licence from GPLv2 to GPLv3 as is incorrect - Moodle plugins must be GPLv3.
  2. Fix message drawer closure.
  3. Fix 'Regression - Frontpage marketing blocks don't display on desktop' - #139.
  4. Moodle 3.9 New Activity Chooser styling needs work - #131.
  5. Fix 'Blocks - My Home recently accessed course' - #9.
  6. Fix rubic icons -> https://moodle.org/mod/forum/discuss.php?d=408081#p1646693.
  7. Fix 'Searchbox conflict with Advanced Forum (hsuforum)' - #133.
  8. Fix 'Bullet list display in Collapsed Topics course format' - #81.
  9. Fix 'Block settings are left justified' - #82.
  10. Improve 'Improve Onetopic course format tab rendering' - #115.
  11. Fix 'Missing action menu (like editing button / cog button) on content bank page' - #140.
  12. Fix 'Button/link 'Turn editing on' missing on Moodle 3.9' - #129.
  13. Fix '.btn declaired after .hidden' - #130.
  14. Fix message drawer hover.
  15. Improve position of #82.
  16. Make 'side-post' have no padding on the right so that the page is symmetrical.
  17. Fix 'H5P iframe element too small in content bank page' - #146.
  18. Fix 'Navbar Custom Menu does not fit' - #128.
  19. Fix 'Editing cog colour not consistent' - #149.
  20. Fix 'Whitespace Below Header in Course Pages' - #38.
  21. Fix 'Use of "$setting->set_updatedcallback('theme_reset_all_caches');" not needed on some settings' - #25.
  22. Fix 'lib.php preg_match logic flaw' - #150.
  23. Fix 'wrong rtl css' - #142.
  24. Fix 'Impossible to enter a course with Coventry tiles' - #156.
  25. Update to version 3 https://moodlehq.github.io/moodle-plugin-ci/UPGRADE-3.0.html - #158.
  26. Assignment with restricting grouping shows all users or groups - #161.
  27. Fix 'Regression? / Inconsistent cog positioning in content bank' - #166.
  28. Fix 'Quiz attempt: no breadcrumbs' - #123.
  29. Fix '$fontname can never be 'custom'' - #104.
  30. Implement 'Update google fonts list ' - #42 - thanks to 'Sal Zaydon' - https://gitlab.com/szaydon for the list.
  31. Fix no such font-family as 'default' - #42.
  32. Fix 'Topic header text now black' - #167.

Please use this thread to report issues with this release ONLY.

If you find this post useful, then please mark it so.

Gareth

Average of ratings: Useful (2)
In reply to Gareth J Barnard

Re: Adaptable 3.0.0 (release candidate) for Moodle 3.9 released

by Eugene T. -
Hello, Gareth!
Thanks for new version of Adaptable.
I've just updated to 3.0.0 on Mdl3.9.

And now we have an exception on main page "Too few arguments to function theme_adaptable_core_renderer::render_mycourses(), 0 passed in [dirroot]/lib/outputrenderers.php on line 497 and exactly 1 expected"

Exception
Average of ratings: -
In reply to Eugene T.

Re: Adaptable 3.0.0 (release candidate) for Moodle 3.9 released

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers
Ok, this is a bug in code I've written, so: https://gitlab.com/jezhops/moodle-theme_adaptable/-/issues/172 - in the mean time, remove 'Enrolled courses' from 'frontpageloggedin' core setting.
Average of ratings: -
In reply to Gareth J Barnard

Re: Adaptable 3.0.0 (release candidate) for Moodle 3.9 released

by Eugene T. -
Thank you for your support!
Hope for a quick bug fix.
Average of ratings: -
In reply to Eugene T.

Re: Adaptable 3.0.0 (release candidate) for Moodle 3.9 released

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers
Fix is this: https://gitlab.com/jezhops/moodle-theme_adaptable/-/commit/8e925a6818228fb073054547fc8a49e04a7b23ef - feel free to patch you code at own risk. I won't do a release just for this as the version is 'release candidate' and there is a viable workaround.
Average of ratings: -
In reply to Gareth J Barnard

Re: Adaptable 3.0.0 (release candidate) for Moodle 3.9 released

by Eugene T. -
It's Ok. I will try to patch. Thanks!

There is one more problem. Navigationbar has dissapeared from main page. On course pages or categories it's on it'splace.
Average of ratings: -
In reply to Eugene T.

Svar: Re: Adaptable 3.0.0 (release candidate) for Moodle 3.9 released

by Fredric Larsen -

Same for me!

- Navigationbar has dissapeared from main page.

Average of ratings: -
In reply to Fredric Larsen

Re: Svar: Re: Adaptable 3.0.0 (release candidate) for Moodle 3.9 released

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers
RE: Navigationbar has dissapeared from main page.

Main page? Moodle has a 'front page' and a 'dashboard' but not a 'main page'. Screenshots please + I believe I'm going to need your settings exported (JSON) - please remove personal info before posting.
Average of ratings: -
In reply to Gareth J Barnard

Re: Svar: Re: Adaptable 3.0.0 (release candidate) for Moodle 3.9 released

by Eugene T. -
Sorry for the misunderstanding because of translation (in RU translation we have "main page")

NavBar is present on all contexts (dashb, courses & etc)... except...

Dash

...frontpage context (after authentication)

Front
Average of ratings: -
In reply to Eugene T.

Re: Svar: Re: Adaptable 3.0.0 (release candidate) for Moodle 3.9 released

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Umm... silly question....  Why would you have a navbar on the front page containing one item being a link to itself?  Boost does not have a navbar on the front page.

Average of ratings: -
In reply to Gareth J Barnard

Svar: Re: Svar: Re: Adaptable 3.0.0 (release candidate) for Moodle 3.9 released

by Fredric Larsen -
When a user logs in, he vill be directed ti the frontpage and if there is no navbar, he would have some difficulties to find courses etc. And it worked in the previous version.
Average of ratings: -
In reply to Fredric Larsen

Re: Svar: Re: Svar: Re: Adaptable 3.0.0 (release candidate) for Moodle 3.9 released

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

??? There is no navbar on the M3.8 version (2.2.2) either.  And the navbar / breadcrumb does not show courses anyway....

Oh, wrong element.  Navbar is showing for me.  What's the value of 'headerstyle' setting please?

Average of ratings: -
In reply to Gareth J Barnard

Re: Svar: Re: Svar: Re: Adaptable 3.0.0 (release candidate) for Moodle 3.9 released

by Eugene T. -
style2
Average of ratings: -
In reply to Eugene T.

Re: Svar: Re: Svar: Re: Adaptable 3.0.0 (release candidate) for Moodle 3.9 released

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Ok, there was a fix for the secure browser etc. for not showing the navbar.  For some past reason in config .php for the theme has:

    // The site home page.
    'frontpage' => array(
        'file' => 'frontpage.php',
        'regions' => $regions,
        'defaultregion' => 'side-post',
        'options' => array('nonavbar' => true),
    ),

so just change to:

    // The site home page.
    'frontpage' => array(
        'file' => 'frontpage.php',
        'regions' => $regions,
        'defaultregion' => 'side-post'
    ),

to solve the problem.

Average of ratings: -
In reply to Gareth J Barnard

Re: Svar: Re: Svar: Re: Adaptable 3.0.0 (release candidate) for Moodle 3.9 released

by Eugene T. -
That's it! smile)
Average of ratings: -
In reply to Gareth J Barnard

Re: Svar: Re: Adaptable 3.0.0 (release candidate) for Moodle 3.9 released

by Eugene T. -
In previous version authenticated user had navbar in all contexts including frontpage. For non-authenticated user as you said navbar make no sense.
Average of ratings: -
In reply to Eugene T.

Re: Svar: Re: Adaptable 3.0.0 (release candidate) for Moodle 3.9 released

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

My bad.  Can replicate, will look into it.

Average of ratings: -
In reply to Gareth J Barnard

Re: Adaptable 3.0.0 (release candidate) for Moodle 3.9 released

by John Dougherty -

Hi there,

I've been having a look at this candidate release and which has been pretty smooth so far for myself, however I've run into a little issue which I can't quite seem to figure out. Whenever I make a selection from the Navbar e.g. select "Home" I have a blue border that appears around the selection of the item.

This also appears on the top header when even I selected the profile name or an item from the drop down menu. Here are 2 example screenshots of what's happening:


Border example 1 Border example 2


Any idea how I may remove this border at all?

Thanks very much in advance

John


Average of ratings: -