Themes

I meant to add - when I switch Adaptable's base theme to Bootstrap (based on BS3), the events all work. Looks awful, obviously, but...

Interesting, if I follow your instructions Nick in the Clean theme, then it works, but the 'Block user' and 'Remove from contacts' buttons don't have their text, so a bug in that respect but the buttons do appear.

Is the attached in 'Clean' what you see to for the 'Info' on a contact?

The drawer by itself is working well with BS2, open and close, but that's all. The features are not working well because the drawer is styled and using BS4.

That is really crazy and breaks the use of BS2 themes (all of them) in the new moodle 3.6 version. Looks like Moodle HQ is taking, again, its own path without explain first to theme developers (the change was no advertised and no documented until a few days before release 3.6) and decided use a mix of styles that are really difficult to manage (some classes are overwritten several times). Add new styles to fit the message drawer to Adaptable was a nightmare due the bad coding used.

And the worse is that nobody test it before release it. Nobody thought that the drawer functions are not working in BS2 (that also includes Clean)? Nobody test it before that you forced to publish 3.6.1 and soon 3.6.2 because the message drawer IS NOT WORKING in BS2?

So we have again a new crap made in Moodle HQ. Congratulations guys. For moodle 3.7, please use BS5, doesn't matter if it is still a project. Go ahead.

Hi Niall,

Is the new version you mean by MDL-64419?  If so then given the dates then this will have been over the holiday season and even developers need holidays!  If you're that desperate you could patch your own version of Moodle in around three minutes or less with the one line fix specified on the tracker issue.  That's the beauty of open source software, you can be proactive.

Fighting?  What fighting?

G

I believe this message comes from the following code (the first if block).
It looks like the call to can_create_contact() fails for some reason. Maybe your user or role has no capability of some sort?

File: message/externallib.php

if (!\core_message\api::can_create_contact($params['userid'], $params['requesteduserid'])) {
    $result['warnings'][] = [
        'item' => 'user',
        'itemid' => $params['requesteduserid'],
        'warningcode' => 'cannotcreatecontactrequest',
        'message' => 'You are unable to create a contact request for this user'
    ];
} else {
    if ($requests = \core_message\api::get_contact_requests_between_users($params['userid'], $params['requesteduserid'])) {
        // There should only ever be one but just in case there are multiple then we can return the first.
        $result['request'] = array_shift($requests);
    } else {
        $result['request'] = \core_message\api::create_contact_request($params['userid'], $params['requesteduserid']);
    }
}

Edit:

And indeed it very much may be a problem with configuration. Could you please check if you have messaging enabled? And if both users are sharing the same course?

File: message/classes/api.php

/**
 * Checks if a user can create a contact request.
 *
 * @param int $userid The id of the user who is creating the contact request
 * @param int $requesteduserid The id of the user being requested
 * @return bool
 */
public static function can_create_contact(int $userid, int $requesteduserid) : bool {
    global $CFG;

    // If we can't message at all, then we can't create a contact.
    if (empty($CFG->messaging)) {
        return false;
    }

    // If we can message anyone on the site then we can create a contact.
    if ($CFG->messagingallusers) {
        return true;
    }

    // We need to check if they are in the same course.
    return enrol_sharing_course($userid, $requesteduserid);
}