General developer forum

Contribution does not show up as pull request in repo?

 
Picture of Eva E
Contribution does not show up as pull request in repo?
 

Hello,

I recently contributed to https://tracker.moodle.org/browse/MDL-60014 and the fixes were pulled from my repository. I was expecting to see these as "pull requests" in my repo however I am not seeing that. Did I miss anything or are you not supposed to see Moodle contributions in your pull requests?

Thanks for any clarifications.

 
Average of ratings: -
Davo
Re: Contribution does not show up as pull request in repo?
Core developersParticularly helpful MoodlersPlugin developers

Where would you expect these "pull requests" to appear in your repo?

If you look at the latest Moodle code, you should see your commits appearing in there.


 
Average of ratings: -
Picture of Michael Aherne
Re: Contribution does not show up as pull request in repo?
Core developersParticularly helpful MoodlersPlugin developers

If you mean the "pull requests" tab in Github, that's not used in the Moodle process at all, so you wouldn't see it in there. (If it was used, you'd see it in the core Moodle repo anyway, not your own!)

Your code's definitely in core: https://moodle.org/dev/gitcommits.php?version=x.x.x&userid=2314061&merges=0


 
Average of ratings: -
Picture of Eva E
Re: Contribution does not show up as pull request in repo?
 

Thanks for your reply. I do know that it is in core, I was just wondering if there was any place in my GitHub that would reflect that. I was misunderstanding the pull requests tab. Thanks for clarifying. 

 
Average of ratings: -