Since Moodle 3.5 bootstrap carousel is broken

Since Moodle 3.5 bootstrap carousel is broken

by Andreas Grabs -
Number of replies: 4
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Peer reviewers Picture of Plugin developers Picture of Translators

Hi,

since bootstrap 4 the scssphp compiler breaks on some parts if the bootstrap is used unmodified. In moodle 3.5 two files from bootstrap has been modified. The modification is just a comment mark on the problematic lines.

Because there isn't a note anywhere it took me hours to find the reason why I didn't get carousel which run correctly.
To solve this I readded the removed parts in the css representation. With that the compiler did the job right.

If someone is intrested in solving this issue please have a look here:

https://tracker.moodle.org/browse/MDL-61515

Thanks!

Best regards
Andreas

Average of ratings: Useful (1)
In reply to Andreas Grabs

Re: Since Moodle 3.5 bootstrap carousel is broken

by Thomas Hucke -

Hi Andreas.

Using Moodle 3.5+ Build 20180614 I have the same problem, Bootstrap 4 carousel is not moving. I modified the file moodle/theme/boost/scss/bootstrap/_carousel.scss according the the suggestions in the link but nothing changed. Do I have to do anything else beside of just changing this scss file?

Vielen Dank für eine Antwort.

Best regards,

Thomas.

Average of ratings: -
In reply to Thomas Hucke

Re: Since Moodle 3.5 bootstrap carousel is broken

by Mary Evans -
Picture of Core developers Picture of Documentation writers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

Hi,

What code are you adding in to display the Carousel in the first place?

Have you added any extra CSS/SCSS in

Site Administration > Themes > Boost > Advanced settings > Raw SCSS

If not then try adding this and see if it helps?

/* CUSTOMIZE THE CAROUSEL
-------------------------------------------------- */

/* Carousel base class */
.carousel {
  margin-bottom: 4rem;
}
/* Since positioning the image, we need to help out the caption */
.carousel-caption {
  z-index: 10;
  bottom: 3rem;
}

/* Declare heights because of positioning of img element */
.carousel-item {
  height: 32rem;
  background-color: #abc;
}
.carousel-item > img {
  position: absolute;
  top: 0;
  left: 0;
  min-width: 100%;
  height: 32rem;
}

Average of ratings: -
In reply to Thomas Hucke

Re: Since Moodle 3.5 bootstrap carousel is broken

by Andreas Grabs -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Peer reviewers Picture of Plugin developers Picture of Translators

Hi Thomas,

you have to clear the cache so the css is built again.
Btw. there is a fix coming up for moodle 3.5. It should be in the next release (I hope so).

Best regards
Andreas

Average of ratings: -
In reply to Andreas Grabs

Re: Since Moodle 3.5 bootstrap carousel is broken

by Jorge Huete -

I purged caches and I solved the problem with move of carousel but my problem now is the carousel dont have some animation when slide images.

The animation of move of my carousel is instant. I don't know what do I do. 


In moodle 3.4.3 works but in moodle 3.5 and 3.5+ not. I'm testing in Boost theme.

Helps pls. 

Best regards,

Jorge Huete

Average of ratings: -