Waxed and Handlebar theme updates

Waxed and Handlebar theme updates

by Richard Oelmann -
Number of replies: 10
Picture of Core developers Picture of Plugin developers Picture of Testers

Waxed and Handlebar have now both had the privacy api (nullprovider) added.

They are available on github now, but will be added to Moodle database as Moodle3.5 stable versions later today after some further minor improvements (replacing bootstrap4Alpha with BS4Stable where required) and testing.

https://github.com/roelmann/moodle-theme_waxed

https://github.com/roelmann/moodle-theme_handlebar

Average of ratings: Useful (1)
In reply to Richard Oelmann

Re: Waxed and Handlebar theme updates

by Richard Oelmann -
Picture of Core developers Picture of Plugin developers Picture of Testers
In reply to Richard Oelmann

Re: Waxed and Handlebar theme updates

by Przemek Kaszubski -
Picture of Particularly helpful Moodlers Picture of Testers

Hello,

I have installed and then updated both Waxed and Handlebar for testing etc. on a localhost Moodle 3.5.1. Ever since the latest update of Waxed in early July I have not been able to get passed this screen.  It's prompting me to accept options which are not there, so I click save changes and the page just reloads. I cannot use the Notifications page. 

Purging the caches has not helped.




I wonder if this is a known issue and what I could do besides uninstalling. 

Thanks and kind regards,

Przemek


In reply to Przemek Kaszubski

Re: Waxed and Handlebar theme updates

by Richard Oelmann -
Picture of Core developers Picture of Plugin developers Picture of Testers

No, its not a known issue - haven't come across it before.

Just for clarity though - that screen is showing new settings for both Handlebar and Waxed, but you say this only happened since the last update of Waxed?


OK, just tested and unable to replicate on my laptop.

However, please can you also confirm what version of PHP you are using - I have had reports of issues around PHP7.2  But I have not yet had chance to upgrade my systems beyond 7.0 and do any testing.


If you are using PHP beyond that, please enable debugging and let me know what errors there are - I'll try to look into them as and when I have opportunity.


Richard

In reply to Richard Oelmann

Re: Waxed and Handlebar theme updates

by Przemek Kaszubski -
Picture of Particularly helpful Moodlers Picture of Testers

My PHP is PHP Version 7.1.10. I'm testing this Moodle instances and plugins on a local Windows installation.  Silly me. should have turned on debugging at once. Here's the listing - apparently looping through the presets does not work correctly, and the drop-down form is not printed, so I can't save the settings etc.

Warning: Illegal string offset 'cosmo' in D:\Moodle\server\moodle\theme\handlebar\settings\presets_settings.php on line 40

Warning: Illegal string offset 'cyborg' in D:\Moodle\server\moodle\theme\handlebar\settings\presets_settings.php on line 40

Warning: Illegal string offset 'darkly' in D:\Moodle\server\moodle\theme\handlebar\settings\presets_settings.php on line 40

Warning: Illegal string offset 'default' in D:\Moodle\server\moodle\theme\handlebar\settings\presets_settings.php on line 40

Warning: Illegal string offset 'flatly' in D:\Moodle\server\moodle\theme\handlebar\settings\presets_settings.php on line 40

Warning: Illegal string offset 'journal' in D:\Moodle\server\moodle\theme\handlebar\settings\presets_settings.php on line 40

Warning: Illegal string offset 'litera' in D:\Moodle\server\moodle\theme\handlebar\settings\presets_settings.php on line 40

Warning: Illegal string offset 'lumen' in D:\Moodle\server\moodle\theme\handlebar\settings\presets_settings.php on line 40

Warning: Illegal string offset 'lux' in D:\Moodle\server\moodle\theme\handlebar\settings\presets_settings.php on line 40

Warning: Illegal string offset 'materia' in D:\Moodle\server\moodle\theme\handlebar\settings\presets_settings.php on line 40

Warning: Illegal string offset 'minty' in D:\Moodle\server\moodle\theme\handlebar\settings\presets_settings.php on line 40

Warning: Illegal string offset 'pulse' in D:\Moodle\server\moodle\theme\handlebar\settings\presets_settings.php on line 40

Warning: Illegal string offset 'sandstone' in D:\Moodle\server\moodle\theme\handlebar\settings\presets_settings.php on line 40

Warning: Illegal string offset 'simplex' in D:\Moodle\server\moodle\theme\handlebar\settings\presets_settings.php on line 40

Warning: Illegal string offset 'sketchy' in D:\Moodle\server\moodle\theme\handlebar\settings\presets_settings.php on line 40

Warning: Illegal string offset 'slate' in D:\Moodle\server\moodle\theme\handlebar\settings\presets_settings.php on line 40

Warning: Illegal string offset 'solar' in D:\Moodle\server\moodle\theme\handlebar\settings\presets_settings.php on line 40

Warning: Illegal string offset 'spacelab' in D:\Moodle\server\moodle\theme\handlebar\settings\presets_settings.php on line 40

Warning: Illegal string offset 'superhero' in D:\Moodle\server\moodle\theme\handlebar\settings\presets_settings.php on line 40

Warning: Illegal string offset 'united' in D:\Moodle\server\moodle\theme\handlebar\settings\presets_settings.php on line 40

Warning: Illegal string offset 'yeti' in D:\Moodle\server\moodle\theme\handlebar\settings\presets_settings.php on line 40

Warning: natsort() expects parameter 1 to be array, string given in D:\Moodle\server\moodle\theme\handlebar\settings\presets_settings.php on line 52

Warning: Illegal string offset 'cerulean' in D:\Moodle\server\moodle\theme\waxed\settings\presets_settings.php on line 40

Warning: Illegal string offset 'cosmo' in D:\Moodle\server\moodle\theme\waxed\settings\presets_settings.php on line 40

Warning: Illegal string offset 'cyborg' in D:\Moodle\server\moodle\theme\waxed\settings\presets_settings.php on line 40

Warning: Illegal string offset 'darkly' in D:\Moodle\server\moodle\theme\waxed\settings\presets_settings.php on line 40

Warning: Illegal string offset 'default' in D:\Moodle\server\moodle\theme\waxed\settings\presets_settings.php on line 40

Warning: Illegal string offset 'flatly' in D:\Moodle\server\moodle\theme\waxed\settings\presets_settings.php on line 40

Warning: Illegal string offset 'journal' in D:\Moodle\server\moodle\theme\waxed\settings\presets_settings.php on line 40

Warning: Illegal string offset 'litera' in D:\Moodle\server\moodle\theme\waxed\settings\presets_settings.php on line 40

Warning: Illegal string offset 'lumen' in D:\Moodle\server\moodle\theme\waxed\settings\presets_settings.php on line 40

Warning: Illegal string offset 'lux' in D:\Moodle\server\moodle\theme\waxed\settings\presets_settings.php on line 40

Warning: Illegal string offset 'materia' in D:\Moodle\server\moodle\theme\waxed\settings\presets_settings.php on line 40

Warning: Illegal string offset 'minty' in D:\Moodle\server\moodle\theme\waxed\settings\presets_settings.php on line 40

Warning: Illegal string offset 'pulse' in D:\Moodle\server\moodle\theme\waxed\settings\presets_settings.php on line 40

Warning: Illegal string offset 'sandstone' in D:\Moodle\server\moodle\theme\waxed\settings\presets_settings.php on line 40

Warning: Illegal string offset 'simplex' in D:\Moodle\server\moodle\theme\waxed\settings\presets_settings.php on line 40

Warning: Illegal string offset 'sketchy' in D:\Moodle\server\moodle\theme\waxed\settings\presets_settings.php on line 40

Warning: Illegal string offset 'slate' in D:\Moodle\server\moodle\theme\waxed\settings\presets_settings.php on line 40

Warning: Illegal string offset 'solar' in D:\Moodle\server\moodle\theme\waxed\settings\presets_settings.php on line 40

Warning: Illegal string offset 'spacelab' in D:\Moodle\server\moodle\theme\waxed\settings\presets_settings.php on line 40

Warning: Illegal string offset 'superhero' in D:\Moodle\server\moodle\theme\waxed\settings\presets_settings.php on line 40

Warning: Illegal string offset 'united' in D:\Moodle\server\moodle\theme\waxed\settings\presets_settings.php on line 40

Warning: Illegal string offset 'yeti' in D:\Moodle\server\moodle\theme\waxed\settings\presets_settings.php on line 40

Warning: natsort() expects parameter 1 to be array, string given in D:\Moodle\server\moodle\theme\waxed\settings\presets_settings.php on line 52


Thanks,

Przemek

In reply to Przemek Kaszubski

Re: Waxed and Handlebar theme updates

by Richard Oelmann -
Picture of Core developers Picture of Plugin developers Picture of Testers

Hi Przemek,

I haven't had chance to upgrade my PHP yet, but please could you try altering 

waxed/settings/presets_settings.php L34 to

$presetchoices = array();

And the same in handlebar


Richard

In reply to Richard Oelmann

Re: Waxed and Handlebar theme updates

by Przemek Kaszubski -
Picture of Particularly helpful Moodlers Picture of Testers

Hello Richard,

That worked beautifully, no more errors smile

Thanks so much!

Przemek

In reply to Przemek Kaszubski

Re: Waxed and Handlebar theme updates

by Richard Oelmann -
Picture of Core developers Picture of Plugin developers Picture of Testers

Thanks for the confirmation Przemek.

I'll get that changed and pushed out to github and the plugins database as sson as i can.

In reply to Richard Oelmann

Re: Waxed and Handlebar theme updates

by Chris Kenniburg -
Picture of Particularly helpful Moodlers Picture of Plugin developers

This is useful.  I was just watching the video on YouTube about every plugin needing to add this.

In reply to Chris Kenniburg

Re: Waxed and Handlebar theme updates

by Richard Oelmann -
Picture of Core developers Picture of Plugin developers Picture of Testers

If you are not storing user info, then the null provider option is straight forward - a language file entry and copy and paste the provider.php class (with appropriate plugin name changes). Feel free to take the one from Waxed - its basically copied and pasted from a Moodle HQ plugin, so should be the latest requirements.

I haven't yet had to deal with a plugin which does store user info - although I have several in work that I will need to add this to before I complete the 3.5 upgrade in the summer - I've only done the two themes at the moment, and am about to put it into course_contacts (again, no user info stored so its a null provider one).

I know Gareth's Essential has the privacy api applied with a piece of user info stored, so that may be a good one to look at if you need a base to work from that isn't null-provider smile

Average of ratings: Useful (1)
In reply to Richard Oelmann

Re: Waxed and Handlebar theme updates

by AL Rachels -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers Picture of Testers

Hi Richard and Chris,

An easy way to find examples of plugins that do store user info is to go look at your site, Plugin privacy compliance registry. In Moodle 3.4 prior to the current build it is at Site administration > Privacy and policies > Plugin privacy registry. For the latest current build of Moodle 3.4 and the current code for Moodle Beta 3.5 it is located at Site administration > Users > Privacy and policies > Plugin privacy registry.

Anything listed with a + in front of it has some sort of GDPR implementation. Knowing that, makes it easier to go directly to a plugins code to look at an example, instead of hunting through all the plugin folders, one at a time.

Average of ratings: Useful (1)