On 3.3x and 3.4 activities set in stealth mode treats non-editing teacher like a student.
When these activities are set, a non-editing teacher cannot see them (just like a student). This is a problem as the behavior specifically says "students", so only the student role should be impacted. The only workaround I could find was adding the moodle/course:activityvisibility permission for the non-editing teacher. This allows the non-editing teacher to see the stealth activities, but gives them a permission they shouldn't have.
When this is set to allow, this is still a problem because even though non-editing teachers have access to only hide/show activities from the "turn editing on" gear icon, they also have access to do other dangerous stuff if the Mass Actions block happens to be added to the course.
This needs to be fixed. any ideas or do I need to submit as bug?
Normally stealth activities are used when you are linking to the activity from elsewhere. In which case, why does the non-editing teacher need to see them on the course page too? They presumably can access the activity the same way as the student does...
If this isn't the case, you could just add a block with links to the activities that only the non-editing teachers can see...
Well, the non-editing teacher needs to see them because they are the teacher and not the student, lol. There are quite a few cases in which the teacher view should be different than the student. The teacher needs to be able to see everything that is in the course easily without having to follow the exact navigation of the student. This is how it is for the editing teacher. The non-editing teacher should just see what the editing teacher sees:
after all, they are still a teacher!
You say the "non-editing teacher presumably can access the activity the same way as the student does". Yes, the can, but the problem is they shouldn't have to. In our particular situation it is more problematic than it sounds because students only access these stealth activities via the Lesson module. For the teacher to have to navigate to these from the Lesson just to get to it doesn't seem right. Again, the teacher's view should be different.
But you are correct, Emma in saying I could add a block with links as a workaround, but that would be more work as it would have to be added to each course, which we have too many of. We also avoid blocks since we use Boost and have a lot of mobile users.