Adaptable version 1.6.1\H5P Embed - Course presentation

Re: Adaptable version 1.6.1\H5P Embed - Course presentation

by Mary Evans -
Number of replies: 1
Picture of Core developers Picture of Documentation writers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

Can you replicate the same problem using the Clean theme PLEASE, as that is one way to rule out  Adaptable theme and shift the blame on to Moodle.

To do this set your site to use  Allow theme change in URL you will find that setting in the

Site administration > Appearance > Themes > Theme settings page

Thanks

Mary

In reply to Mary Evans

Re: Adaptable version 1.6.1\H5P Embed - Course presentation

by Daniell Goodin -

Thanks both Fernando and Mary for your suggestions as it gives us another avenue to start to track this down. 

I had some success and unfortunate fail on the testing and as usual.. as bit more testing and we are looking good again.. 


Testing done as follows:

Site taken back to Clean theme, caches cleared. 

Problematic activity taken from H5P site for fresh install.. 

https://h5p.org/presentation


Clean theme activity loaded to front page via a hidden block activity. 

Viewed in the block activity is working fine (As are the production site working activities)


We then embed it in to a Post (which is an example of it being embedded in to any lesson or book with in Moodle)

This is what we get.. 


Good news!!!

We find that it happens on Clean theme... 

Now to add in the Custom CSS given from H5P team.. 

/* H5P Course nav fix 06.03.18*/

 

.h5p-course-presentation ol.list-unstyled {

  margin: 0;

}

Good News!!! - we can see we have a fix.. 


Now changing back to Adaptable Theme - 

With Cache cleared, we have the custom CSS added in and at the top of other Custom CSS. 

And we are good to go.. 

So it seems that somewhere along the upgrades of H5P\Presentation and Adaptable Theme updates over the last weeks. 

There needs to be a quick change back to Clean theme and Cache cleared to make sure the Custom CSS sticks. 

Will report back in to the H5P thread on it.. 

Big Thanks to all across the Globe that have helped.. smilesmile