User email display conditions are not very intuitive (request for comments)

User email display conditions are not very intuitive (request for comments)

by David Monllaó -
Number of replies: 3

Hi,

I would like to have some more opinions before moving MDL-60548 forward. The conditions we apply (3.1 onwards) to show/hide someone's email are not very intuitive. At the moment all other conditions are subject to the email being part of the identity fields ('showuseridentity' setting) and this is not ideal because 'Show user identity' setting serves a different purpose (https://docs.moodle.org/34/en/User_policies#Show_user_identity) In MDL-60548 we are trying to find an alternative solution that removes 'showuseridentity' restriction and still allows admins to hide all users email as we currently do through 'showuseridentity' setting. David Balch proposed to add 'email' to 'Hide user fields' setting (https://docs.moodle.org/34/en/User_policies#Hide_user_fields) which sounds ok to me. I've completed his proposal in https://tracker.moodle.org/browse/MDL-60548?focusedCommentId=494663&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-494663. Related issues that would be resolved by this approach are MDL-60191 and MDL-50534.

It would be great to have some feedback about MDL-37479 (deprecate course:useremail capability) and MDL-51630 (combine course:viewhiddenuserfields and user:viewhiddendetails capabilities) as well, both related to user email display.

Average of ratings: Useful (1)
In reply to David Monllaó

Re: User email display conditions are not very intuitive (request for comments)

by Sara Arjona Téllez -
Picture of Core developers Picture of Moodle HQ Picture of Particularly helpful Moodlers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

Hola David!

  • +10000 to your proposal in MDL-60548. For me it has sense and it's the best solution! wink
  • +1 also to deprecate course:useremail capability and fix MDL-51630 to combine correctly course:viewhiddenuserfields and user:viewhiddendetails capabilities.

Thanks for working on this!!! smile

Cheers,

Sara

In reply to David Monllaó

Re: User email display conditions are not very intuitive (request for comments)

by Dave Balch -

Thanks for continuing to drive this issue, David. I'm assuming that the upcoming point release will have the attention of a lot of people, so will come back to it after the update is rolled out.

In reply to David Monllaó

Re: User email display conditions are not very intuitive (request for comments)

by Dave Balch -

I've updated my patch for MDL-60548 based on the feedback, so a peer review would help us tidy this one up...