## General help

### Error on deleting users

Error on deleting users

I have a weird error when deleting users:

Notice: Trying to get property of non-object in /var/www/elo/moodle/lib/grade/grade_grade.php on line 1080

Notice: Trying to get property of non-object in /var/www/elo/moodle/lib/classes/event/grade_deleted.php on line 70

Can not find data record in database table course.

Moodle version is Moodle 3.3.3 (Build: 20171113)

This doesn't happen with all users when clicking the cross in "Browse list of users", but it happens always if I use "Bulk user actions" or "Upload users" with CSV using username and delete fields.

Some users I can't delete at all. So I have the impression there is some data for some users that breaks the delete script. I couldn't find any bugs that look similar. I tried to bulk delete the two users on the demo site and that worked

Has anyone an idea where to start my investigation?

Average of ratings: -
Re: Error on deleting users

Hi Koen,
from https://github.com/moodle/moodle/blob/MOODLE_33_STABLE/lib/grade/grade_grade.php#L1080 and https://github.com/moodle/moodle/blob/MOODLE_33_STABLE/lib/classes/event/grade_deleted.php#L70, it looks like grade_item is not an object, null or probably false (DB table, grade_grades).

The code should check for something like empty() and skip those items.

HTH,
Matteo

Average of ratings: -
Re: Error on deleting users

Thank you for your response Matteo.

It seems like I'm not the only one. In the mean time I found

I used

select * from mdl_grade_grades where itemid not in (select id from mdl_grade_items)

from the tracker issue and found 2084 records on a total of 707849.

I deleted them with

DELETE from mdl_grade_grades where itemid not in (select id from mdl_grade_items)
which was mentioned in the bug.

After running the delete query all was working fine again and I managed to delete the 400 users.

I think your suggested code change would have worked too, but I preferred in this case to clean up the database - it might prevent future problems.

Average of ratings: Useful (1)
Re: Error on deleting users

Koen, I am on Moodle 3.5+ (Build: 20180607)  and this has been happening to me for two years on each and every version, finally I have it resolved, I verified the grades (truthfully unworried as I had reset all my classes for the year) and the bulk cleanup went through after experiencing the error repeatedly both in bulk and individual user deletion.

I appreciate your time posting the steps/solution.

May you have a great summer!

Average of ratings: -