Hi guys, why are modal classes added to confirmation dialogues throughout Moodle 3.2+, when they clearly aren't modals? Or should they be working for me?
Was just wondering if something is wrong with my site, or if this is intentional behaviour.
Theme independent and all down to the 'modal-in-page' class added in MDL-56242 -> https://github.com/moodle/moodle/blame/master/theme/bootstrapbase/less/moodle/admin.less#L199 and https://github.com/moodle/moodle/commit/f2405a5f5c57245d77996b933ff8d60ec5b09561#diff-1d7b1256ccd9fb493559a60c5066be35R204 changing the position from fixed to static and applying a z-index of 0.
Also! What is going on here! There is the property:
margin: 0 auto 0 auto;
when it could be the short form;
margin: 0 auto;
in the modal-in-page class.
I bet there is a rule that says "Moodle Devs do it their way!" LOL
Haha that’s funny. Gonna track this ‘modal-in-page’ class down and see what gives. That’s more than what I’ve discovered.
Hi Daemon,
Did you ever find out anything more regarding this?
I'm not really following what's being said in the previous posts, but we have the same issue on our current site.
"Confirm" popup's/dialog's stretch beyond the width of the screen and the continue/cancel buttons can not be seen/clicked.
Reducing/Resizing the window makes them visible.
Any idea how I fix this?
Hi Simon
No I didn't really get far with this, it seems the modals I was talking about are a feature not yet a part of the Moodle core.
But yes, the dialogues are modals. You shouldn't really be having an issue with these unless you are like me and using a custom.css file? My Essential theme is heavily customised, and occasionally across upgrades I do have some issues, but I just track these down and fix them up.
Are you using a custom stylesheet in your instance? If so, inspect your modal style in Firebug or whatever, track down the problematic code and fix it