PLEASE VOTE | Moodle 3.3 Boost drawer.scss - why hard coded variables?

PLEASE VOTE | Moodle 3.3 Boost drawer.scss - why hard coded variables?

by Urs Hunkler -
Number of replies: 5
Picture of Core developers

The following variables in drawer.scss are hard coded and can't be overwritten by presets. I there a reason why those values shall not be overwritten? I would prefer to be able to change those values in the presets.

$drawer-width: 285px;
$drawer-padding-x: 20px;
$drawer-padding-y: 20px;
$drawer-offscreen-gutter: 20px;

They could be flexible with:

$drawer-width: 285px !default;
$drawer-padding-x: 20px !default;
$drawer-padding-y: 20px !default;
$drawer-offscreen-gutter: 20px !default;

(Edited by Mary Evans - MADE CHANGES TO SUBJECT HEADING - original submission Monday, 22 May 2017, 5:17 PM)

Average of ratings: Useful (1)
In reply to Urs Hunkler

Re: Moodle 3.3 Boost drawer.scss - why hard coded variables?

by Mary Evans -
Picture of Core developers Picture of Documentation writers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

Looks like a it is a candidate for an "Improvement" in Moodle Tracker.

Can you set the wheels turning?

Thanks

Mary

In reply to Urs Hunkler

Re: Moodle 3.3 Boost drawer.scss - why hard coded variables?

by Mary Evans -
Picture of Core developers Picture of Documentation writers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

Just created a tracker issue:

MDL-59080 - drawer.scss variables can not be overwritten by presets.

In reply to Mary Evans

Re: Moodle 3.3 Boost drawer.scss - why hard coded variables?

by Rick Jerz -
Picture of Particularly helpful Moodlers Picture of Testers

Good move, Many.  I just voted for it, even though it looks like it is progressing.  Thanks for posting on Tracker.

Average of ratings: Useful (1)
In reply to Rick Jerz

Re: Moodle 3.3 Boost drawer.scss - why hard coded variables?

by Mary Evans -
Picture of Core developers Picture of Documentation writers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

Hi Rick,

Thanks for voting.

I'm just testing it now and it works really well.

Regards

Mary

Average of ratings: Useful (1)