Multiple languages in the custom menu. Is my contribution a bug fix or a a usability issue?

Multiple languages in the custom menu. Is my contribution a bug fix or a a usability issue?

by Luca Bösch -
Number of replies: 1
Picture of Core developers Picture of Documentation writers Picture of Particularly helpful Moodlers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

To make a long story short: I provided what in my eyes was a bug fix.
The problem being using the custom menu in a multi language Moodle installation.
Moodle version 2.7 shows the custom menu when it was configured with code as instructed in Site administration - Appearance - Theme settings - Custom menu items
Moodle version 2.8 and further stopped showing the custom menu.

I was kindly asked by the Moodle HQ developer John Okely to open this forum thread, which I gladly do, of course.

In my opinion it is not a usability issue, given the same custom menu code triggers different behaviour on Moodle 2.7 versus higher versions.
But I might miss a point.
Also, it is safe to say some other fixes and issues happened in the same field of multiple language custom menu, which may have interfered.

Please share your thoughts here.

Let me append some sources:


German custom menu in Moodle 2.7


German custom menu in Moodle higher than 2.7 with the fix provided in https://tracker.moodle.org/browse/MDL-53224


German custom menu in vanilla Moodle higher than 2.7 (note the missing pull down menu trigger on "Schnellzugriff")



Connected tracker issues:

https://tracker.moodle.org/browse/MDL-46652
https://tracker.moodle.org/browse/MDL-49655
https://tracker.moodle.org/browse/MDL-53224

Previous forum thread: (Thanks Sam Hemelryk, PJ King) https://moodle.org/mod/forum/discuss.php?d=270675

Best regards
Luca


Average of ratings: -
In reply to Luca Bösch

Re: Multiple languages in the custom menu. Is my contribution a bug fix or a a usability issue?

by Richard Oelmann -
Picture of Core developers Picture of Plugin developers Picture of Testers

Query based on my understanding from https://tracker.moodle.org/browse/MDL-53224

the suggestion as i understand it is that the language qualifier is only applied for that specific line, it does not matter what is above or below it in terms of sub-links etc.

OK then what would happen if there is no level 1 menu in that language, but there are sub-levels in a specified language - eg.

The Menu|||en
-English1|/page1.php?lang=en||en
-Français1|/page1.php?lang=fr||fr
-English2|/page2.php?lang=en||en
-Français2|/page2.php?lang=fr||fr

What would now happen to the French items in the above example? The top level menu would not be displayed if French was selected, so presumably they wouldn't be displayed anywhere, but is that something the code needs to specifically address or is it just assumed behaviour and is it the behaviour that users would expect (I think it probably is what people would expect). If the code does not specifically address it, could it cause an error in the custom menu system?

R


Average of ratings: Useful (1)