Clean and more logos

Clean and more logos

by David Monllaó -
Number of replies: 2

Hi,

Some of you may have updated to 2.8.8 or 2.9.2 and you might use clean or more themes with your own logo, you probably noticed that since MDL-49536 the logo only appears on the front page and on the login page. This was intentional and fixed an existing bug (that DOM section may include other stuff than just the site or the course name) but some of you might be used to see your logo everywhere, you need to follow company policies or you just want to display your brand on top of the page so everybody recognizes who is the cool people that manages that awesome site.

Marina proposed a workaround (https://tracker.moodle.org/browse/MDL-50661?focusedCommentId=367646&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-367646) but given that admins setting clean and more themes are not necessarily experienced in CSS or themes stuff, we are working on a better alternative (MDL-50661) which would allow these themes to set a small logo in the navigation bar where you can now see the site short name.

I'm commenting here because themes is always a sensitive component to perform changes and we don't want to miss anything important nor upset anyone. What we propose in MDL-50661 is to add two new settings, one to set a small logo that would be displayed in the navigation bar on the pages where the main logo (the current one) is not displayed; and another one (only active if you set a small logo) to decide whether you want to display the site name next to this new small logo or not. Better look at the two screenshots (http://postimg.org/image/v5ul64b1r/ and http://postimg.org/image/uicyub2g3/). Seems a good solution to us because you can either set the site name + a square/rounded logo (actually more like an icon than a logo) or you can set a small logo and remove the site name if your logo includes your site name with your own font...

We checked RTL, accessibility, different window sizes and all this stuff. More details in the issue (note that it evolved from the initial proposal) You can pull the patch (https://github.com/dmonllao/moodle/compare/MDL-50661_master~2...MDL-50661_master) and try it, all feedback welcomed.

If you created your theme copying from clean or more, it is also important that you are aware of MDL-49536 and MDL-50661 changes and update your themes accordingly if required.

(Edited by Mary Evans - edited out slang word which I found offensive - original submission Thursday, 12 November 2015, 8:30 AM)

Average of ratings: Useful (3)
In reply to David Monllaó

Re: Clean and more logos

by Mary Evans -
Picture of Core developers Picture of Documentation writers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

Hi David,

I have just edited your post to change a word which I personally found offensive.

I am not happy with some of the changes...not the changes exactly, but the way in which that are being done.

I have also left a comment in the tracker about a regression in Secure layout, which is more important.

Thanks for your concern with Themes...they are sensitive...we too are sensitive folk who work with them.

Mary