Problem with Theme based on Clean - Menu Button not working in Moodle 2.9

Problem with Theme based on Clean - Menu Button not working in Moodle 2.9

by Dave Emsley -
Number of replies: 5

I have an odd issue with a theme I've created based on Clean.  There is a custom menu and when the window is reduced so that the menu button appears the menu works fine on the home page but not on any other pages.

If anyone could offer an idea as to resolving this I'd be grateful.


Beat Regards


Dave Emsley

Average of ratings: -
In reply to Dave Emsley

Re: Problem with Theme based on Clean - Menu Button not working in Moodle 2.9

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Hi Dave,

Sorry, very difficult to answer without knowing the custom code or a screen shot of the actual 'odd' issue.  What do mean by not working?

Gareth

In reply to Gareth J Barnard

Re: Problem with Theme based on Clean - Menu Button not working in Moodle 2.9

by Dave Emsley -

Hi Gareth,

http://212.159.165.84/~soap/

is the main page.  If you go there and shrink your window until the menu button appear.  When you click the menu appears as an opening div.

Go to a page - http://212.159.165.84/~soap/mod/page/view.php?id=58

Same action doesn't work.


Cheers


Dave



In reply to Dave Emsley

Re: Problem with Theme based on Clean - Menu Button not working in Moodle 2.9

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Hi Dave,

You have / copy-pasted etc. an old bit of mark-up and so the course layout file has 'data-toggle="workaround-collapse"' for that button's 'a' tag instead of 'data-toggle="collapse"'.  The former is for YUI and the latter for jQuery Bootstrap JS.

Where can I send my invoice? smile.

Cheers,

Gareth

Average of ratings: Useful (1)
In reply to Dave Emsley

Re: Problem with Theme based on Clean - Menu Button not working in Moodle 2.9

by Mary Evans -
Picture of Core developers Picture of Documentation writers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

Hi,

Lotsof things changed in Clean theme in 2.9.

One of the things is the layout changed and also we started to use jQuery, so as Gareth pointed out we dropped YUI JavaScript hence the problems you have fallen foul of.

You should always read the upgrade.txt in moodle/themes/upgrade.txt which tells you in developer speak that which has changed.

You would be best to compare Clean them in 2.9 against your customised theme so you can see the changes.

Regards

Mary

Edit: link to changes...

https://github.com/moodle/moodle/blob/MOODLE_29_STABLE/theme/upgrade.txt#L1-L18

Average of ratings: Useful (1)
In reply to Mary Evans

Re: Problem with Theme based on Clean - Menu Button not working in Moodle 2.9

by Dave Emsley -

I thought I had used the 2.9 clean as the basis.


Thank you both very much, really appreciate it.


Dave