modal.fade

modal.fade

by can meşe -
Number of replies: 12
In this line ".modal.fade{-webkit-transition:opacity .3s linear,top .3s ease-out;-moz-transition:opacity .3s linear,top .3s ease-out;-o-transition:opacity .3s linear,top .3s ease-out;transition:opacity .3s linear,top .3s ease-out;top:-25%}", .3s ease-out;top:-25% should be .3s ease-out;top:-100%. Because bootsraps elements deny headering button such as theme colours, this course button.

top:-25% should be changed as top:-100% for working buttons (attachment photo).


Attachment buttons.png
Average of ratings: -
In reply to can meşe

Ynt: modal.fade

by can meşe -

Gareth, 

When it is top:-25%, bootstraps element blocking the header buttons (like as the attachment photo).

I just ask you would you change at the appropriate time.

Thank you for your helping.

Attachment blocking.png
In reply to can meşe

Re: Ynt: modal.fade

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

This is therefore an issue with Bootstrap elements (https://moodle.org/plugins/view/mod_bootstrapelements) as both BS 2.3.2 (https://github.com/twbs/bootstrap/blob/v2.3.2/less/modals.less#L42-L43) and BS 3.3.5 (https://github.com/twbs/bootstrap/blob/v3.3.5/less/modals.less#L33) have the same sort of mark-up.

And what are the steps I need to perform to replicate this please?  What version of Moodle, Essential and Bootstrap elements?

In reply to Gareth J Barnard

Re: Ynt: modal.fade

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

P.S.  So, really you are saying that something added by Bootstrap Elements is causing the menu to be hidden?  If so, why is this a Bootstrap LESS / Essential issue?  Surely it's to do with Bootstrap Elements and it's placement of the component on the page in relation to the normal flow of things.

In reply to Gareth J Barnard

Ynt: Re: Ynt: modal.fade

by can meşe -
My moodle's version information:

Moodle 2.8.7

Essential 2015061902 2.8.1.8 (Build: 2015061902)

Bootstrap elements 2015010600 1.1

Can you make change .3s ease-out;top:-25% with.3s ease-out;top:-100% in essential.css

Thank you very much.

In reply to can meşe

Re: Ynt: Re: Ynt: modal.fade

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

RE: "Can you make change .3s ease-out;top:-25% with.3s ease-out;top:-100% in essential.css." = no, not until I'm convinced it is the right thing to do with full justification and checking to see that it does not cause other issues.  Currently I believe that there is a fault with Bootstrap Elements given the fact that the LESS in principle has not changed from 2.3.2 to 3.3.5 in Bootstrap itself with all of the global exposure it gets.

And the code is the same in Moodle core: https://github.com/moodle/moodle/blob/MOODLE_29_STABLE/theme/bootstrapbase/less/bootstrap/modals.less#L41-L44 - therefore the issue should happen with Clean too.  If it does not, then changing that LESS is NOT the correct solution to the problem.

In reply to Gareth J Barnard

Re: Ynt: Re: Ynt: modal.fade

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

P.S. It won't work in Clean on M2.8 because it does not have the full jQuery JS containing the modal code.  In M2.9 Bootstrap Elements has issues.  But might still work in Clean.  Essential needs checking for the jQuery element of this.

In reply to Gareth J Barnard

Re: Ynt: Re: Ynt: modal.fade

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Cannot replicate as a 'display: block' / 'display: none' is in operation, such as:


<div id="bootstrapelements1" class="modal fade in" role="dialog" aria-labelledby="myModalLabel" aria-hidden="false" style="display: block;">


when shown and:


<div id="bootstrapelements1" class="modal fade" role="dialog" aria-labelledby="myModalLabel" aria-hidden="true" style="display: none;">


when not shown.  Therefore the JavaScript is broken on your site and preventing the normal operation of the modal.  Therefore the 'top' fix is NOT a solution.

In reply to Gareth J Barnard

Re: Ynt: Re: Ynt: modal.fade

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Humm. Ok, in this situation 'modal' class needs a 'display: none' in LESS which will then be overridden by inline CSS put in place by the JS.

In reply to Gareth J Barnard

Re: Ynt: Re: Ynt: modal.fade

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

So it looks like BS3.5.5 has this fix: https://github.com/twbs/bootstrap/blob/v3.3.5/less/modals.less#L17 - BS2.3.2 does not: https://github.com/twbs/bootstrap/blob/v2.3.2/less/modals.less#L24-L46 - therefore it will be a 'bug' with Clean and any BS2.3.2 based theme in M2.9 because they will be using the full jQuery which supports the Modal functionality.

In reply to Gareth J Barnard

Re: Ynt: Re: Ynt: modal.fade

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Update:

Went to raise an issue on Moodle core, looked for an example: http://getbootstrap.com/2.3.2/javascript.html#modals - discovered that the modal has the extra class 'hide' which does a 'display: none'.  Therefore as previously suspected Bootstrap Elements is WRONG as not 'read the fine manual' and implemented the code correctly, thus in lib.php line 245:

'class' => 'modal fade',

should be:

'class' => 'modal hide fade',

Gareth