Moodle in English: Outcomes not working on links created in a version previous that 2.8 (when upgraded)

Outcomes not working on links created in a version previous that 2.8 (when upgraded)

by Jesus Federico - Friday, July 10, 2015, 1:52 AM

I created an issue for this https://tracker.moodle.org/browse/MDL-50808 but as a brief summary.

If an LTI link is created in a version previous to Moodle 2.8 (lets say 2.5) configured to receive grades and used, the reference to the gradebook created at that point does not work if the server is upgraded.

When using the reference (lis_resource_sourcedid) stored by the Tool Provider, Moodle responds with a 404 error.

There should be backward compatibility, and my guess is that the bug is in the form the sourcedId is validated when the replaceResult request is received, but it may also be in the reference to the item in the gradebook, so the script for upgrading would be the culpit (this I don't know, I am not that familiar with the internal code).

Anyways, the workaround found is to ask students to use the link again. that seems to be rebuilding the reference along with the new ID used as lis_result_sourcedid.

Re: Outcomes not working on links created in a version previous that 2.8 (when upgraded)

by Stephen Vickers - Friday, July 10, 2015, 2:31 AM

Are you sure that this is an issue between 2.8 and previous versions of Moodle? Inspecting the code suggests to me that the only recent change to the way the lis_result_sourcedid parameter value is generated was in Moodle 2.6. Do you know if this issue arises when, for example, upgrading from 2.7 to 2.8?

Average of ratings: -

Re: Outcomes not working on links created in a version previous that 2.8 (when upgraded)

by Jesus Federico - Friday, July 10, 2015, 11:30 PM

Hi Stephen,

No, I did not tried from 2.7 to 2.8 because the case I got reported was specifically from 2.5 to 2.8. In the case I was working on (which is closed on our end) there is no much we can do since the migration is already done, however I can help out narrowing the problem down if needed.

I reproduced what the users had in production by

a. installing a new 2.5,

b. adding and using LTI links,

c. migrating to 2.8

d. and finally trying to execute a repplaceResult

What I could do is to try the same from 2.7 to 2.8 and 2.5 to 2.6

In what version the "typeid" was added to the sourcedId string? Is that the change you mean?

Average of ratings: -

Re: Outcomes not working on links created in a version previous that 2.8 (when upgraded)

by Stephen Vickers - Saturday, July 11, 2015, 2:00 AM

As I understand your post, you are suggesting that the lis_result_sourcedid changed after Moodle 2.5 which caused integrations to fail unless this value was refreshed, If so, my review of the code suggests that the only change to this value occurred in 2.6 (with the addition of the typeid element) and so my conclusion was that this is probably not a 2.8 issue, but a more general issue of upgrading from a version of Moodle prior to 2.6. However, if this were the case I would have expected it to be widely known and raised some time ago - before I got involved with this part of the code base. Have you tried manually adding the typeid element to a sourcedid value after upgrading to see if this is the actual cause?

Average of ratings: -

LTI and Moodle

Outcomes not working on links created in a version previous that 2.8 (when upgraded)