General developer forum

Hello,

some teachers of the institution i work for found two issues with the "locked" field of a grade/category item.

1. If you try to edit a category grade item, let's say, you change the max grade and also checks the "locked" checkbox, your maxgrade is edited but the item is not locked. Then you change just the locked status, save and it works. If you try to change the maxgrade again and at same time unlock the item, it works. I have not found an issue on tracker related to this.
   
2. This is more problematic. You have a "locked" category item, the locked help text says: "If ticked, grades can no longer be automatically updated by the related activity."  But if you change, let's say, maxgrades again, then the item is updated but the grades are not recalculated, because of the locked option. So, it is not only by the related activity, but any changes won't take effect until you unlock the item (settings areare stored and retrieved ok, but no changes to grades). So, this help message hides part of the problem. It may be somewhat related to MDL-48634
   

It seems this is not the expected behaviour.
If the changes really should not be applied, then the form fields for other settings should be disabled when the item is locked.
But it seems to be a difficult approach: what if you lock an item, save it, get back to it, unlock, change something, lock again and save?
This way, the more appropriate behaviour would be to apply the changes and recalculate grades even if the items are locked, just for the item settings, not for the activities as is said on the help text.

What do you think?

Kind regards,
Daniel