Shoehorn a.logo CSS not working

Shoehorn a.logo CSS not working

by Mary Evans -
Number of replies: 1
Picture of Core developers Picture of Documentation writers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

Hi Gareth,

I am curious to know why you decided to change the way the logo works in Shoehorn?

Unless I have missed a setting somewhere, It looks very much like the logo is added as an image to the header of the page, rather than as a background image as it is styled in Clean theme.

 <header class="moodleheader col-md-12"><img class="logo" alt="Logo" src="//localhost/moodle29/pluginfile.php/1/theme_shoehorn/logo/-1/logo.jpg"><h1 class="logoheading">Moodle 2.9</h1></header>
.moodleheader .heading,.moodleheader .logoheading {
  display: inline-block;
}body.allpagesbackgroundimage .moodleheader .heading,body.frontpagebackgroundimage .moodleheader .heading,body.allpagesbackgroundimage .moodleheader .logoheading,body.frontpagebackgroundimage .moodleheader .logoheading {
  padding: 4px;
  color: #1f4d87;
  background-color: #f5f5f5;
  background-color: rgba(245,245,245,.5);
  border-color: #e3e3e3;
  border-color: rgba(227,227,227,.7);
  border-style: solid;
  border-width: 1px;
  border-radius: 4px;
}.logoheading {
  display: inline-block;
}

Which is totally different than Clean theme logo...

<a href="//localhost/moodle29/" class="logo"></a>
a.logo {
    background: url('setting:logo') no-repeat 0 0;
    display: block;
    float: left;
    height: 75px;
    margin: 0;
    padding: 0;
    width: 100%;
}
.dir-rtl a.logo {
    background: url('setting:logo') no-repeat 100% 0;
    display: block;
    float: right;
}

And yet the language string for the logo description has been left unchanged, thus when Admin users go to add CSS to make changes  to the default setting in the Custom CSS box, it does not work, because that link tag does not exist in Shoehorn!

By the way images are better styled as backgrounds, because that way they are cached, rather than as an <img> tag, as those are downloaded every time the page is viewed, but not cached, at least this is what I was told by Sam Hemelryk.

Anyway, I am looking forward to hearing your viewpoint on this.

Cheers

Mary

Average of ratings: -