Hi David,
Normally I would move this post to the Course and Course formats forum, as Collapsed Topics is a course format and not a theme. However, Collapsed Topics does not produce that triangle highlighted, therefore its likely to be a theme issue. To decide this, does the issue happen in another theme? Do you have any additional custom CSS?
Gareth
Hi Gareth,
Sorry to post in the wrong forum, so please move to the appropriate place as necessary.
I forced the theme of the course to Clean, Brick and Standard and in each case the offending triangle still appears. We do have some custom CSS for our custom default theme for the rest of the site (which I'll happily post if it will help) but it all relates to alignment and padding.
Also this only appears on our live site and not the sandbox site.
Any help would be greatly appreciated
David
Hi David,
I'm sorry but there is no way I can tell what is going on without access to the site. This can be as little as guest access to a course with the issue.
Gareth
Guest access has been setup as follows:
website: nals.org.uk
menu: All courses/ICT & computing/computing for beginners
password: triangle
If you click on the centre triangle nothing special happens other than the topic opens or closes. The triangle does not change orientation.
David
Hi David,
Its coming from this bit of CSS:
.jsenabled .toggle {
background: transparent url('/theme/image.php/magazine/block_grade_me/1409650493/closed') no-repeat 50% 50% !important;
}As you are running Moodle 2.5 and the Magazine theme is a core theme I looked in the theme's folder for a 'pix_plugins' folder and there is none: https://github.com/moodle/moodle/tree/MOODLE_25_STABLE/theme/magazine - therefore there is a clash between Collapsed Topics styles and the Grade me block: https://moodle.org/plugins/view.php?plugin=block_grade_me. Now as the supplied 'grade me' block has a prefixing selector for that CSS: https://github.com/remotelearner/moodle-block_grade_me/blob/MOODLE_25_STABLE/styles.css#L45-L47. But looking in the master branch of the block: https://github.com/remotelearner/moodle-block_grade_me/blob/master/styles.css#L45-L47 - it appears that you have installed the development branch and not the stable release. Therefore please uninstall that block and use the stable version as published on: https://moodle.org/plugins/view.php?plugin=block_grade_me.
Gareth
Thank you Gareth for a very comprehensive answer.
There are a couple of things that have surprised me though. The first is that Remote Learner appears in the path of two of the code sections that you reference and they are our Moodle hosts. Are they involved with Moodle.org?
Secondly, Remote Learner upgraded us to Moodle 2.5 at the beginning of the year, so would they have picked up the development branch of more than just the grade me block? Do I need to be worried that there are other non-stable parts to our implementation?
thanks again
David
I would take it up with your Host company, as these are not questions we can answer on the forum as Remote Learner is a Moodle Partner and so for legal reason we are better keeping quiet.
Thanks
Mary
Dear David,
As Mary says, I cannot comment about Remote Learner or the specific circumstances of your installation. All I know is that the Grade Me block is a contributed plugin available from: https://moodle.org/plugins/view.php?plugin=block_grade_me.
Kind regards,
Gareth
Mary, Gareth,
As I'm fairly new to Moodle, I'm still not sure of the relationships of the major players, so I'll take all this back to Remote Learner now I know what the problem is.
Once again, thank you for your valuable assistance.
regards
David
Remote Learners are major players and have lots of good ideas to offer, so one has to respect their standing in this area.
Perhaps the easiest way to solve your problem should be to just hide that icon with CSS something like...
.block_grade_me .jsenabled .toggle { background: none }
@Mary - but that would remove the icon from the 'Grade me' block which is in use. The solution is to replace the master installation of the Grade Me block with the one specifically written for M2.7.
I don't think its the fault of the plugin code, just how the site came to have the wrong version of the plugin installed.
One wonders Gareth, do they need the my grades block, as it would appear that David did not instal it, it was done as part of the upgrade, or that is how I am understanding this.
I know from earlier clashes with RL that one has to step back and let them sort it.
Anyway why is that toggle icon in the course format anyway, as that area is not a Block Region or is it?
@Mary - Grade Me has a toggle for which it applies the class '.toggle'. Collapsed Topics also has a toggle for which it applies the class '.toggle'. Collapsed Topics has specific selectors that target itself only: https://github.com/gjb2048/moodle-format_topcoll/blob/MOODLE_27/styles.css#L69 - the master branch of Grade Me does not: https://github.com/remotelearner/moodle-block_grade_me/blob/master/styles.css#L45-L47 - however the M2.6 (used for M2.7) branch does: https://github.com/remotelearner/moodle-block_grade_me/blob/MOODLE_26_STABLE/styles.css#L45-L47. So because the Grade Me master branch CSS is not specific enough, it targets both the itself and Collapsed Topics and prevents a more specific selector from overriding because of '!important': https://github.com/remotelearner/moodle-block_grade_me/blob/MOODLE_26_STABLE/styles.css#L46.
You are right we don't really use the grade me block. As a stop gap measure I would like to use the custom CSS you suggested earlier but where do I put this snippet? My custom theme has a Custom CSS area but the standard Magazine theme does not (as far as I can see)
David
You can add it to the end of magazine/style/core.css if you have access to it.
Or if you don't them got to Site Administration > Appearance > Additional HTML and add the following to the body section on that page...
<style type="text/css">
.block_grade_me .jsenabled .toggle { background: none }
</style>
But don't forget to save your settings!
Cheers
Mary
FYI: CONTRIB-5791 now raised.
Hi David,
I'm the manager of software development at Remote Learner and it's against departmental policy to use use development branches for client sites, so I took a peek at your site and it looks like you have an older (but stable) copy of the Grade Me block that was released before this particular bug was fixed.
I'm sure your account rep would be happy to help you get a newer version of Grade Me.
It the Show/Hide icon.
@Gareth, could it be AJAX doing this?
@David
What happens if you click on the small triangle?