Essential Version 2014071701: CSS issues - RTL ONLY

Essential Version 2014071701: CSS issues - RTL ONLY

by Mary Evans -
Number of replies: 10
Picture of Core developers Picture of Documentation writers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

This thread is for RTL (Right to Left) language CSS issues ONLY.

I am going to try and work on getting some order into the RTL CSS issues in Essential theme.

The version I am working on is the latest one in the Plugins repository and installed into Moodle 2.7 (Release: 2.7.1+ (Build: 20140724) via the Theme Installer. So everything is pretty much up-to-date., apart from the RTL CSS which is practically none existent, either that or I am missing something here. There is a CSS stylesheet but that does not appear to be written for RTL specifically although the title of the stylesheet itself suggests it is, so not sure what is happening here.

So if you have any issue with RTL display please add a comment here.

Thanks

Mary

Average of ratings: -
In reply to Mary Evans

Re: Essential Version 2014071701: CSS issues - RTL ONLY

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

That reminds me.  I've created a label for RTL issues here: https://github.com/DBezemer/moodle-theme_essential/issues?labels=RTL&page=1&state=open so that everybody can see what issues are currently outstanding and if new ones need to be raised there.

The 'essential-rtl.css' file is a work in progress as we migrate the CSS to LESS: https://github.com/DBezemer/moodle-theme_essential/issues/1 and stems from the Gruntfile.js on the master branch which flips 'left' to 'right' in the CSS etc.  See: https://www.npmjs.org/package/grunt-css-flip.

Average of ratings: -
In reply to Gareth J Barnard

Re: Essential Version 2014071701: CSS issues - RTL ONLY

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Ok, issue #78 has been fixed in: https://github.com/DBezemer/moodle-theme_essential/commit/2f5839063faaa4b72cc19aad255d416b232a589a - I have also tided some things up.  So before you report any issues on GitHub, please make sure you are testing the master branch: https://github.com/DBezemer/moodle-theme_essential

Average of ratings: -
In reply to Gareth J Barnard

Re: Essential Version 2014071701: CSS issues - RTL ONLY

by m question -

thank you both for your great help

I really like essential theme and I think its great theme

I am sorry but I do not understand how to use github

you said you fixed it , how I can download the new file 


another issue, when convert language to RTL (Arabic) the logo become in middle and the social icons does not move to the left , I did ask about that before and someone suggest solution which I could not do it.however , the navigation bar works fine.

in nav bar when convert to Arabic there is no space between icon and the words while in English there is space see the pics

navr bar for RTL language  nav bar english language

I just notice that \i have other version (Build: 20140203) can I continue here or this is only 2014071701

thanks

Average of ratings: -
In reply to m question

Re: Essential Version 2014071701: CSS issues - RTL ONLY

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Hi,

You can download a TEST version from: https://github.com/DBezemer/moodle-theme_essential/archive/master.zip - this will be release 2.7.4 - please have a go on a TEST server (DO NOT try on production) and try it out for yourself.

However, 2014071701 is version 2.7.3 which a few people have complained about.  And build 20140203 is Julian's before David and I took over.

I'll look at the issue you have mentioned and if it still exists, try and fix it for 2.7.4.

Cheers,

Gareth

Average of ratings: Useful (1)
In reply to Gareth J Barnard

Re: Essential Version 2014071701: CSS issues - RTL ONLY

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Just tested in the master branch which will soon be the stable 2.7.4 and that problem does not happen.  It is possible that the release candidate https://moodle.org/mod/forum/discuss.php?d=264673 may have it, but I have just fixed: https://github.com/DBezemer/moodle-theme_essential/issues/78 which will be in 2.7.4.

Average of ratings: -
In reply to Gareth J Barnard

Re: Essential Version 2014071701: CSS issues - RTL ONLY

by m question -

thanks

ok I did download essential from github link you put here, 

for logo it is the same, the social icons move though not as previous version but, not as it should , the logo does not move to right it moves to middle, if is it possible not to move at all in Arabic and stay as in English version would be better.

see the pics

in English languagelogo no problem in english


in Arabic language

problem in logo in arabic RTL language



about the category icon when I change language to arabic (RTL) this is how it looks

category icon problem

Average of ratings: -
In reply to m question

Re: Essential Version 2014071701: CSS issues - RTL ONLY

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Thanks, both are new issues, as the category icon I thought I'd fixed.

Average of ratings: -
In reply to Gareth J Barnard

Re: Essential Version 2014071701: CSS issues - RTL ONLY

by Mary Evans -
Picture of Core developers Picture of Documentation writers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

Is the RTL CSS actually being processed correctly? Is it compiling into correct CSS ? Do you check it or just assume it is?

i do so hate not beingable to read it can you not also have a non mini field version too?

Average of ratings: -
In reply to Mary Evans

Re: Essential Version 2014071701: CSS issues - RTL ONLY

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Ok, was not, is now.  No longer a minified version.

Oh drat drat and double drat - style/rtl.css not added to git only on local machine.  Very annoyed with myself as thought had added.

Average of ratings: -