CiBot told me that pull branches I've added to MDL-46116 have (pre-existing) documentation and Moodle coding guidelines issues.
Assuming I can find time to tidy, what's the recommended approach for submitting fixes to these problems (as reported by the moodlecheck and codechecker plugins)?
Probably 2.
There are occasions where 1. might be more appopriate, but normally it is not worth it.
Cool, thanks Tim.
I suppose we should make it clear:
The one thing you should not do is mix up irrelevant coding style clean-up with a real functional change as part of the same commit. The extra noise in the patch make it harder to understand the change.
You obviously know this, since you did not even suggest doing that, but I thought it helpful to make it clear as part of this thread the one things you really should not do.
