Your thoughts on MDL-43581, please

Your thoughts on MDL-43581, please

by Tim Hunt -
Number of replies: 4
Picture of Core developers Picture of Documentation writers Picture of Particularly helpful Moodlers Picture of Peer reviewers Picture of Plugin developers

The setting Admin -> Appearance -> Additional HTML -> Before BODY is closed is described as:

Content here will be added in to every page right before the body tag is closed.

However, this content is currently added to the page in $OUTPUT->standard_footer_html(), which is only included on pages where $hasfooter is true.

I think it should be moved into $OUTPUT->standard_end_of_body_html() which really is added to every page.

And I have coded a patch that makes that change.

So, if you disagree, scream now in MDL-43581. Thanks.

Average of ratings: Useful (2)
In reply to Tim Hunt

Re: Your thoughts on MDL-43581, please

by Mary Evans -
Picture of Core developers Picture of Documentation writers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

That is interesting...if that is the cas then please do make those changes.

In reply to Tim Hunt

Re: Your thoughts on MDL-43581, please

by Danny Wahl -

go ahead and fix it ;)

In reply to Danny Wahl

Re: Your thoughts on MDL-43581, please

by Tim Hunt -
Picture of Core developers Picture of Documentation writers Picture of Particularly helpful Moodlers Picture of Peer reviewers Picture of Plugin developers

Thanks, Mary and Danny. I will submit this for integration, putting your names in the peer reviewer field. I hope that is OK.