Hi all,
I'm attempting to implement MDL-43112 - what I need is assistance in identifying where the screen is in Moodle for each of the PHP and JS files listed on: https://github.com/gjb2048/moodle/compare/wip-MDL-43112_master. Then I can form a full test plan and check each one to ensure nothing has been broken as has just been identified. If you can say something on the tracker or here like:
/course/renderer.php -> Course with editing on.
Then that would be helpful.
Cheers,
Gareth
Please
Like I said just now in the tracker...what you have done in this fix is spot on. The problem is with the old CSS and if the plus sign is the only icon that is causing this to be rejected then we need to look at the plus sign icon and see where it has gone wrong. For instance was it a iconsmall or smallicon? What was the original CSS? Was it written wrongly? Is there a duplicate of that CSS elsewhere? This is what we need to find out. I'm working on it at the minute.
Cheers
Mx
Further to my last comment...
1) this is a relative setting for img.iconsmall
.section .activity .moodle-actionmenu[data-enhanced] .menu {margin-left: -2.8em;}
.section img.iconsmall {
vertical-align: text-bottom;
width: 16px;
height: 16px;
margin: 4px;
}
2) whereas this is an absolute setting
.section .editing_title img.iconsmall {
width: 12px;
height: 12px;
margin: 4px 8px 4px 0;
}
so one has to wonder about the logic applied to the reason behind the different sizes for the same icon. surely it should be set and fixed, there is no reason for it to be smaller.
Hope this helps?
Cheers
Mary
Hi Gareth
I think I later, but... I have revised the icons in my theme, and here I upload the list I use for documentation the changes I made...
Thanks for your improve
Hi Franc,
Thank you for the list, but I'm sorry to say has nothing to do with the post question. I'm trying to identify which physical page is displayed for each file listed in the difference so I can fully write the test plan.
The issue pull branch has updated to: https://github.com/gjb2048/moodle/compare/wip-MDL-43112_master_2
Cheers,
Gareth