Before today blocks were each produced as a table with two cells, one above the other. Now they are a div that contains two smaller divs.
None of the container names have changed - the outer one is still "sideblock", containing "header" and "content".
However, depending on assumptions you have made in your theme you may find some breakage occurring when you next update Moodle 1.5 dev.
Sorry about the last-minute hassle, but better now than after 1.5 is released!
I could get my theme working again with two small changes:
The header color showed up again by defining a height:
.sideblock .header {
height:2em;
...
}
The sideblock content went back into the sideblock (sitting beside it after the changes of the sideblock structure) by adding clear:both
:
.sideblock .content {
clear:both;
...
}
I hope it's of some help.
[Urs CSS]
Also, the header doesn't float anymore, which means that there's no need to clear any elements also. And the "collapsed header" issue (which forced you to give it an explicit height) probably means that in your theme, some elements are still floated (if you mean orangewhite, then I can see they are indeed).
Just remove all the floating except for this:
.sideblock .header .hide-show {
float:right;
}
and it should be fine, as it is in standard.
Hi Jon,
thanks for the details. I'll give the sideblocks a second look.
Urs
Hi Martin,
Did you test Moodle with IE6 on another operating system, not Windows. Your screen is so different from mine .
Incidentally I noticed in these screenshots how bad the login box looked, and fixed that today.
Not only me, others saw that problem too.
Did you read the post: http://moodle.org/mod/forum/discuss.php?d=23566?
We really need some solutions for this from someone! (I can't solve it because it works for me)
Re: Alert: Change in 1.5 Sideblocks: TABLE -> DIVS
Hi Jeff,
My Moodle 1.5 courses are Ok under IE6. I mean when you use IE6 and connect to http://moodle.org, then see if there's the same problem as above. We have just changed some code of moodle.org recently to fix the block's width problem.
Cheers,
Vu Hung
IE: Tools -> Options -> Temporary files -> Delete files
Holding down Control key while pressing refresh should have worked too (it does for me) but IE is notorious for buggy and overzealous caching.
>>IE: Tools -> Options -> Temporary files -> Delete files
That's a great tip, Martin. Now, it worked for me. In my mind, refreshing is enough (as my own experiences). So what's actually wrong with IE? Could somebody explain this?
Martin, should we put this tip in FAQ?
Cheers,
Vu Hung
Where do they accept applications for the "I love IE" club?
Incidentally, I 'm working on some JavaScript that runs once after the page loads and fixes the problem of non-uniform block sizes for IE. Not 100% robust yet though.
Urs
Speaking of which, it's in CVS now. When moodle.org or test.moodle.com get updated we can test it with lots and lots of IE users.
Re: Alert: Change in 1.5 Sideblocks: TABLE -> DIVS
That said it's here and doesn't seem to be breaking anything!
Re: Alert: Change in 1.5 Sideblocks: TABLE -> DIVS
The reasoning behind this though was as follows:
- We can do absolutely nothing to have the problem fixed in IE while at the same time keeping a pixel-specified width for the side columns. If it's one thing I 'm convinced of, it's this.
- Without the "hack", teachers (or even students, when My Moodle starts allowing them to add blocks by themselves?) are mathematically sure to at some point add an overwide image. And they won't all be tech-savvy.
- Result: "Moodle's fault". I 'm talking about people who won't know that there is an alternative to IE (and wouldn't care even if they knew). Why not keep them blissfully unaware of what's going on until IE 7 comes out with an improved rendering engine (dream on...) and the whole universe upgrades?
- Finally, anyone who is savvy enough to actually see what's going on behind the scenes will definitely nod instead of complaining.
That said, if you believe it's doing harm I 'm still OK with pulling it out. I was just having one of my "haven't said my last word yet" fits.
On a related note, while hacking away I noticed that it's very hard for someone who wants to modify the core to insert something in body onload="". So hard that I didn't do it that way.
In fact, not only you have to have control over all calls to print_header (which you may not have, as in this case) but also a quick inspection left me with the impression that if you do insert something and at the same time use the auto-focus feature, the result will be exactly equal to one Javascript error at worst (and your onload will not simply not work at best).
We can do two things to remedy this:
- Pre-emptively have onload call a predefined function anyway, in addition to anything else. This will at least allow people who want to insert their own Javascript an easy entry point (just add your code to the empty by default function).
- Build a better system for adding onload stuff. And an easier way to specify the attributes of <body> incrementally while we 're at it. The $PAGE object would be good for this, and we don't need to refactor the world. Just build the support into page_base and then slowly move things that way while working on Moodle 1.6.
This came out quite long, didn't it?
This problem seems similar to "global $course" hack used for setting up of course language. As I said before somewhere I would like to see a new init() function called in each script before first text output - we could setup course language, themes and other ugly hacks (== browser workarounds) there.
skodak
Re: Alert: Change in 1.5 Sideblocks: TABLE -> DIVS
I'm totally OK with keeping this hack - it seems to be working very well so far and it *is* a neat trick.
And yes, you know I totally agree with moving everything over to the $PAGE class over time.
see Posting above (from Jon):
Today I've found a solution for non-uniform blocksizes and other MSIE-CSS-Problems
See MSIE 7: http://dean.edwards.name/IE7/overview
I'm going to test it. May be, its a good idea, to integrate this into moodle.
Tobias
Re: Alert: Change in 1.5 Sideblocks: TABLE -> DIVS
Any ideas?
Jeff