General help

 
 
Picture of Kristina Schneider
Site Theme Additional HTML Header suddenly appears in Pop-up Window after upgrade to Moodle 2.4+ (Build: 20121214)
 

Thank you in advance to anyone who can help! smile

We have an issue that since we updated our Moodle installation to Moodle 2.4+ (Build: 20121214) the Header used in our site theme is now added to the top of our SCORM pop-up windows displaying our e-learning modules developed in Articulate.

This was not the case in all our previous versions of Moodle. This bug is a direct cause of the upgrade to this version.

We are using the Arialist theme. In the Site administration > Appearance > Additional HTML section, we have code in

  • additionalhtmlhead 
  • additionalhtmltopofbody
  • additionalhtmlfooter

The banner is in the additionalhtmltopofbody section. 

This wouldn't be such a huge issue except that our users have to scroll in their pop-up window to see the navigation in the e-learning module. Even when they click full screen mode, it doesn't work. Our e-learning modules are developed in Articulate and normally when you open up an instance in a pop-up window, the player resizes to fit within the window: this bug is preventing the player from doing this. 

Can anyone provide solutions, insights, anything? As a last results, we'll try to hack the code, but we are hoping we don't have to go that route. 


 
Average of ratings: -
Picture of Constance Horne
Re: Site Theme Additional HTML Header suddenly appears in Pop-up Window after upgrade to Moodle 2.4+ (Build: 20121214)
 

What was your previous version of Moodle?

 
Average of ratings: -
Picture of Constance Horne
Re: Site Theme Additional HTML Header suddenly appears in Pop-up Window after upgrade to Moodle 2.4+ (Build: 20121214)
 

What was your previous version of Moodle?

 
Average of ratings: -
Picture of Dan Marsden
Re: Site Theme Additional HTML Header suddenly appears in Pop-up Window after upgrade to Moodle 2.4+ (Build: 20121214)
Group DevelopersGroup Moodle Course Creator Certificate holdersGroup Particularly helpful MoodlersGroup Translators

in pop-up mode SCORM sets the page layout to 'popup'

the Arialist theme is set to use the 'general.php' file for the 'popup' layout.

general.php always shows the additionalhtml at the top of the body and doesn't give any settings that allow you to change that.

The best solution would be to create your own custom theme that uses arialist as the "parent" and uses a custom layout file for the popup layout that excludes the header stuff but uses everything else from the parent theme.

 
Average of ratings:Useful (1)
Picture of Kristina Schneider
Re: Site Theme Additional HTML Header suddenly appears in Pop-up Window after upgrade to Moodle 2.4+ (Build: 20121214)
 

Thank you Dan.  The thing is, it didn't always behave this way. In fact, we've been running these exact same modules on Moodle since 2011 and it is only with this upgrade that we experienced this issue. 

We aren't going to build our own theme (I would assume that standard, approved Moodle Themes would be tested against new versions) we modified an existing one to suit our needs, and up until this version of Moodle it did. (Constance, I know we were somewhere in version 2, but I'm not sure if it was .1, .2 or  .3 to be honest). 

We went ahead and hacked the code as we needed a quick fix (our course went "live' on Monday with this disturbing new bug. We made a modification in scorm/player.php file so that the header not display the header block. I guess this will do for now. 

Thanks!

Kristina

 
Average of ratings: -
Picture of Kristina Schneider
Re: Site Theme Additional HTML Header suddenly appears in Pop-up Window after upgrade to Moodle 2.4+ (Build: 20121214)
 

Well that just made everything worse. It worked fine in my browsers, but several of our users using IE were not able to view the modules.

This is still unresolved. I'm curious why Moodle changed it's pop-up page code in this last version... 

 
Average of ratings: -
Picture of Kristina Schneider
Re: Site Theme Additional HTML Header suddenly appears in Pop-up Window after upgrade to Moodle 2.4+ (Build: 20121214)
 

After doing much research, this is still unresolved. Anyone?

 
Average of ratings: -
Picture of Richard Bakos
Re: Site Theme Additional HTML Header suddenly appears in Pop-up Window after upgrade to Moodle 2.4+ (Build: 20121214)
 

Hello Kristina,

You can probably easily fix this by doing the following...

1. In the additional HTML you have, add a class or ID to the top element of the HTML... For example, let's say your additional HTML is structured something like this:

<div id="hide-me">
    <a href="http://some.link.to/your/site">
        <img src="http://some.path.to/an/image.png">
    </a>
</div>

If you already have a class or ID on that top element then you are already half-way there.

2. Add this one line of CSS to the bottom of the pagelayout.css file of your theme:

#page-mod-scorm-player #hide-me /* or whatever your pre-existing class/id is */ {display: none;}

The red part targets only the scorm player page and the blue part targets your additional HTML block. So this will only hide the header on the scorm pop-up.

Hope that helps!

EDIT: I would also revert whatever changes you made to the scorm/player.php if you have not already done so.

 
Average of ratings:Useful (1)
Picture of Kristina Schneider
Re: Site Theme Additional HTML Header suddenly appears in Pop-up Window after upgrade to Moodle 2.4+ (Build: 20121214)
 

Thank you so much, Richard. We will try this out and let you know how it worked. 

 
Average of ratings: -
Picture of Richard Bakos
Re: Site Theme Additional HTML Header suddenly appears in Pop-up Window after upgrade to Moodle 2.4+ (Build: 20121214)
 

You are quite welcome... Please let us know how you get along with the issue smile

 
Average of ratings: -
Picture of Jeff White
Re: Site Theme Additional HTML Header suddenly appears in Pop-up Window after upgrade to Moodle 2.4+ (Build: 20121214)
 

Hi Richard,

We had a similar issue with our SCORMs playing in new windows as well and your quick fix did get rid of the banner smile 

Just a note to everyone that this will also get rid of the banner for a New window and Embedded SCORMs. Just for curiosities sake. How would you make it where the banner would go away only if the SCORM was in a new window and not embedded? 

 
Average of ratings: -