A bunch of bug-fixes going in to the External tool module

A bunch of bug-fixes going in to the External tool module

by Tim Hunt -
Number of replies: 0
Picture of Core developers Picture of Documentation writers Picture of Particularly helpful Moodlers Picture of Peer reviewers Picture of Plugin developers

Between Mark Nielsen and me it has been a good week for getting LTI issues fixed:

https://tracker.moodle.org/issues/?jql=Key%20IN%28MDL-40867%2CMDL-40863%2CMDL-40857%2CMDL-40005%2CMDL-36399%29

There is one issue in particular that I wanted to hilight, becuase it is a user-visible change.

At the moment, if you set an LTI link ot open in a new window, what happens is

  1. Student clicks link.
  2. Course page is replaced by an almost blank page saying "Your thing should open in a new window".
  3. That page then tries to open the new window, but is highly likely to be blocked by your pop-up blocker.
  4. But, hopefully the external tool opens in a new Window.

After MDL-40867 is fixed, it will work like this:

  1. Student clicks link.
  2. New window (or tab) opens containing the external tool.
  3. The old browser window which contains the course page does not change.

I hope everyone agrees that this new behaviour is jsut better, and there is no issue in making this change on the Moodle stable branches. If you disagree, please comment in the bug.

Average of ratings: -