Hi,
I'm in the process of upgrading from Moodle 1.9.19 to 2.2.6 (I realise these are ageing versions with limited-to-no support) which involved upgrading facetoface from 2007091300 to 2013010400 and there were multiple issues. To resolve these I had to make changes to mod/facetoface/db/upgrade.php, I've attached the patch to this post.
To summarise the issues:
- $dbman->add_field(), create_table() and drop_field() appears to return void so don't assign this to $result. (This appears to be already known: https://moodle.org/mod/forum/discuss.php?d=217299).
- $OUTPUT->notification() is an empty object, add $OUTPUT to the list of globals at the start of xmldb_facetoface_upgrade().
- Property $DB->debug isn't accessible (protected) so remove these.
- The second parameter for $DB->get_records() should be either null or an array.
- The field list for $DB->get_records() should be in the fourth parameter.
Unless of course there's something very wrong with my installation.
All the best,
Leon