I have overrides to the core_renderer on the same page working correctly but this code does not work..why? (the titles of the course page sections should all turn to "hello")
require_once($CFG->dirroot.'/course/format/renderer.php');
abstract class theme_mytheme_format_section_renderer_base extends format_section_renderer_base {
public function section_header($section, $course, $onsectionpage, $sectionreturn=0) {
global $PAGE;
return 'hello';
}
}
Are you sure your class should be abstract?
if only because the source class is
abstract class format_section_renderer_base extends plugin_renderer_base {
abstract protected function start_section_list();
abstract protected function end_section_list();
abstract protected function page_title();
.
.
etc
.
.
protected function section_header($section, $course, $onsectionpage, $sectionreturn=0) {
.
.
}
.
.
}
but I have also tried this code:
class theme_mytheme_format_section_renderer_base extends format_section_renderer_base {
public function start_section_list(){return 'hello';}
public function end_section_list(){return 'hello';}
public function page_title(){return 'hello';}
public function section_header($section, $course, $onsectionpage, $sectionreturn=0) {
global $PAGE;
return 'hello';
}
}
The base class is marked abstract because it is expected of implementer to provide methods marked as abstract. Than derived class is no longer abstract and should not be marked as such.
As for not working, you did try things outlined in this page?http://docs.moodle.org/dev/Overriding_a_renderer
not much to do.
1. $THEME->rendererfactory = 'theme_overridden_renderer_factory'; is in config (in fact I have a core_renderer override on the same file running well)
2. I included the file where the class is and
3. I believe I followed the naming conventions correctly.
Obviously I am missing something crucial but I cant figure out what it is....
I think (and you'd have to check), that none of the course formats use that renderer directly, but use derived classes based on that renderer.
I think, therefore, that what you are doing will only work if you override the actual class that is used by the course format and not the abstract base class (I have a half-memory of this coming up before in discussion).
Great! that works!!
that class is extended by format_topics_renderer
so I changed:
class theme_mytheme_format_section_renderer_base extends format_section_renderer_base {
to
class theme_mytheme_format_topics_renderer extends format_section_renderer_base{
interestingly I did not change the second argument (after "extends") by mistake but it worked!
I'd be surprised if there weren't at least some issues with extending 'base' instead of the 'topics' renderer. To be on the safe side I'd still correct it (are there no warnings produced when you set debugging to 'developer'?).
The proper way to do it is to create a new folder (plugin) inside course/format/{yourpluginname} and use this custom course format by going to "Site Admin -> Plugins -> Course format -> Manage course formats" and set your {yourpluginname} as default.
