mod/folder displaying file size/type?

Re: mod/folder displaying file size/type?

by Florian Zillner -
Number of replies: 1

Thanks for your advice sam!

After looking up your code I've done some additions to the mod/folder plugin, though they are not as nice as your implementation, I'd like anyone to review it and giving some advice. wink

I know there should be some additional fields in the admin area/on the settings page to make this whole thing optional, but as a first alpha I'd like to share this with you guys. So please have a look at the attachment and leave some replies. smile

The file belongs to the mod/folder folder and my additions are in the function htmllize_tree.

In reply to Florian Zillner

Re: mod/folder displaying file size/type?

by sam marshall -
Picture of Core developers Picture of Peer reviewers Picture of Plugin developers

Looks basically OK, so far as you've done! It needs the settings page options, database change to store them, etc., plus tidying to meet code style guidelines.

By the way I realise you might not have done it yet, but it's worth learning how to use the Moodle Tracker and github to submit proposals as it's a lot easier for other people to review patches that way!

--sam