Moodle in English: 1.9 -

1.9 - > Upgrade Issue

by Glen Davies - Friday, December 7, 2012, 5:50 AM

Just in the process of upgrading a large 1.9 site to 2.3. Have managed to upgrade everything except the HotPot module which gives the following error during upgrade (with latest version of mod downloaded yesterday). I have had a good search through the forums and can't find anything related to this particular error - apologies if I haev missed it.

Unknown exception related to local files (Can not fetch file form URL)

More information about this error

Stack trace:
line 740 of /lib/filestorage/file_storage.php: file_exception thrown
line 494 of /mod/hotpot/db/upgrade.php: call to file_storage->create_file_from_url()
line 541 of /lib/upgradelib.php: call to xmldb_hotpot_upgrade()
line 271 of /lib/upgradelib.php: call to upgrade_plugins_modules()
line 1466 of /lib/upgradelib.php: call to upgrade_plugins()
line 317 of /admin/index.php: call to upgrade_noncore()

I have tried 3 approaches

1. Upgraded from 1.9 - 2.1 with hotpot module included

2. Upgrade from 1.9 - 2.1 with hotpot module removed, then add back in hotpot after rest of site successfully upgraded and run hotpot upgrade by itself

3. Same as 2. but wait until site upgraded all the way to 2.3.3 before adding hotpot module back in.

All 3 options result in the same error message, and it happens each time when upgrade gets to

Migrating Hot Potatoes quiz files: (2288/4094)

So am suspecting some sort of corruption with quiz file 2288 or 2299.

Does anybody have any suggestions to get around this - is it possible to find out what quiz files 2288 or 2299 relate to and remove them from the 1.9 site to see if that gets around the problem?

Any help greatfully received.

Glen

Re: 1.9 - > Upgrade Issue

by Gordon Bateson - Friday, December 7, 2012, 8:53 AM

Hi Glen,
thanks for reporting this. Sorry to hear that the upgrade has gotten stuck.

The reason that the upgrade has got stuck is that at least one of the HotPot activities at your site specifies its "source file" as a full URL (e.g. "http://myserver.com/myfile.html") instead of a file path within the Moodle course "Files" folder (e.g. "myfolder/myfile.html").

If you are in a hurry, there are several ways we can get the upgrade to succeed.

locate and fix the unexpected URLs in the HotPot activities
1. open your favorite database administration tool (e.g. phpMyAdmin)
2. select the Moodle 1.9 database that you are trying to upgrade
3. run the following SQL command:
  SELECT * FROM mdl_hotpot WHERE reference LIKE 'http%'
4. convert the fulls URLs to relative paths by at least removing "http://"
force the HotPot upgrade script to ignore files specified using URLs
1. open "mod/hotpot/db/upgrade.php" with your favorite text editor (e.g. Notepad++, TextWrangler, vi)
2. locate the following line (around line 494)
  $file = $fs->create_file_from_url($file_record, $url);
3. change the above line to the following:
  $file = false;
4. save the file and run the upgrade again. You will get messages explaining which HotPots could not be upgraded. You may want to copy and save those message so you can clean up your the HotPots in your Moodle site.

If you have more time, I would like to ask you to try a little detective work to help me make the HotPot upgrade script detect and prevent this issue happening in the future.

First please check that you have Moodle "Debug messages" setting (Site admin -> Developement -> Debugging) set to "Developer" level and have enabled "Display debug messages".

Next, please change line 494 in "mod/hotpot/db/upgrade.php" to the following:

$file = $fs->create_file_from_url($file_record, $url, array('fullresponse' => true));

Now please try the update again and let me know what happens.

TIA
Gordon

Average of ratings: -

Re: 1.9 - > Upgrade Issue

by Glen Davies - Friday, December 7, 2012, 10:32 AM

Great - many thanks for the quick response and potential solutions. There is no panic to get the upgrade completed luckily as it is on a test copy on a sandbox server at this stage, rather than the live instance - so early next week I will try and get some extra debugging information for you before attempting to run the upgrade again with the suggested fixes in place.

Thanks again

Glen

Average of ratings: -

Re: 1.9 - > Upgrade Issue

by Glen Davies - Monday, December 10, 2012, 9:11 AM

Hi Gordon

Here is the fuller debug error message for this problem:

**********************

Warning: sha1() expects parameter 1 to be string, object given in /home/welcom/public_html/lib/filestorage/file_storage.php on line 1486 Warning: strlen() expects parameter 1 to be string, object given in /home/welcom/public_html/lib/filestorage/file_storage.php on line 1487

Incorrect pool file content {$a}.

More information about this error

Debug info:
Error code: hashpoolproblem
Stack trace:
line 1495 of /lib/filestorage/file_storage.php: file_pool_content_exception thrown
line 1149 of /lib/filestorage/file_storage.php: call to file_storage->add_string_to_pool()
line 935 of /lib/filestorage/file_storage.php: call to file_storage->create_file_from_string()
line 495 of /mod/hotpot/db/upgrade.php: call to file_storage->create_file_from_url()
line 627 of /lib/upgradelib.php: call to xmldb_hotpot_upgrade()
line 358 of /lib/upgradelib.php: call to upgrade_plugins_modules()
line 1524 of /lib/upgradelib.php: call to upgrade_plugins()
line 329 of /admin/index.php: call to upgrade_noncore()

*******************

There was only one broken record in the database so we updated this to remove the http:// and the upgraded completed. We did get quite a number of

Source file not found (or empty): course_modules.id=6353, path=Monicas_Activities/Demand_crossword.htm

type notices during the upgrade - is this just due to broken links caused by the moodle filesystem restructure? I am taking it that people will just need to manually go in and fix these references?

Thanks again for your help.

Glen

Average of ratings:Useful (1)

Re: 1.9 - > Upgrade Issue

by Gordon Bateson - Monday, December 10, 2012, 12:00 PM

Thanks a lot Glen,

could you possibly insert the following lines in "lib/filestorage/file_storage.php" at line 935, just BEFORE "return $this->create_file_from_string($filerecord, $content)":

if (is_object($content) && isset($content->error)) {
print_object($content);
throw new moodle_exception($content->error);
}

Then please re-run the upgrade and let me know the new error message.

thanks
Gordon

Average of ratings: -

Hotpot (plugin)

1.9 - > Upgrade Issue