Many thanks for your thorough testing and report. I wish I had had more response like yours.
The only bug I found : When I was filling in the 'normal' questionnaire, I saved and resumed, and although most of my values were retained, the date had defaulted to 1/1/1970, and an error must be in the range 1902-2037 displayed.
*I have fixed that bug, thanks for reporting.
Probably a different label for dependquestion would make it more intuitive, but then I couldn't think of the words to suggest!
*Neither can I.
I wonder if some extra validation is required regarding the page breaks - because the branching doesn't work without them.
*I do not see how I can add that extra validation. It's really up to the questionnaire creator to place the pagebreaks where and as needed.
I can see situations where Date and Numeric could be used to control flow.
*I think those can be taken care of with radio buttons choices. No further development in sight for me.
I wonder if the reports could be improved for conditional branching too - to better reflect the flow of questions in the way the answers are displayed?
*I agree. I have fixed this, by simply removing from the "View by Response" report any question which has not been answered because it has not been displayed to the student due to the skip logic flow they followed.
Display looks good and I assume is using standard moodle methods for outputing this kind of screen?
*yes, same as the Feedback module uses for its non-respondents feature
I wonder what happens when the number of students is huge? It should Page like the admin user interface for user management.
* The number of students displayed on one page is determined by a define('QUESTIONNAIRE_DEFAULT_PAGE_COUNT', 20); value in questionnaire/lib.php
I was going to test validation on the form, so I selected no-one and then tried to send an email. I got an error that emailing is disabled, fine, so I can't test this, but I think I should have got a 'you didn't select anyone' message instead! Similarly there should be validation that a subject and message body have been entered, I think.
*This problem probably occurs because I have disabled bulk emailing on my test site. On a "normal" moodle site, there should be no problem.
I can see there is an extra number in brackets in the average results table, but it seems to be the same as the number that's always been there?
*It is now possible to dissociate rank and value in the "rating" question type. I have made slight changes to the "Complete normal questionnaire" on my test site to make this easier to understand. But it will need more documentation.
Aside from that, I think the second table of statistics is great - lots of useful information in a clear presentation.
View by response
The only very minor comment I have is that 'back to the respondents list' doesn't really need a | after the link, as there's nothing following it.
Essays by name
I wonder what happens to the usability of the reports if the essay submissions are very long? But that's not changed, so not really an issue with your new work.
*Indeed not an issue due to my new development.
I agree with the help comments that these 'look' best if you use the same question type repeatedly. It also 'looks' best if the column headings (like agree/disagree in the example) are only displayed once and the questions are all below. This can also be done if there are blocks of questions of the same type. I doubt that's going to be easy to program though, given the way the module currently works.
*Not quite sure what you mean by "blocks of questions etc".
The setup for these looks complicated to me, but then these things are complicated! I haven't tried to make one for myself because its not really something I'm familiar with. Hopefully others will be able to give better feedback on that part of the process.
* Yes, setting up that kind of questionnaire IS complicated and I see no way to make it simple. I expect people who need them will know what to do, and of course a good read of the online documentation is a MUST!
There is now a "new features" version available on the remote learner for anyone to download and try out on their own test sites: WIP_CONTRIB-3937_MOODLE_23_STABLE