Moodle in English: Cleanup in CVS

General developer forum

Cleanup in CVS

This discussion has been locked because a year has elapsed since the last post. Please start a new discussion topic.

Cleanup in CVS

by Petr Skoda - Monday, February 7, 2005, 3:35 AM

To developers:

I am going through the files in HEAD and I am trying to do a little cleanup. I will post here some questions before commiting non trivial changes to CVS.

1/ should we remove schema.xml and the like from lib/db and mod/attendance?

Those files were added a year ago, IMO they are outdated and not used. Or am I missing something??

Re: Cleanup in CVS

by Petr Skoda - Monday, February 7, 2005, 3:56 AM

2/ delete or fix mod/forum/delete.php?

Does not work due to wrong require, but is not used from any other script. Is it some non-working hidden tool?

Re: Cleanup in CVS

by Martin Dougiamas - Wednesday, February 9, 2005, 11:43 AM

Gone.

Re: Cleanup in CVS

by Petr Skoda - Monday, February 7, 2005, 3:58 AM

3/ delete or fix course/quickreport.php

Again a bit outdated, not linked from any other script.

Re: Cleanup in CVS

by Martin Dougiamas - Wednesday, February 9, 2005, 11:45 AM

I was hoping someone would take this and run with it but yes, it belongs on contrib. Gone.

Re: Cleanup in CVS

by Martín Langhoff - Wednesday, February 9, 2005, 1:10 PM

Recent arrivals (like me) don't feel confident removing files of unknown heritage and history

I'll certainly wait until I'm an old hand before I'm bold enough to start killing files. I already cause enough trouble as things are...

Re: Cleanup in CVS

by Petr Skoda - Wednesday, February 9, 2005, 4:38 PM

Sure, I do not like breaking anyone's toys too

Re: Cleanup in CVS

by Petr Skoda - Monday, February 7, 2005, 4:15 AM

4/ scorm

there is some weird require('../config.php'); in funtion scorm_delete_instance() from mod/scorm/lib.php. IMO there should be
global $CFG; instead.

Re: Cleanup in CVS

by Martin Dougiamas - Wednesday, February 9, 2005, 11:48 AM

That is wierd. Gone!

Re: Cleanup in CVS

by Zbigniew Fiedorowicz - Monday, February 7, 2005, 5:11 AM

Is course/enrol.html used anymore? It looks to me like it has been rendered obsolete by the new enrolment architecture in enrol/

Re: Cleanup in CVS

by Martin Dougiamas - Wednesday, February 9, 2005, 11:46 AM

Zapped!

XML schema files

by Martin Dougiamas - Wednesday, February 9, 2005, 11:41 AM

Yes, probably a good idea. I can't see us making the jump to the XML schema in the near future.