I've added new nolink feature in this editor that uses <span class="nolink"> tag (see bug #2428) (its in CVS).
It need to be tested throughout. If it isn't working then it must not be released.
- Janne -
Excellent! Just checking though: do the filters still support the old <nolink> tag too? Or should we have a compatibility filter to convert from old to new?
Yes it does. The editor it self convert these <nolink> tags to <span class="nolink"> and the glossary filter supports both taggings, so I don't think manual converting isn't necessary?
Hi Janne,
these filtes:
filter/activitynames
mod/wiki/filter
mod/resource/filter
seem to use the nolink too! They should be changed too! Can you do it?
Ciao
these filtes:
filter/activitynames
mod/wiki/filter
mod/resource/filter
seem to use the nolink too! They should be changed too! Can you do it?
Ciao
Good point Eloy, I'd missed those completely.
I'll check them as well.
- Janne -
I'll check them as well.
- Janne -
Awesome - great solution to the problem, Janne!
Don't thank me Lets say there was a quite heavy demand for this
In reply to Janne Mikkonen
Re: NOLINK Testing please!!! - cleanAttributes2 not behaving greatly!
by Janne Mikkonen -
There is a slight problem with cleanAttributes2 function and <span class="nolink">.
This function adds a extra space in the end of the starting tag which can be removed with $attrStr = rtim($attrStr);
The question is, does this change create problems with other tags???
This function adds a extra space in the end of the starting tag which can be removed with $attrStr = rtim($attrStr);
The question is, does this change create problems with other tags???
Hi
The introduction of the <span class="nolink"></span> tag is an excellent idea!
While we are on this topic, may I suggest the introduction of a <span class="link"></span> tag? Let me explain.
Joseph_R
The introduction of the <span class="nolink"></span> tag is an excellent idea!
While we are on this topic, may I suggest the introduction of a <span class="link"></span> tag? Let me explain.
- I do appreciate the possibility of enabling automatic linking of resources to Glossary/ies entries. For my English courses, it is extremely useful.
- However, there are a fairly large number of cases when that automatic auto'linking is not wanted.
- OK, I know I can always use the <nolink></nolink> or the new <span class="nolink"></span> (which, I suppose, works more or less the same?).
- But I am still left with a number of cases where I would like an overall <nolink> effect for a whole document while enabling <link> in some passages only.
- What I would like to do is, e.g., to enclose my whole document in a <span class="nolink"></span> tag and still be able to enclose a few chosen parts of that document in a span class="link"></span> tag.
- Typically I need this for longish HTML pages with a high density of words appearing in the glossary/ies, or Lesson pages with the same density...
Joseph_R
You could write your code like this:
<span class="nolink">Een </span>LED<span class="nolink"> is een lichtgevende diode. Diodes zijn halfgeleiders en
die laten de stroom slechts in 1 richting door. Daarom is de manier
van aansluiten van een </span>LED<span class="nolink"> erg belangrijk: het lange been zit aan de
positieve kant, het korte been aan de negatieve kant. Verkeerd
aansluiten kan bij een spanning van om en bij de 2 á 3 Volt je
ledje al vernietigen.</span>
(I only linked the word LED)
Test report of <span class="nolink"></span> in Moodle 1.5 dev.
- Works OK in :
- uploaded HTML file
- composed Webpage
- composed text page
- Does not work in:
- lessons (the <span class="nolink"></span> is automatically transformed into <span></span> upon display
- glossary definitions