Aaron, thanks for the comment.
Yes, I know the new DB layer and I know how the SQL code looks like in 2.0. Also, using variables inside SQL statement has nothing to do with prepared statements but with binding parameters (syntax is the same but the concept is different). Still, there are situations where you use single quotes (') inside statements - to quote static strings, for example. And, there is a quite often case for putting variables into statements, typically the result of $DB->get_in_or_equal() call.
But apparently I have not underlined the key point here. My proposal has nothing to do with variables expansion. The main reason why I proposed is:
- Petr already uses this syntax for all SQL's he has touched in 2.0. So this is not new at all.
- syntax highlighting - even this may appear unimportant, it really counts if you need to quickly find something.
This means that double quotes should be also used at places like $DB->get_records() parameters - again for quick spotting of any SQL stuff.